From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6468A3160 for ; Sat, 12 Oct 2019 20:54:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABD6E1C230; Sat, 12 Oct 2019 20:54:00 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CE4061C230; Sat, 12 Oct 2019 20:53:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 32682200E3; Sat, 12 Oct 2019 14:53:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 12 Oct 2019 14:53:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Nu6cj5XxzyQBwfCmyTWIu/Xflw0kRIrChUpPZlt7AnE=; b=FEOoQVNSb7G4 jXnazBY64OTwz7S143R7xxp11MdPr9CDB9rsEgKf+KrwZBb/Qbf/v8734FGCFxS3 HS35EuSSHwP3psbTFc5w4IRtRUH/QwlsSiWHsZ5rmKIDE379w753wtby7w+HJLdI 6CFdIoZ+OXfawd6g+okDhmRL6UYKxTo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Nu6cj5XxzyQBwfCmyTWIu/Xflw0kRIrChUpPZlt7A nE=; b=fm3Z0CpHLK1lng9aoqozo3EjU3PfBkx6+DtfcW6vIDXO7iPDNcubJq7Vw H3TfFZElsTWw5iko4S6hDM2UT2C4XKE+nsA0GwUr6HSMPbU4JTTgGjDzzV4ZDGEo 4gWSs5RIGnPRbkmNlDmvfT5iDtafV1to6iZXeGoidfB1TEyycJWwmuy6Fb0Mpli2 jBJfSwkqwLHRkCngmfPmNQzDQntsJ37X63uR1FMZ3+sS0NI0HQViwTHXPVF/PY62 yJajSCGXdvuaGVMZLkvdEJRHicbtstF5jozEfzBwJvvJPPTvwsGJpq7f6M75fUpA Hg43lf7pe1gsvc5bAnuLu5kzU9x+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrieejgddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeduheegrddufeefrdduieeirddvudefnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (unknown [154.133.166.213]) by mail.messagingengine.com (Postfix) with ESMTPA id 12FA88005A; Sat, 12 Oct 2019 14:53:54 -0400 (EDT) From: Thomas Monjalon To: Christian Ehrhardt Cc: stable@dpdk.org, Bruce Richardson , Luca Boccassi , dev , Kevin Laatz Date: Sat, 12 Oct 2019 15:02:59 +0200 Message-ID: <4508605.XBsqFPkRIG@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] build: avoid --as-needed as it causes overlinking X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 12/09/2019 15:43, Christian Ehrhardt: > > On Wed, Sep 4, 2019 at 11:18 AM Bruce Richardson > > wrote: > > > > On Mon, Sep 2, 2019 at 9:09 AM Christian Ehrhardt > > > > wrote: > > > > > > On Thu, 2019-08-29 at 16:34 +0100, Bruce Richardson wrote: > > > > > > > On Thu, Aug 29, 2019 at 05:30:03PM +0200, Christian Ehrhardt wrote: > > > > > > > > --- a/config/meson.build > > > > > > > > +++ b/config/meson.build > > > > > > > > add_project_link_arguments('-Wl,--no-as-needed', language: 'c') > > > > > > > > -dpdk_extra_ldflags += '-Wl,--no-as-needed' > > > > > > > > > > > > > > > > > > > > > > This seems strange to me. What is it about linking the dpdk apps that > > > > > > > require the argument, but makes it safe for non-builtin apps to avoid > > > > > > > having the arg? [...] > > > > > Having it accepted in upstream would make it more easy to fix this in > > > > > the soon to be released Ubuntu 19.10. > > > > > Is there a path to consider taking this fix as-is and continue the > > > > > debug/discussion how the removal of the second line can even cause the > > > > > symptoms that we have seen later? > > > > > > I'm ok with what you propose above. [...] > And actually 18.11 stable would make sense as well IMHO. > Could one who commits could add that as: > Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson") +Cc stable@dpdk.org in the commit log Applied, thanks Title reduced to "avoid overlinking" because --as-needed mention looks wrong. Please continue the investigation to remove the other line "add_project_link_arguments()".