* [dpdk-stable] [PATCH] app/regex: avoid division by zero
@ 2021-05-24 8:57 Thierry Herbelot
2021-05-24 12:09 ` Min Hu (Connor)
2022-07-05 20:16 ` [dpdk-dev] " Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Thierry Herbelot @ 2021-05-24 8:57 UTC (permalink / raw)
To: dev; +Cc: Thierry Herbelot, Thomas Monjalon, stable, Ori Kam
Check that nb_jobs is not zero before using it for a division.
Fixes: f5cffb7eb7fb6 ("app/regex: read data file once at startup")
Cc: stable@dpdk.org
Cc: Ori Kam <orika@nvidia.com>
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
app/test-regex/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-regex/main.c b/app/test-regex/main.c
index 8e665df73ce0..8f48cab11924 100644
--- a/app/test-regex/main.c
+++ b/app/test-regex/main.c
@@ -714,6 +714,8 @@ main(int argc, char **argv)
rte_exit(EXIT_FAILURE, "Number of QPs must be greater than 0\n");
if (nb_lcores == 0)
rte_exit(EXIT_FAILURE, "Number of lcores must be greater than 0\n");
+ if (nb_jobs == 0)
+ rte_exit(EXIT_FAILURE, "Number of jobs must be greater than 0\n");
if (distribute_qps_to_lcores(nb_lcores, nb_qps, &qps_per_lcore) < 0)
rte_exit(EXIT_FAILURE, "Failed to distribute queues to lcores!\n");
ret = init_port(&nb_max_payload, rules_file,
--
2.29.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] app/regex: avoid division by zero
2021-05-24 8:57 [dpdk-stable] [PATCH] app/regex: avoid division by zero Thierry Herbelot
@ 2021-05-24 12:09 ` Min Hu (Connor)
2022-06-26 17:41 ` Thomas Monjalon
2022-07-05 20:16 ` [dpdk-dev] " Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Min Hu (Connor) @ 2021-05-24 12:09 UTC (permalink / raw)
To: Thierry Herbelot, dev; +Cc: Thomas Monjalon, stable, Ori Kam
Hi, Thierry,
This bug has been fixed in my earlier patch, please refer to:
https://patches.dpdk.org/project/dpdk/patch/1618839289-33224-5-git-send-email-humin29@huawei.com/
Thanks.
在 2021/5/24 16:57, Thierry Herbelot 写道:
> Check that nb_jobs is not zero before using it for a division.
>
> Fixes: f5cffb7eb7fb6 ("app/regex: read data file once at startup")
> Cc: stable@dpdk.org
> Cc: Ori Kam <orika@nvidia.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
> app/test-regex/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/app/test-regex/main.c b/app/test-regex/main.c
> index 8e665df73ce0..8f48cab11924 100644
> --- a/app/test-regex/main.c
> +++ b/app/test-regex/main.c
> @@ -714,6 +714,8 @@ main(int argc, char **argv)
> rte_exit(EXIT_FAILURE, "Number of QPs must be greater than 0\n");
> if (nb_lcores == 0)
> rte_exit(EXIT_FAILURE, "Number of lcores must be greater than 0\n");
> + if (nb_jobs == 0)
> + rte_exit(EXIT_FAILURE, "Number of jobs must be greater than 0\n");
> if (distribute_qps_to_lcores(nb_lcores, nb_qps, &qps_per_lcore) < 0)
> rte_exit(EXIT_FAILURE, "Failed to distribute queues to lcores!\n");
> ret = init_port(&nb_max_payload, rules_file,
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] app/regex: avoid division by zero
2021-05-24 12:09 ` Min Hu (Connor)
@ 2022-06-26 17:41 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2022-06-26 17:41 UTC (permalink / raw)
To: Thierry Herbelot, dev, stable; +Cc: stable, Ori Kam, Min Hu (Connor)
24/05/2021 14:09, Min Hu (Connor):
> Hi, Thierry,
> This bug has been fixed in my earlier patch, please refer to:
> https://patches.dpdk.org/project/dpdk/patch/1618839289-33224-5-git-send-email-humin29@huawei.com/
Your patch is doing
+ if (!nb_jobs) {
+ job_len = data_len / nb_jobs;
It looks wrong.
I am for taking Thierry's patch.
> 在 2021/5/24 16:57, Thierry Herbelot 写道:
> > Check that nb_jobs is not zero before using it for a division.
> >
> > Fixes: f5cffb7eb7fb6 ("app/regex: read data file once at startup")
> > Cc: stable@dpdk.org
> > Cc: Ori Kam <orika@nvidia.com>
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > ---
> > app/test-regex/main.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/app/test-regex/main.c b/app/test-regex/main.c
> > index 8e665df73ce0..8f48cab11924 100644
> > --- a/app/test-regex/main.c
> > +++ b/app/test-regex/main.c
> > @@ -714,6 +714,8 @@ main(int argc, char **argv)
> > rte_exit(EXIT_FAILURE, "Number of QPs must be greater than 0\n");
> > if (nb_lcores == 0)
> > rte_exit(EXIT_FAILURE, "Number of lcores must be greater than 0\n");
> > + if (nb_jobs == 0)
> > + rte_exit(EXIT_FAILURE, "Number of jobs must be greater than 0\n");
> > if (distribute_qps_to_lcores(nb_lcores, nb_qps, &qps_per_lcore) < 0)
> > rte_exit(EXIT_FAILURE, "Failed to distribute queues to lcores!\n");
> > ret = init_port(&nb_max_payload, rules_file,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/regex: avoid division by zero
2021-05-24 8:57 [dpdk-stable] [PATCH] app/regex: avoid division by zero Thierry Herbelot
2021-05-24 12:09 ` Min Hu (Connor)
@ 2022-07-05 20:16 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2022-07-05 20:16 UTC (permalink / raw)
To: Thierry Herbelot; +Cc: dev, stable, Ori Kam
24/05/2021 10:57, Thierry Herbelot:
> Check that nb_jobs is not zero before using it for a division.
>
> Fixes: f5cffb7eb7fb6 ("app/regex: read data file once at startup")
> Cc: stable@dpdk.org
> Cc: Ori Kam <orika@nvidia.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Missing ack, but applied after a long wait, sorry.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-05 20:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 8:57 [dpdk-stable] [PATCH] app/regex: avoid division by zero Thierry Herbelot
2021-05-24 12:09 ` Min Hu (Connor)
2022-06-26 17:41 ` Thomas Monjalon
2022-07-05 20:16 ` [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).