patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Baum <michaelba@nvidia.com>, Matan Azrad <matan@nvidia.com>
Cc: Raslan Darawsheh <rasland@nvidia.com>,
	dev@dpdk.org, Slava Ovsiienko <viacheslavo@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Lior Margalit <lmargalit@nvidia.com>,
	Asaf Penso <asafp@nvidia.com>
Subject: Re: [PATCH] net/mlx5: fix devargs validation for multiclass probe
Date: Fri, 26 Nov 2021 13:39:20 +0100
Message-ID: <4551809.0VFYljT9zx@thomas> (raw)
In-Reply-To: <DM4PR12MB538976CCED397EF7C72F6EFBDF629@DM4PR12MB5389.namprd12.prod.outlook.com>

25/11/2021 11:38, Matan Azrad:
> From: Thomas Monjalon
> > 25/11/2021 07:16, michaelba@nvidia.com:
> > > From: Michael Baum <michaelba@nvidia.com>
> > >
> > > The mlx5_args function reads the devargs and checks if they are valid
> > > for this driver and if not it returns an error.
> > >
> > > This was normal behavior as long as all the devargs come to this
> > > driver, but since it is possible to run several drivers together, the
> > > function may return an error for another driver's devarg even though
> > > it is completely valid.
> > > In addition the function does not allow the user to know which of the
> > > devargs he sent is incorrect, but returns an error without printing
> > > the unknown devarg.
> > >
> > > This patch eliminates the error return in the case of an unknown
> > > devarg, and prints a warning for each such devarg specifically.
> > >
> > > Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Michael Baum <michaelba@nvidia.com>
> > > Acked-by: Matan Azrad <matan@nvidia.com>
> > > ---
> > >  drivers/net/mlx5/mlx5.c | 68
> > > ++++++-----------------------------------
> > >  1 file changed, 9 insertions(+), 59 deletions(-)
> > 
> > It is quite a big patch.
> > How well it has been tested?
> 
> It was tested carefully to see that devargs affect the actual configuration and also to allow running !net classes devargs with the net class.
> 
> > How critical it is to have in 21.11?
> 
> CRYPTO class cannot run with NET\ETH on the same device.
> No significant risk here; I suggest taking.

OK, applied, thanks.




      reply	other threads:[~2021-11-26 12:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25  6:16 michaelba
2021-11-25  9:29 ` Thomas Monjalon
2021-11-25 10:38   ` Matan Azrad
2021-11-26 12:39     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4551809.0VFYljT9zx@thomas \
    --to=thomas@monjalon.net \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=lmargalit@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=michaelba@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git