* [dpdk-stable] [PATCH v2] eal: fix check when retrieving current cpu affinity [not found] <1550150874-9535-1-git-send-email-david.marchand@redhat.com> @ 2019-02-19 20:38 ` David Marchand 2019-02-20 16:02 ` Burakov, Anatoly 2019-02-21 18:58 ` [dpdk-stable] [dpdk-dev] " Rami Rosen 0 siblings, 2 replies; 4+ messages in thread From: David Marchand @ 2019-02-19 20:38 UTC (permalink / raw) To: dev; +Cc: anatoly.burakov, stable pthread_getaffinity_np returns a >0 value when failing. This is mainly for the sake of correctness. The only case where it could fail is when passing an incorrect cpuset size wrt to the kernel. Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- Changelog since v1: - added missing Cc: stable@dpdk.org --- lib/librte_eal/common/eal_common_options.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 6c96f45..1f45f82 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c) unsigned int lcore_id; unsigned int removed = 0; rte_cpuset_t affinity_set; - pthread_t tid = pthread_self(); - if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t), - &affinity_set) < 0) + if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t), + &affinity_set)) CPU_ZERO(&affinity_set); for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { -- 1.8.3.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH v2] eal: fix check when retrieving current cpu affinity 2019-02-19 20:38 ` [dpdk-stable] [PATCH v2] eal: fix check when retrieving current cpu affinity David Marchand @ 2019-02-20 16:02 ` Burakov, Anatoly 2019-03-07 15:36 ` Thomas Monjalon 2019-02-21 18:58 ` [dpdk-stable] [dpdk-dev] " Rami Rosen 1 sibling, 1 reply; 4+ messages in thread From: Burakov, Anatoly @ 2019-02-20 16:02 UTC (permalink / raw) To: David Marchand, dev; +Cc: stable On 19-Feb-19 8:38 PM, David Marchand wrote: > pthread_getaffinity_np returns a >0 value when failing. > > This is mainly for the sake of correctness. > The only case where it could fail is when passing an incorrect cpuset > size wrt to the kernel. > > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") > Cc: stable@dpdk.org > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com> -- Thanks, Anatoly ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH v2] eal: fix check when retrieving current cpu affinity 2019-02-20 16:02 ` Burakov, Anatoly @ 2019-03-07 15:36 ` Thomas Monjalon 0 siblings, 0 replies; 4+ messages in thread From: Thomas Monjalon @ 2019-03-07 15:36 UTC (permalink / raw) To: David Marchand; +Cc: stable, Burakov, Anatoly, dev 20/02/2019 17:02, Burakov, Anatoly: > On 19-Feb-19 8:38 PM, David Marchand wrote: > > pthread_getaffinity_np returns a >0 value when failing. > > > > This is mainly for the sake of correctness. > > The only case where it could fail is when passing an incorrect cpuset > > size wrt to the kernel. > > > > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") > > Cc: stable@dpdk.org > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com> Applied, thanks ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] eal: fix check when retrieving current cpu affinity 2019-02-19 20:38 ` [dpdk-stable] [PATCH v2] eal: fix check when retrieving current cpu affinity David Marchand 2019-02-20 16:02 ` Burakov, Anatoly @ 2019-02-21 18:58 ` Rami Rosen 1 sibling, 0 replies; 4+ messages in thread From: Rami Rosen @ 2019-02-21 18:58 UTC (permalink / raw) To: David Marchand; +Cc: dev, anatoly.burakov, stable Reviewed-by: Rami Rosen <ramirose@gmail.com> בתאריך יום ג׳, 19 בפבר׳ 2019, 22:38, מאת David Marchand < david.marchand@redhat.com>: > pthread_getaffinity_np returns a >0 value when failing. > > This is mainly for the sake of correctness. > The only case where it could fail is when passing an incorrect cpuset > size wrt to the kernel. > > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") > Cc: stable@dpdk.org > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > Changelog since v1: > - added missing Cc: stable@dpdk.org > > --- > lib/librte_eal/common/eal_common_options.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_options.c > b/lib/librte_eal/common/eal_common_options.c > index 6c96f45..1f45f82 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c) > unsigned int lcore_id; > unsigned int removed = 0; > rte_cpuset_t affinity_set; > - pthread_t tid = pthread_self(); > > - if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t), > - &affinity_set) < 0) > + if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t), > + &affinity_set)) > CPU_ZERO(&affinity_set); > > for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { > -- > 1.8.3.1 > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-07 15:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1550150874-9535-1-git-send-email-david.marchand@redhat.com>
2019-02-19 20:38 ` [dpdk-stable] [PATCH v2] eal: fix check when retrieving current cpu affinity David Marchand
2019-02-20 16:02 ` Burakov, Anatoly
2019-03-07 15:36 ` Thomas Monjalon
2019-02-21 18:58 ` [dpdk-stable] [dpdk-dev] " Rami Rosen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).