From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D60E942C35 for ; Mon, 5 Jun 2023 15:07:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D04F64113F; Mon, 5 Jun 2023 15:07:55 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 9CD5F4003C; Mon, 5 Jun 2023 15:07:53 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QZYjY2SnyzLqLy; Mon, 5 Jun 2023 21:04:49 +0800 (CST) Received: from [10.67.103.235] (10.67.103.235) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 5 Jun 2023 21:07:50 +0800 Subject: Re: [PATCH 3/5] app/proc-info: fix never show RSS info To: Stephen Hemminger References: <20230315110033.30143-1-liudongdong3@huawei.com> <20230315110033.30143-4-liudongdong3@huawei.com> <20230602141952.41ab2f58@hermes.local> CC: , , , , , , , Jie Hai , Maryam Tahhan , Vipin Varghese , John McNamara From: Dongdong Liu Message-ID: <459f5191-528c-41ff-8907-856fd8bde621@huawei.com> Date: Mon, 5 Jun 2023 21:07:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20230602141952.41ab2f58@hermes.local> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.235] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Stephen On 2023/6/3 5:19, Stephen Hemminger wrote: > On Wed, 15 Mar 2023 19:00:31 +0800 > Dongdong Liu wrote: > >> + rss_key = rte_malloc(NULL, >> + dev_info.hash_key_size * sizeof(uint8_t), 0); >> + if (rss_key == NULL) >> + return; > > Don't use rte_malloc() unless this is a structure that needs to be > shared between primary/secondary. In this case it doesn't need to be shared; > so just use calloc(). Thanks for pointing that, Will do. Thanks, Dongdong > . >