From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1B63B1E2B; Fri, 13 Jan 2017 17:12:07 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 13 Jan 2017 08:12:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,222,1477983600"; d="scan'208";a="1112162170" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga002.fm.intel.com with ESMTP; 13 Jan 2017 08:12:05 -0800 To: Jerin Jacob References: <1484207214-13638-1-git-send-email-jerin.jacob@caviumnetworks.com> <6167bd74-c515-fc12-744d-9168a633c646@intel.com> <20170113032155.GA31838@localhost.localdomain> <2563842.f8ghPspXGG@xps13> <55b009ac-8186-12fe-43b2-b937dc32b8eb@intel.com> <20170113160124.GA17956@localhost.localdomain> Cc: Thomas Monjalon , dev@dpdk.org, stable@dpdk.org From: Ferruh Yigit Message-ID: <45b10ccc-d9f8-c762-3590-c9997319def0@intel.com> Date: Fri, 13 Jan 2017 16:12:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170113160124.GA17956@localhost.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 16:12:08 -0000 On 1/13/2017 4:01 PM, Jerin Jacob wrote: > On Fri, Jan 13, 2017 at 03:57:59PM +0000, Ferruh Yigit wrote: >> On 1/13/2017 3:53 PM, Thomas Monjalon wrote: >>> 2017-01-13 08:51, Jerin Jacob: >>>> On Thu, Jan 12, 2017 at 03:27:30PM +0000, Ferruh Yigit wrote: >>>>> On 1/12/2017 1:58 PM, Jerin Jacob wrote: >>>>>> On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: >>>>>>> 2017-01-12 13:16, Jerin Jacob: >>>>>>>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) >>>>>>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe >>>>>>>> +endif >>>>>>> >>>>>>> _LDLIBS is an internal variable of rte.app.mk. >>>>>>> Please could you check that there is no issue when using LDLIBS instead >>>>>>> of _LDLIBS? >>>>>> >>>> LDLIBS is not helping the situation as LDLIBS comes before the _LDLIBS-y >>>> mk/rte.app.mk:LDLIBS += $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS) >>>> >>>> But moving to EXTRA_LDLIBS looks OK.But it has to be under CONFIG_RTE_LIBRTE_IXGBE_PMD >>>> >>>> Thomas, Ferruh >>>> Let me know if you have any objection on below mentioned diff >>>> >>>> -ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) >>>> -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe >>>> +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) >>>> +EXTRA_LDLIBS += -lrte_pmd_ixgbe >>>> endif >>> >>> You need to keep the shared lib check. >>> Anyway, EXTRA_LDLIBS should be reserved to users and not used in a Makefile. >>> I prefer your initial patch using _LDLIBS. >>> >>> Any objection to merge initial proposal? >>> >> >> LDLIBS should be OK, as long as wrapped with SHARED check. Is following >> not working: > > No, due to the following line > mk/rte.app.mk:LDLIBS += $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS) > > Again -lrte_pmd_ixgbe comes first. You are right. No objection to initial proposal.