* Re: [dpdk-stable] [PATCH] net/tap: remove speed parameter from TAP args
2018-01-26 22:27 [dpdk-stable] [PATCH] net/tap: remove speed parameter from TAP args Vipin Varghese
@ 2018-01-26 17:20 ` Ferruh Yigit
2018-01-31 19:57 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-26 17:20 UTC (permalink / raw)
To: Vipin Varghese, dev; +Cc: stable
On 1/26/2018 10:27 PM, Vipin Varghese wrote:
> TAP is a virtual device created on Kernel. The speed of interface is
> set by Kernel to a fixed static value. But this does not prevent using
> RX or TX to rate limit. Hence removing the option from user arguments.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [PATCH] net/tap: remove speed parameter from TAP args
@ 2018-01-26 22:27 Vipin Varghese
2018-01-26 17:20 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Vipin Varghese @ 2018-01-26 22:27 UTC (permalink / raw)
To: ferruh.yigit, dev; +Cc: stable, Vipin Varghese
TAP is a virtual device created on Kernel. The speed of interface is
set by Kernel to a fixed static value. But this does not prevent using
RX or TX to rate limit. Hence removing the option from user arguments.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
doc/guides/nics/tap.rst | 5 -----
drivers/net/tap/rte_eth_tap.c | 22 ----------------------
2 files changed, 27 deletions(-)
diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst
index dc6f834..528746a 100644
--- a/doc/guides/nics/tap.rst
+++ b/doc/guides/nics/tap.rst
@@ -53,11 +53,6 @@ The interface name can be changed by adding the ``iface=foo0``, for example::
--vdev=net_tap0,iface=foo0 --vdev=net_tap1,iface=foo1, ...
-Also the speed of the interface can be changed from 10G to whatever number
-needed, but the interface does not enforce that speed, for example::
-
- --vdev=net_tap0,iface=foo0,speed=25000
-
Normally the PMD will generate a random MAC address, but when testing or with
a static configuration the developer may need a fixed MAC address style.
Using the option ``mac=fixed`` you can create a fixed known MAC address::
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index fd42572..99d45ea 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -44,7 +44,6 @@
#define DEFAULT_TAP_NAME "dtap"
#define ETH_TAP_IFACE_ARG "iface"
-#define ETH_TAP_SPEED_ARG "speed"
#define ETH_TAP_REMOTE_ARG "remote"
#define ETH_TAP_MAC_ARG "mac"
#define ETH_TAP_MAC_FIXED "fixed"
@@ -53,7 +52,6 @@
static const char *valid_arguments[] = {
ETH_TAP_IFACE_ARG,
- ETH_TAP_SPEED_ARG,
ETH_TAP_REMOTE_ARG,
ETH_TAP_MAC_ARG,
NULL
@@ -1535,16 +1533,6 @@ enum ioctl_mode {
}
static int
-set_interface_speed(const char *key __rte_unused,
- const char *value,
- void *extra_args)
-{
- *(int *)extra_args = (value) ? atoi(value) : ETH_SPEED_NUM_10G;
-
- return 0;
-}
-
-static int
set_remote_iface(const char *key __rte_unused,
const char *value,
void *extra_args)
@@ -1594,15 +1582,6 @@ enum ioctl_mode {
kvlist = rte_kvargs_parse(params, valid_arguments);
if (kvlist) {
- if (rte_kvargs_count(kvlist, ETH_TAP_SPEED_ARG) == 1) {
- ret = rte_kvargs_process(kvlist,
- ETH_TAP_SPEED_ARG,
- &set_interface_speed,
- &speed);
- if (ret == -1)
- goto leave;
- }
-
if (rte_kvargs_count(kvlist, ETH_TAP_IFACE_ARG) == 1) {
ret = rte_kvargs_process(kvlist,
ETH_TAP_IFACE_ARG,
@@ -1700,6 +1679,5 @@ enum ioctl_mode {
RTE_PMD_REGISTER_ALIAS(net_tap, eth_tap);
RTE_PMD_REGISTER_PARAM_STRING(net_tap,
ETH_TAP_IFACE_ARG "=<string> "
- ETH_TAP_SPEED_ARG "=<int> "
ETH_TAP_MAC_ARG "=" ETH_TAP_MAC_FIXED " "
ETH_TAP_REMOTE_ARG "=<string>");
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH] net/tap: remove speed parameter from TAP args
2018-01-26 17:20 ` Ferruh Yigit
@ 2018-01-31 19:57 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-31 19:57 UTC (permalink / raw)
To: Vipin Varghese, dev; +Cc: stable
On 1/26/2018 5:20 PM, Ferruh Yigit wrote:
> On 1/26/2018 10:27 PM, Vipin Varghese wrote:
>> TAP is a virtual device created on Kernel. The speed of interface is
>> set by Kernel to a fixed static value. But this does not prevent using
>> RX or TX to rate limit. Hence removing the option from user arguments.
>>
>> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-31 19:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-26 22:27 [dpdk-stable] [PATCH] net/tap: remove speed parameter from TAP args Vipin Varghese
2018-01-26 17:20 ` Ferruh Yigit
2018-01-31 19:57 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).