From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: stable@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
Chas Williams <chas3@att.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Reshma Pattan <reshma.pattan@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled
Date: Sun, 19 Jan 2020 22:50:06 +0100
Message-ID: <4605926.oAaWjsssbx@xps> (raw)
In-Reply-To: <20191223065305.18434-1-reshma.pattan@intel.com>
Someone to review please?
23/12/2019 07:53, Reshma Pattan:
> Some unit tests has dependency on RING PMD,
> so this patch is trying to fix those and other
> closely related issues.
>
> 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter
> unit tests are dependent on ring PMD, so compile those
> tests only when ring PMD is enabled else ignore.
>
> 2)get rid of make file error which was added by bond unit test
> for ring PMD disabled case which is not necessary.
>
> 3)Tx adapter UT is dependent on RING PMD, but it was
> observed that it was missing from the run in meson
> build, so added it. TX adapter UT uses 'sw event and
> 'null' pmd drivers, so for shared builds the drivers .so
> path has to be passed to the test args of meson UT run.
>
> Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library")
> Fixes: fdeb30fa71 ("test/bitrate: add unit tests for bitrate library")
> Fixes: 1e3676a06e ("test/latency: add unit tests for latencystats library")
> Fixes: 46cf97e4bb ("eventdev: add test for eth Tx adapter")
> Fixes: d23e09e0ef ("app/test: link with ring pmd when needed")
>
> CC: stable@dpdk.org
> CC: Nikhil Rao <nikhil.rao@intel.com>
> CC: Chas Williams <chas3@att.com>
> CC: Bruce Richardson <bruce.richardson@intel.com>
> CC: Stephen Hemminger <stephen@networkplumber.org>
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> v5: remove extra blank line.
> v4: fix event_eth_tx_adapter_autotest for shared build
> as reported by travis-ci
> https://travis-ci.com/ovsrobot/dpdk/jobs/249598391
> v3: add missing test event_eth_tx_adapter_autotest.
> Add link bonding mode4 test to drivers test.
> v2: fix comments of v1 and combine the patches 1/2 and 2/2 of v1
> ---
> app/test/Makefile | 16 +++++-----------
> app/test/meson.build | 36 ++++++++++++++++++++++--------------
> app/test/process.h | 8 ++++++++
> app/test/test.c | 2 ++
> 4 files changed, 37 insertions(+), 25 deletions(-)
next prev parent reply other threads:[~2020-01-19 21:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 9:41 [dpdk-stable] [PATCH 1/2] app/test: fix make " Reshma Pattan
2019-10-17 9:41 ` [dpdk-stable] [PATCH 2/2] app/test: fix meson " Reshma Pattan
2019-10-17 9:51 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2019-10-17 9:54 ` [dpdk-stable] " David Marchand
2019-10-17 9:48 ` [dpdk-stable] [PATCH 1/2] app/test: fix make " Bruce Richardson
2019-10-17 11:16 ` [dpdk-stable] [PATCH v2] app/test: fix " Reshma Pattan
2019-10-17 13:46 ` Bruce Richardson
2019-10-25 8:11 ` [dpdk-stable] [dpdk-dev] " David Marchand
2019-10-25 15:40 ` Pattan, Reshma
2019-10-25 15:38 ` [dpdk-stable] [PATCH v3] " Reshma Pattan
2019-10-27 8:47 ` David Marchand
2019-10-29 9:36 ` Pattan, Reshma
2019-10-31 7:58 ` David Marchand
2019-10-31 10:18 ` Pattan, Reshma
2019-12-09 13:38 ` Pattan, Reshma
2019-12-09 16:54 ` Ferruh Yigit
2019-12-09 18:00 ` Aaron Conole
2019-12-18 11:58 ` [dpdk-stable] [PATCH v4] " Reshma Pattan
2019-12-18 16:07 ` Bruce Richardson
2019-12-18 16:23 ` Pattan, Reshma
2019-12-23 6:53 ` [dpdk-stable] [PATCH v5] " Reshma Pattan
2020-01-19 21:50 ` Thomas Monjalon [this message]
2020-01-20 9:55 ` [dpdk-stable] [dpdk-dev] " Rao, Nikhil
2020-01-20 17:36 ` [dpdk-stable] " Bruce Richardson
2020-02-16 18:10 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4605926.oAaWjsssbx@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
patches for DPDK stable branches
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
stable@dpdk.org
public-inbox-index stable
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.stable
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git