From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF8C0A04AC for ; Wed, 12 Aug 2020 10:38:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A6331C0BD; Wed, 12 Aug 2020 10:38:17 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 876C31C0BD for ; Wed, 12 Aug 2020 10:38:16 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id f18so3751226wmc.0 for ; Wed, 12 Aug 2020 01:38:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Luj3FgxBg1uMVAa33ftuhQUPzr4R2INE5NPDNxSktLo=; b=e8lmNQeOimQI2YAVrOZ5l2XzVL7QNjYQSiOFONflWU9EFfYagVSQqPywGPhjVfo2cf s9gQ84FJQjKOmNvr5lYAak8gzw+oxmsT7EAubaVsq74hz9Wh/+qVwooaR4ovJcSDlaSO oHcUTsy1RMCWL6Y1Ao0kIkTM1V6GnqeI5Jx4zUTHWGdHHPXG4BfHPAjayHScc3gyTrxq rwBwZi07H0pLYKgpAwANsBcVujvMhl0uG87rmIaXDiTRqbyxEezCTK6QCFH7u3JcdAWz gcTisRK/0/lCKft/HYyldHq1hO89lyGWIp1aOMdAWv0N6YIhYzCJUMWpzpsiJmnA8kWA aGWg== X-Gm-Message-State: AOAM530I/pN/lUbT1w2DFbf9oIrVaJMSYEP3TCIFs3R25MJa0rdlMTK2 xrG5bW6GAJhnnctwDkUbxm8= X-Google-Smtp-Source: ABdhPJyiJEOtXDZn+f2XMQzgSsZTi4Bb+YzXLIIVUqngPNeMXDrm4pNPcE3lRvmtiR8jSaWtRo4V+g== X-Received: by 2002:a1c:2e4e:: with SMTP id u75mr7332312wmu.134.1597221496131; Wed, 12 Aug 2020 01:38:16 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 8sm3023912wrl.7.2020.08.12.01.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 01:38:15 -0700 (PDT) Message-ID: <46749d3e5468b12d77f586181651666c38deffae.camel@debian.org> From: Luca Boccassi To: Kalesh A P , stable@dpdk.org Cc: ajit.khaparde@broadcom.com Date: Wed, 12 Aug 2020 09:38:14 +0100 In-Reply-To: <20200812035235.32516-1-kalesh-anakkur.purayil@broadcom.com> References: <20200812035235.32516-1-kalesh-anakkur.purayil@broadcom.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 19.11 1/2] net/bnxt: support speed capabilities query X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, 2020-08-12 at 09:22 +0530, Kalesh A P wrote: > From: Kalesh AP >=20 > [ upstream commit 85cf7f2bba0f665fe91710cd1cf0ca852f73890a ] >=20 > Added information about supported speeds for the port in the > "dev_infos_get". As other PMDs are returning the speed capabilities, > apps may expect this behavior from bnxt PMD. >=20 > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) >=20 > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethde= v.c > index fe240b6..90e1a33 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -490,6 +490,40 @@ static int bnxt_shutdown_nic(struct bnxt *bp) > * Device configuration and status function > */ > =20 > +static uint32_t bnxt_get_speed_capabilities(struct bnxt *bp) > +{ > + uint32_t link_speed =3D bp->link_info.support_speeds; > + uint32_t speed_capa =3D 0; > + > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_LINK_SPEED_100MB) > + speed_capa |=3D ETH_LINK_SPEED_100M; > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_100MBHD) > + speed_capa |=3D ETH_LINK_SPEED_100M_HD; > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_1GB) > + speed_capa |=3D ETH_LINK_SPEED_1G; > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_2_5GB) > + speed_capa |=3D ETH_LINK_SPEED_2_5G; > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_10GB) > + speed_capa |=3D ETH_LINK_SPEED_10G; > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_20GB) > + speed_capa |=3D ETH_LINK_SPEED_20G; > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_25GB) > + speed_capa |=3D ETH_LINK_SPEED_25G; > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_40GB) > + speed_capa |=3D ETH_LINK_SPEED_40G; > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_50GB) > + speed_capa |=3D ETH_LINK_SPEED_50G; > + if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_100GB) > + speed_capa |=3D ETH_LINK_SPEED_100G; > + > + if (bp->link_info.auto_mode =3D=3D HWRM_PORT_PHY_QCFG_OUTPUT_AUTO_MODE_= NONE) > + speed_capa |=3D ETH_LINK_SPEED_FIXED; > + else > + speed_capa |=3D ETH_LINK_SPEED_AUTONEG; > + > + return speed_capa; > +} > + > static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, > struct rte_eth_dev_info *dev_info) > { > @@ -533,6 +567,8 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *e= th_dev, > dev_info->tx_offload_capa =3D BNXT_DEV_TX_OFFLOAD_SUPPORT; > dev_info->flow_type_rss_offloads =3D BNXT_ETH_RSS_SUPPORT; > =20 > + dev_info->speed_capa =3D bnxt_get_speed_capabilities(bp); > + > /* *INDENT-OFF* */ > dev_info->default_rxconf =3D (struct rte_eth_rxconf) { > .rx_thresh =3D { Hi, This smells like a feature? 20.02 does not have it, so what happens if a user expects this to work and upgrades from 19.11.x to 20.02? --=20 Kind regards, Luca Boccassi