From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70042.outbound.protection.outlook.com [40.107.7.42]) by dpdk.org (Postfix) with ESMTP id 3259D1B9A0 for ; Wed, 19 Dec 2018 12:04:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ACw9C6gHdYFTRl/aqUBf82l4SghLc4pkKdcEb5FHfms=; b=ojPtNOsDmeKWo/a04NrMcpLIf6j2Jg8fG5G+jnCtTkqL0LIA+gGyMAfSFp25a/Eahe4TsU6J3fJt2+NOA+oDIfLSPU/eWL30GjrJYNSvFlMVuoxsWtPrLOKNGlXHmPyC3BGOIdtE1XDxPifwyiU9eVHdOu7/EGA9cT7KnQM9Ezs= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4091.eurprd05.prod.outlook.com (52.134.68.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1446.17; Wed, 19 Dec 2018 11:04:55 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d43a:3775:8af7:29c6]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d43a:3775:8af7:29c6%3]) with mapi id 15.20.1425.023; Wed, 19 Dec 2018 11:04:55 +0000 From: Yongseok Koh To: Thomas Monjalon CC: "stable@dpdk.org" , Qi Zhang , Konstantin Ananyev Thread-Topic: [dpdk-stable] [prefix=PATCH 17.11] ethdev: fix queue start and stop Thread-Index: AQHUk/tH5Tl+8DsXRUOuTA4jiO3hqKWF7WAA Date: Wed, 19 Dec 2018 11:04:55 +0000 Message-ID: <471A1AC8-A6F6-4B09-A09C-B48AF0D3168E@mellanox.com> References: <20181214222043.7394-1-yskoh@mellanox.com> In-Reply-To: <20181214222043.7394-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4091; 6:WVITiLZ3R96Uzdvb0kj2s3eC3cnuRXB3BbLc5/h8+zAAuBHEHP3F7ZQK6UrOpLfg9y12LMv6+sMbSYjKOviBzQjSVu4fVehSL0f4dvSAUUEgM9eO14LUlUStVa6yL+VTH5ewK1vydR1A+NBT/oG3RCoe0DZID/ItVXLVzBKjEijXvfDr+y/JKAqNGXCZmut+J5HGwd1jvA3k6booVC22HUaICbXr9W0T8QiGSzTpVlscInbWL3MuWaJwEaszeXigKDPtuHyI3yAyce3Yip7kTGDN7HSTRfNdvkZJ9eoCsCULu0bZcMptVkZri9XoPeV0nLkEtlSSYRDhfeIlAZzZ1H/VZ8ACfie6xfNgiZd3NA8fr6i/n0FVbkzXJjCFSFd+qWRPuDpd0W7XC2eYTjFVxE+xFsf41yrvuagn3wrqKZu8Us+Fp2FXsA01Q0FNkmhWK/vsGmgrnnzRA+mHrCF/sA==; 5:sELpMwz8LJI0hkoXXHZaQXN46/Ajfa+/Kw8v5ahiXzJLJ7rWRuOMXx67qv0ZI8Y5nIw8xs4gKyjguLKggrhjnoSpwP/KKkYSpNwA+SMQw4Wfd4qjRf4JzTICWflrot6za2NiF1Ck3IjYOfc6P8TrivHXzsBVh6/QTvinf5bXrsQ=; 7:HUkbVj/tGsAmaDSvrx4Xf83sE9LOpLD5r3CyWkeS5eXKpxj/XjbxsLCE6ujTV3LKFxJ8bphYRCOlyKNDNYLEoy4lSkg7mip9YSTo04kswwMhaUNn0B0cJq4CRp5MTWfIQ+qVOP/ueBHXRc6kDU+x5w== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 12a12923-e77f-4c1e-4fdb-08d665a1ceff x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4091; x-ms-traffictypediagnostic: DB3PR0502MB4091: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231475)(944501520)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:DB3PR0502MB4091; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4091; x-forefront-prvs: 0891BC3F3D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(376002)(39860400002)(346002)(366004)(199004)(189003)(2906002)(102836004)(2616005)(305945005)(476003)(106356001)(6916009)(82746002)(53936002)(7736002)(99286004)(25786009)(68736007)(66066001)(54906003)(316002)(11346002)(5660300001)(26005)(446003)(36756003)(186003)(6246003)(229853002)(71190400001)(71200400001)(86362001)(14454004)(97736004)(8936002)(33656002)(8676002)(81166006)(4326008)(6506007)(81156014)(105586002)(486006)(6436002)(256004)(53546011)(6486002)(3846002)(6116002)(478600001)(83716004)(6512007)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4091; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 0FRGpv+gHmZAr+Q+fC46vSs3B8j+AIOP8C3DDW5nF8EDV1iSBeHsZRsRgsFgj37LkDvdgvt8ILzHVQBnvZhIN1ds7FPlRqY4pvjZg0fL0UNMh4IGQIUQg+pxXlbYEG43hsSSFlO+cwgSWYVN+OTtZwTuoSCUy9NcPePbre9DewPby31ofpoJsLNyst8LMU0EZ2WJasaE192Yfbbl8UeAW2pqx5jiU9fB4Vn+CzRinN/7vp9bdcASmv0tM3p5KM/El0iw+Zv2omdj9kNenzhGBqDClPoQq7ndTWxjAzgJJ4Ro/z7diQZ7McwE5lvchBVk spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12a12923-e77f-4c1e-4fdb-08d665a1ceff X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2018 11:04:55.5857 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4091 Subject: Re: [dpdk-stable] [prefix=PATCH 17.11] ethdev: fix queue start and stop X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 11:04:57 -0000 > On Dec 14, 2018, at 2:20 PM, Yongseok Koh wrote: >=20 > This patch reverts > commit d48890a39af7 ("ethdev: fix queue start") > as the corresponding upstream commit was incorrectly applied. >=20 > The upstream commit is re-applied correctly. > commit 239c9b435ad4 ("ethdev: fix queue start") >=20 > Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") > Fixes: d48890a39af7 ("ethdev: fix queue start") > Cc: Qi Zhang > Cc: Konstantin Ananyev >=20 > Signed-off-by: Yongseok Koh > Reported-by: Konstantin Ananyev > Reported-by: Qi Zhang > --- applied to stable/17.11 thanks, yongseok > lib/librte_ether/rte_ethdev.c | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) >=20 > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.= c > index eea11d066..096b35faf 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -507,6 +507,13 @@ rte_eth_dev_rx_queue_start(uint16_t port_id, uint16_= t rx_queue_id) > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); >=20 > dev =3D &rte_eth_devices[port_id]; > + if (!dev->data->dev_started) { > + RTE_PMD_DEBUG_TRACE( > + "port %d must be started before start any queue\n", > + port_id); > + return -EINVAL; > + } > + > if (rx_queue_id >=3D dev->data->nb_rx_queues) { > RTE_PMD_DEBUG_TRACE("Invalid RX queue_id=3D%d\n", rx_queue_id); > return -EINVAL; > @@ -533,12 +540,6 @@ rte_eth_dev_rx_queue_stop(uint16_t port_id, uint16_t= rx_queue_id) > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); >=20 > dev =3D &rte_eth_devices[port_id]; > - if (!dev->data->dev_started) { > - RTE_PMD_DEBUG_TRACE( > - "port %d must be started before start any queue\n", port_id); > - return -EINVAL; > - } > - > if (rx_queue_id >=3D dev->data->nb_rx_queues) { > RTE_PMD_DEBUG_TRACE("Invalid RX queue_id=3D%d\n", rx_queue_id); > return -EINVAL; > @@ -565,6 +566,13 @@ rte_eth_dev_tx_queue_start(uint16_t port_id, uint16_= t tx_queue_id) > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); >=20 > dev =3D &rte_eth_devices[port_id]; > + if (!dev->data->dev_started) { > + RTE_PMD_DEBUG_TRACE( > + "port %d must be started before start any queue\n", > + port_id); > + return -EINVAL; > + } > + > if (tx_queue_id >=3D dev->data->nb_tx_queues) { > RTE_PMD_DEBUG_TRACE("Invalid TX queue_id=3D%d\n", tx_queue_id); > return -EINVAL; > @@ -591,12 +599,6 @@ rte_eth_dev_tx_queue_stop(uint16_t port_id, uint16_t= tx_queue_id) > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); >=20 > dev =3D &rte_eth_devices[port_id]; > - if (!dev->data->dev_started) { > - RTE_PMD_DEBUG_TRACE( > - "port %d must be started before start any queue\n", port_id); > - return -EINVAL; > - } > - > if (tx_queue_id >=3D dev->data->nb_tx_queues) { > RTE_PMD_DEBUG_TRACE("Invalid TX queue_id=3D%d\n", tx_queue_id); > return -EINVAL; > --=20 > 2.11.0 >=20