From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 58F15377A for ; Wed, 9 Nov 2016 10:58:21 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id p190so297309383wmp.1 for ; Wed, 09 Nov 2016 01:58:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=LX1tsPua6HsxEWkdZPkR4BKXr+H2e05Lxer9O2PWP5Y=; b=TYmpEVyk+sPUSU7ZKG4dc1QwS15IL9UD0wARuheT9Ax4VCALSimNuRegFKXD2ijH+y dFPAF9RKPmQdXldo9mYBw0yfG87Sj2hOONmMJmUqLgR3ByXFHON3bHQyKLT6tkX8y1Qn 7cWfNS2JdPrX0RrkOX9yvvESwq1Hx96yeh7vyEv1EIlrtfWFttGkK0meSJETcddhPO3h 7xrb8usLMUdhRmZdr7TXtG8/m5ar5rxrahQUvGiVsOdHC/kftkczp8HO8WFjirMPj1Oq VWVIPfw7GeEqkOQbIY6W3RjIOMhV2ZGFZpUnZszdwv4dnkhI8nlXWt/uWzVmljlyyyrJ HpAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=LX1tsPua6HsxEWkdZPkR4BKXr+H2e05Lxer9O2PWP5Y=; b=FxDs3XyM3JxG8C/MgH8QUeoEQO3mrXuPK+KH02PGLxu/sdhKb4W2Tb8QCQZdxAvK8/ ekkQkwsG7kzlTA+th9IVIDtIFIjRn5GFgEt1bDSj1znb1S9mrvq54laQUhXGymuP3eqj hHYw5GZDm4K8bmgdG2bd5VNvmiESPRQ6cc8UXUzPrqlnPzJDxGDIgwknwmeDeCTmT4Ie qoxMYPBfLcC1Jwz2dac75JqfjnvNtmdyPUmzkSu4aqKi7FaswWUlw07X4RZVyHfMONuh rpieqqSn5EXOdO7tUgnsC9hBS1sjI5ykC9+xzZOEKZbUAZhYSkY1vtKuG1YSiHwuDTZ5 +A0A== X-Gm-Message-State: ABUngvcIbF3oylzBGHffQuiD13KZq+Kz23ZLNmCcVVeAsX2dwuyrBLxqG5DplkNdbGdVLiYF X-Received: by 10.28.131.72 with SMTP id f69mr16485669wmd.33.1478685501077; Wed, 09 Nov 2016 01:58:21 -0800 (PST) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id c133sm13926057wme.12.2016.11.09.01.58.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 09 Nov 2016 01:58:20 -0800 (PST) From: Nelio Laranjeiro To: stable@dpdk.org, Yuanhan Liu Cc: Raslan Darawsheh , Adrien Mazarguil Date: Wed, 9 Nov 2016 10:57:44 +0100 Message-Id: <47398873f26ec0bf36402c613c1a561d23b1816a.1478683594.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-stable] [PATCH v2 05/12] net/mlx5: fix removing VLAN filter X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2016 09:58:21 -0000 From: Raslan Darawsheh [ upstream commit 70d32d3afebfdd827f5f949f588f56d9e7563520 ] memmove was moving bytes as the number of elements next to i, while it should move the number of elements multiplied by the size of each element. Fixes: e9086978 ("mlx5: support VLAN filtering") Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5_vlan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_vlan.c b/drivers/net/mlx5/mlx5_vlan.c index 64e599d..1b0fa40 100644 --- a/drivers/net/mlx5/mlx5_vlan.c +++ b/drivers/net/mlx5/mlx5_vlan.c @@ -87,7 +87,8 @@ vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) --priv->vlan_filter_n; memmove(&priv->vlan_filter[i], &priv->vlan_filter[i + 1], - priv->vlan_filter_n - i); + sizeof(priv->vlan_filter[i]) * + (priv->vlan_filter_n - i)); priv->vlan_filter[priv->vlan_filter_n] = 0; } else { assert(i == priv->vlan_filter_n); -- 2.1.4