From: "Mei, JianweiX" <jianweix.mei@intel.com>
To: "Fu, YanX" <yanx.fu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Guo, Jia" <jia.guo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Fu, YanX" <yanx.fu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 1/1] net/ice: fix link status down
Date: Tue, 15 Sep 2020 06:54:32 +0000 [thread overview]
Message-ID: <473cff3b0cab4136a4d37a29d27ab50d@intel.com> (raw)
In-Reply-To: <20200908224714.91088-1-yanx.fu@intel.com>
Tested-by: Mei,JianweiX < jianweix.mei@intel.com>
-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of yanx.fu@intel.com
Sent: Wednesday, September 9, 2020 6:47 AM
To: Zhang, Qi Z <qi.z.zhang@intel.com>; Guo, Jia <jia.guo@intel.com>
Cc: dev@dpdk.org; Fu, YanX <yanx.fu@intel.com>; stable@dpdk.org
Subject: [dpdk-dev] [PATCH v1 1/1] net/ice: fix link status down
From: FuYanX <yanx.fu@intel.com>
Add delay to ensure that the hardware FLR is completed.
Fixes: f9cf4f864150 (net/ice: support device initialization)
Cc: stable@dpdk.org
Signed-off-by: FuYanX <yanx.fu@intel.com>
---
drivers/net/ice/ice_ethdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 8d435e889..20bd85e62 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2176,6 +2176,11 @@ ice_dev_init(struct rte_eth_dev *dev)
ice_init_controlq_parameter(hw);
+ /* The driver e.g. vfio-pci may triggle a FLR reset.
+ * The operating system is required by PCIe specification to wait 100 ms
+ * before it can assume that the FLR sequence is completed by hardware.
+ */
+ rte_delay_ms(100);
ret = ice_init_hw(hw);
if (ret) {
PMD_INIT_LOG(ERR, "Failed to initialize HW");
--
2.25.1
prev parent reply other threads:[~2020-09-15 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 22:47 [dpdk-stable] [dpdk-dev][PATCH " yanx.fu
2020-09-15 6:54 ` Mei, JianweiX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473cff3b0cab4136a4d37a29d27ab50d@intel.com \
--to=jianweix.mei@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=yanx.fu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).