From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org, Keith Wiles <keith.wiles@intel.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
dev@dpdk.org
Subject: Re: [PATCH] build: fix invalid characters in toolchain definitions
Date: Mon, 20 Feb 2023 01:20:18 +0100 [thread overview]
Message-ID: <4765709.F8r316W7xa@thomas> (raw)
In-Reply-To: <20230208180810.GA24727@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
08/02/2023 19:08, Tyler Retzlaff:
> On Tue, Feb 07, 2023 at 03:22:00PM +0000, Bruce Richardson wrote:
> > When using "icx" (Intel(R) oneAPI DPC++/C++ Compiler) to build DPDK,
> > meson reports the toolchain as "intel-llvm"[1]. This value is used
> > directly to define the RTE_TOOLCHAIN macros, which means that we end up
> > with the invalid macro name "RTE_TOOLCHAIN_INTEL-LLVM", and getting the
> > compiler warning:
> >
> > ./rte_build_config.h:422:28: warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions]
> >
> > This can be fixed, and the macro generation made more robust generally,
> > by adding "underscorify()" on the string. This replaces the "-", and
> > any other invalid characters, with "_" [2].
> >
> > [1] https://mesonbuild.com/Reference-tables.html#compiler-ids
> > [2] https://mesonbuild.com/Reference-manual_elementary_str.html#strunderscorify
> >
> > Fixes: afd18fa21b5e ("build: set toolchain info during meson configure")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Keith Wiles <keith.wiles@intel.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
prev parent reply other threads:[~2023-02-20 0:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 15:22 Bruce Richardson
2023-02-08 15:33 ` Wiles, Keith
2023-02-08 17:11 ` Bruce Richardson
2023-02-08 18:08 ` Tyler Retzlaff
2023-02-20 0:20 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4765709.F8r316W7xa@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).