From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D49941CE4 for ; Mon, 20 Feb 2023 01:20:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6865D42D8D; Mon, 20 Feb 2023 01:20:25 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 0F42140691; Mon, 20 Feb 2023 01:20:24 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 6ABCC320097E; Sun, 19 Feb 2023 19:20:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 19 Feb 2023 19:20:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676852421; x= 1676938821; bh=Tp0+pIE8s2tmVBzAFW3ciBd02VDpM4KIqq8EnAKLvkA=; b=S j3LfsQElubtAMitEDU9NYTnfxw4XgjCI+BWPCVn+ixWY2/uhDCPBNk890+F5gYoT SHIo8kFAzqVinzKBrsCkTmuUblpTrG97dsfc0O1p1NvtsEGsJWjFrs+/Vaxll8WP dooK8QC2+VH0fhlQ8PBnSgpm2o7aNOzfpWFcZnYeDEwBENWY+SUE192tF6xeKppK 2VUv95xB1VX4eF78kUdUPqS29n2+xyNX2kliSbBrJiWXS1Cdbm6cAIgepv2trLY7 EUQXxHnafPFUJOUcvK4zPlMZfcmhg9fY4oyINQ4yjDMqsmSj6yZK+mIOxcgwphRO 4JLZ2wY+EVFZlfFqHLmlQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676852421; x= 1676938821; bh=Tp0+pIE8s2tmVBzAFW3ciBd02VDpM4KIqq8EnAKLvkA=; b=l u6/rMAYDG1ezeSmSoDH7t3BT/75byc5BUQFlwLNYbxJesQAJtLFNo7PYS1ATXozJ HhC7o+ciLPcQleWk55KurhhRYGiNfr3N9OsCRxTYX8Q6aNh70osQj8yr4coqSQNC 9kxPbS1gYhAHWdnqOOpTt4rpqCARenL/gX6G++QrToho1e66GJA3HuEjvhJkzr0I u81FlFkUmWiaXymMQ3PiOjMcRH5JigLrO/ri2qTx9TIQHQ6Ajbp+38v8MAbk6D12 wHoeryCWQLZYMTpIrGQpIEO8sbqkVxKUgZYZU/TeifBNCluyJOA0Cyo7Jvndr3vX XdSK5nMhQkPnqEXWC7amA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejgedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefheeuuefgteekfeetvdfhveffvdevfeekvdffueffveffhfdu teettddvheeuheenucffohhmrghinhepmhgvshhonhgsuhhilhgurdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehm ohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Feb 2023 19:20:20 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: stable@dpdk.org, Keith Wiles , Tyler Retzlaff , dev@dpdk.org Subject: Re: [PATCH] build: fix invalid characters in toolchain definitions Date: Mon, 20 Feb 2023 01:20:18 +0100 Message-ID: <4765709.F8r316W7xa@thomas> In-Reply-To: <20230208180810.GA24727@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230207152200.122227-1-bruce.richardson@intel.com> <20230208180810.GA24727@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 08/02/2023 19:08, Tyler Retzlaff: > On Tue, Feb 07, 2023 at 03:22:00PM +0000, Bruce Richardson wrote: > > When using "icx" (Intel(R) oneAPI DPC++/C++ Compiler) to build DPDK, > > meson reports the toolchain as "intel-llvm"[1]. This value is used > > directly to define the RTE_TOOLCHAIN macros, which means that we end up > > with the invalid macro name "RTE_TOOLCHAIN_INTEL-LLVM", and getting the > > compiler warning: > > > > ./rte_build_config.h:422:28: warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions] > > > > This can be fixed, and the macro generation made more robust generally, > > by adding "underscorify()" on the string. This replaces the "-", and > > any other invalid characters, with "_" [2]. > > > > [1] https://mesonbuild.com/Reference-tables.html#compiler-ids > > [2] https://mesonbuild.com/Reference-manual_elementary_str.html#strunderscorify > > > > Fixes: afd18fa21b5e ("build: set toolchain info during meson configure") > > Cc: stable@dpdk.org > > > > Reported-by: Keith Wiles > > Signed-off-by: Bruce Richardson > > Acked-by: Tyler Retzlaff Applied, thanks.