From: Kevin Traynor <ktraynor@redhat.com>
To: Ali Alnubani <alialnu@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Cc: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [dpdk-stable] [PATCH v2 3/3] [18.11] net/mlx4: remove device register remap
Date: Wed, 8 Jul 2020 10:33:57 +0100
Message-ID: <48ea70c2-7807-88a8-b9b2-0699c49147b1@redhat.com> (raw)
In-Reply-To: <AM0PR05MB44012E7502C21E9BF7A42850D7670@AM0PR05MB4401.eurprd05.prod.outlook.com>
On 08/07/2020 10:28, Ali Alnubani wrote:
>> -----Original Message-----
>> From: stable <stable-bounces@dpdk.org> On Behalf Of Viacheslav Ovsiienko
>> Sent: Tuesday, July 7, 2020 10:13 AM
>> To: stable@dpdk.org
>> Cc: ktraynor@redhat.com; Yongseok Koh <yskoh@mellanox.com>
>> Subject: [dpdk-stable] [PATCH v2 3/3] [18.11] net/mlx4: remove device
>> register remap
>>
>> From: Yongseok Koh <yskoh@mellanox.com>
>>
>> UAR (User Access Region) register does not need to be remapped for
>> primary process but it should be remapped only for secondary process.
>> UAR register table is in the process private structure in rte_eth_devices[],
>> (struct mlx4_proc_priv *)rte_eth_devices[port_id].process_private
>>
>> The actual UAR table follows the data structure and the table is used for both
>> Tx and Rx.
>>
>> For Tx, BlueFlame in UAR is used to ring the doorbell.
>> MLX4_TX_BFREG(txq) is defined to get a register for the txq. Processes
>> access its own private data to acquire the register from the UAR table.
>>
>> For Rx, the doorbell in UAR is required in arming CQ event. However, it is a
>> known issue that the register isn't remapped for secondary process.
>>
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>
> Tested-by: Ali Alnubani <alialnu@mellanox.com>
>
Applied, thanks Slava and Ali (and Yongseok o/)
next prev parent reply other threads:[~2020-07-08 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 7:12 [dpdk-stable] [PATCH v2 1/3] [18.11] net/mlx5: fix recursive inclusion of header file Viacheslav Ovsiienko
2020-07-07 7:12 ` [dpdk-stable] [PATCH v2 2/3] [18.11] net/mlx5: remove device register remap Viacheslav Ovsiienko
2020-07-08 9:27 ` Ali Alnubani
2020-07-07 7:12 ` [dpdk-stable] [PATCH v2 3/3] [18.11] net/mlx4: " Viacheslav Ovsiienko
2020-07-08 9:28 ` Ali Alnubani
2020-07-08 9:33 ` Kevin Traynor [this message]
2020-07-08 9:26 ` [dpdk-stable] [PATCH v2 1/3] [18.11] net/mlx5: fix recursive inclusion of header file Ali Alnubani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ea70c2-7807-88a8-b9b2-0699c49147b1@redhat.com \
--to=ktraynor@redhat.com \
--cc=alialnu@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
patches for DPDK stable branches
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
stable@dpdk.org
public-inbox-index stable
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.stable
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git