patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: stable@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	dev@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] eal: fix parsing zero socket memory and limits
Date: Wed, 23 Jan 2019 23:03:07 +0100	[thread overview]
Message-ID: <4900677.582JXVQWH1@xps> (raw)
In-Reply-To: <1a3eea71-1b1a-7589-48fa-71a23ee1e0a2@intel.com>

23/01/2019 11:15, Burakov, Anatoly:
> On 22-Jan-19 4:27 PM, Ilya Maximets wrote:
> > Modern memory mode allowes to not reserve any memory by the
> > '--socket-mem' option. i.e. it could be possible to specify
> > zero preallocated memory like '--socket-mem 0'.
> > Also, it should be possible to configure unlimited memory
> > allocations by '--socket-limit 0'.
> > 
> > Both cases are impossible now and blocks starting the DPDK
> > application:
> > 
> >      ./dpdk-app --socket-limit 0 <...>
> >      EAL: invalid parameters for --socket-limit
> >      EAL: Invalid 'command line' arguments.
> >      Unable to initialize DPDK: Invalid argument
> > 
> > Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> > ---
> 
> That's kind of an odd parameter to pass, as it is assumed that if you 
> don't need any limitations or preallocated memory, you don't specify 
> these flags in the first place, but OK :)
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks

  reply	other threads:[~2019-01-23 22:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190122162720eucas1p1a9b93996c3a9384ba141313d3de9e37a@eucas1p1.samsung.com>
2019-01-22 16:27 ` Ilya Maximets
2019-01-23 10:15   ` Burakov, Anatoly
2019-01-23 22:03     ` Thomas Monjalon [this message]
2019-01-24  1:12       ` [dpdk-stable] [dpdk-dev] " Wiles, Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4900677.582JXVQWH1@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@samsung.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).