From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D041D1B00F; Thu, 11 Jan 2018 02:21:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 17:21:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,342,1511856000"; d="scan'208";a="8722894" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga007.fm.intel.com with ESMTP; 10 Jan 2018 17:21:53 -0800 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.86]) by PGSMSX107.gar.corp.intel.com ([169.254.7.200]) with mapi id 14.03.0319.002; Thu, 11 Jan 2018 09:21:51 +0800 From: "Dai, Wei" To: "Ananyev, Konstantin" , "Yang, Qiming" , "Peng, Yuan" , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3 0/2] app/testpmd: fix invalid rxq and txq nubmer setting Thread-Index: AQHTifEElnKBf1TCFkCt5O5TQGXRsqNsWSyAgAGHyVA= Date: Thu, 11 Jan 2018 01:21:50 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF21292@PGSMSX112.gar.corp.intel.com> References: <1515557660-36763-1-git-send-email-wei.dai@intel.com> <1515573656-41847-1-git-send-email-wei.dai@intel.com> <2601191342CEEE43887BDE71AB97725880E3B510@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725880E3B510@irsmsx105.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDE4MjIxYTAtODNkZS00MWQ5LWJmMmQtOTUwMTFkNGUzNjM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlQxbE9ybW9rbzh0MlV3ZkQyYlBkanN2STdkc2FyeHFBcTBkWndqNFFrckU9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v3 0/2] app/testpmd: fix invalid rxq and txq nubmer setting X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 01:21:56 -0000 > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, January 10, 2018 5:59 PM > To: Dai, Wei ; Yang, Qiming ; > Peng, Yuan ; Lu, Wenzhuo ; > Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v3 0/2] app/testpmd: fix invalid rxq and txq nubmer > setting >=20 >=20 >=20 > > -----Original Message----- > > From: Dai, Wei > > Sent: Wednesday, January 10, 2018 8:41 AM > > To: Ananyev, Konstantin ; Yang, Qiming > > ; Peng, Yuan ; Lu, > Wenzhuo > > ; Wu, Jingjing > > Cc: dev@dpdk.org; stable@dpdk.org; Dai, Wei > > Subject: [PATCH v3 0/2] app/testpmd: fix invalid rxq and txq nubmer > > setting > > > > If an invlaid number of RX or TX queues is configured from testpmd > > command like "port config all rxq number" or "port config all txq numbe= r". > > The global variable rxq or txq is updated by the invalid input. > > This can cause testpmd crash. For example, if the maximum number of RX > > or TX queues is 4, testpmd will crash after running commands "port > > config all rxq 5", "port config all txq 5" and "start" in sequence. > > > > These 2 patches reserve the last correct rxq and txq, if an invalid > > input is detected, it is restored to the backup value to avoid crash. > > > > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Dai > > > > --- >=20 > The code looks good to me, just seems some misspellings in the comments > (mimumal). > Acked-by: Konstantin Ananyev Thanks, Konstantin. I'll correct these misspellings in my v4 patch set. >=20 > > v3: follow the guide from Konstantin to use functions to check > > input rxq and txq instead of usage of new added global variables. > > > > v2: fix a bug in v1 > > > > > > Wei Dai (2): > > app/testpmd: fix invalid rxq number setting > > app/testpmd: fix invalid txq number setting > > > > app/test-pmd/cmdline.c | 4 ++ > > app/test-pmd/parameters.c | 13 ++++--- > > app/test-pmd/testpmd.c | 94 > +++++++++++++++++++++++++++++++++++++++++++++++ > > app/test-pmd/testpmd.h | 5 +++ > > 4 files changed, 110 insertions(+), 6 deletions(-) > > > > -- > > 2.7.5