From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6FCD11B3EE; Fri, 4 Jan 2019 03:40:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2019 18:40:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,437,1539673200"; d="scan'208";a="132816417" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 03 Jan 2019 18:40:41 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 3 Jan 2019 18:40:41 -0800 Received: from bgsmsx152.gar.corp.intel.com (10.224.48.50) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 3 Jan 2019 18:40:41 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.20]) by BGSMSX152.gar.corp.intel.com ([169.254.6.222]) with mapi id 14.03.0415.000; Fri, 4 Jan 2019 08:10:38 +0530 From: "Varghese, Vipin" To: Yongseok Koh , "Yigit, Ferruh" CC: Thomas Monjalon , dev , dpdk stable , Tom Barbette , "Ananyev, Konstantin" , "Richardson, Bruce" Thread-Topic: [PATCH v3] mk: fix scope of disabling AVX512F support Thread-Index: AQHUo7Y9VMm/TmcaL0GJ9Q4yHxZJA6WeZfbw Date: Fri, 4 Jan 2019 02:40:36 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2E05AA@BGSMSX101.gar.corp.intel.com> References: <20181219210028.60219-1-ferruh.yigit@intel.com> <20190103162313.85623-1-ferruh.yigit@intel.com> <3DB9B601-F207-43B6-9237-F4630781FE78@mellanox.com> In-Reply-To: <3DB9B601-F207-43B6-9237-F4630781FE78@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGJhNjExNGQtNjRkMC00ODU0LWI2YjQtMDQ0YmVhYjJjMTJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieTgzSGxZRGNiQ0hpRnNkR3FyMFU1NU9qdmVMNGRpWm1VRXFKaW0rMEptUlF2UWM0eU02SDJLQjNaSURUeHIzQyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v3] mk: fix scope of disabling AVX512F support X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 02:40:44 -0000 Hi Ferruh, Should not be there a documentation update in 'Known Issues and Limitations= in Legacy Releases' for the limitation. If it is already added can you ple= ase add the patchwork link for the same. Thanks Vipin Varghese > -----Original Message----- > From: dev On Behalf Of Yongseok Koh > Sent: Friday, January 4, 2019 4:17 AM > To: Yigit, Ferruh > Cc: Thomas Monjalon ; dev ; dpdk > stable ; Tom Barbette ; Ananyev, > Konstantin ; Richardson, Bruce > > Subject: Re: [dpdk-dev] [PATCH v3] mk: fix scope of disabling AVX512F sup= port >=20 >=20 > > On Jan 3, 2019, at 8:23 AM, Ferruh Yigit wrote= : > > > > AVX512 was disabled for GCC because of Bugzilla issue 97 [1], the GCC > > defect submitted for the issue [2] highlighted that this is a known > > binutils version 2.30 issue. > > > > Narrowed the scope of no-avx512 to the this specific binutils version. > > > > [1] > > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= g > > > s.dpdk.org%2Fshow_bug.cgi%3Fid%3D97&data=3D02%7C01%7Cyskoh%40 > mellano > > > x.com%7C9e8d0eb500ca4cb74c1508d67197c6b0%7Ca652971c7d2e4d9ba6a4 > d149256 > > > f461b%7C0%7C0%7C636821294022213177&sdata=3DRxj7HxBWfp4hMzfRki > GtnSYt8 > > N0TG9xnAL0ZYBpYYa0%3D&reserved=3D0 > > > > [2] > > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgc= c > > > .gnu.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D88096&data=3D02%7C01% > 7Cysk > > > oh%40mellanox.com%7C9e8d0eb500ca4cb74c1508d67197c6b0%7Ca652971c > 7d2e4d9 > > > ba6a4d149256f461b%7C0%7C0%7C636821294022213177&sdata=3DEqzsa > moYfFve5 > > JAsgyWw51JOBhhiKTOCrnfZoYTGN28%3D&reserved=3D0 > > > > Fixes: 8d07c82b239f ("mk: disable gcc AVX512F support") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit > > --- > Acked-by: Yongseok Koh >=20 > Thanks >=20 > > Cc: Tom Barbette > > Cc: Thomas Monjalon > > Cc: Yongseok Koh > > Cc: Konstantin Ananyev > > Cc: Bruce Richardson > > > > v2: > > * Added warning message (print only once for eal) > > * Moved decision details to compat file, kept execution in cpuflags > > > > v3: > > * replace 'ld' with '$(LD)' for cross build > > * added meson support > > --- > > config/meson.build | 8 ++++++++ > > mk/rte.cpuflags.mk | 4 ++-- > > mk/toolchain/gcc/rte.toolchain-compat.mk | 10 ++++++++++ > > 3 files changed, 20 insertions(+), 2 deletions(-) > > > > diff --git a/config/meson.build b/config/meson.build index > > db32499b3..40802fc88 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -43,6 +43,14 @@ toolchain =3D cc.get_id() > > dpdk_conf.set_quoted('RTE_TOOLCHAIN', toolchain) > > dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1) > > > > +# get binutils version for the workaround of Bug 97 ldver =3D > > +run_command('ld', '-v').stdout().strip() if ldver.contains('2.30') > > + if cc.has_argument('-mno-avx512f') > > + machine_args +=3D '-mno-avx512f' > > + endif > > +endif > > + > > add_project_link_arguments('-Wl,--no-as-needed', language: 'c') > > dpdk_extra_ldflags +=3D '-Wl,--no-as-needed' > > > > diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index > > c3291b17a..541211c61 100644 > > --- a/mk/rte.cpuflags.mk > > +++ b/mk/rte.cpuflags.mk > > @@ -69,8 +69,8 @@ ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),) ifeq > > ($(CONFIG_RTE_ENABLE_AVX512),y) CPUFLAGS +=3D AVX512F else -# disable > > AVX512F support of gcc as a workaround for Bug 97 -ifeq > > ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > +# disable AVX512F support for GCC & binutils 2.30 as a workaround for > > +Bug 97 ifeq ($(FORCE_DISABLE_AVX512),y) > > MACHINE_CFLAGS +=3D -mno-avx512f > > endif > > endif > > diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk > > b/mk/toolchain/gcc/rte.toolchain-compat.mk > > index 44904295c..33ea3f03a 100644 > > --- a/mk/toolchain/gcc/rte.toolchain-compat.mk > > +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk > > @@ -20,6 +20,16 @@ HOST_GCC_MINOR =3D $(shell echo __GNUC_MINOR__ > | > > $(HOSTCC) -E -x c - | tail -n 1) HOST_GCC_PATCHLEVEL =3D $(shell echo > > __GNUC_PATCHLEVEL__ | $(HOSTCC) -E -x c - | tail -n 1) > > HOST_GCC_VERSION =3D $(HOST_GCC_MAJOR)$(HOST_GCC_MINOR) > > > > +LD_VERSION =3D $(shell $(LD) -v) > > +# disable AVX512F support for GCC & binutils 2.30 as a workaround for > > +Bug 97 ifneq ($(filter 2.30%,$(LD_VERSION)),) > > +FORCE_DISABLE_AVX512 :=3D y > > +# print warning only once for librte_eal ifneq ($(filter > > +%librte_eal,$(lastword $(CURDIR))),) $(warning AVX512 support > > +disabled because of ld 2.30. See Bug 97) endif endif > > + > > # if GCC is older than 4.x > > ifeq ($(shell test $(GCC_VERSION) -lt 40 && echo 1), 1) > > MACHINE_CFLAGS =3D > > -- > > 2.17.2 > >