From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C277F425A7 for ; Fri, 15 Sep 2023 16:35:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA8EE40A72; Fri, 15 Sep 2023 16:35:22 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062.outbound.protection.outlook.com [40.107.94.62]) by mails.dpdk.org (Postfix) with ESMTP id 2026540041; Fri, 15 Sep 2023 16:35:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gpDREQz8aHbLs/54AULR30AIbDouLJ6xRsqcNvmOyx+5PVmRoAwqL0X1nWpeGOnOtBSS9M8HkO77qDqLL4GPsi7AJbbUP85+Z2yaursdkxJPFvWpK1gEKqeIa3byHpEybyGVrpYxUdFGFUDD93incbWp967a/XjVP6IUBr0MW59bOKHfYKEUaeKp8fbByAs/eBiCFFUTZf2ZeE5oywave8ZCQ8uW7bMCEPtX1C9BglPW2QHKGsaoZ37hyyHTituaGHP8sGpSs8c2kd2kMfT/94JMGxJE4CGo3y3Jh6a2RvslA2Lk117kovNmaQGh/tvSvuMJR5TVCN0VMzX1Almzsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ulx9BJyH4OYfM72X2jOkFlUTGnpbtn8DlDAOiOMzTF8=; b=UC5wZjgLxa5bNMCoGWwA07ICxsgw5PKzcpAKuYiBrW5KWp6rIvbzYmojphxS8HshAQ7J3ZQYKsXtYjwdtuNdsNR5qSiKcGtaF+PfQ3n+sORogWyaHS+4PL63zh6YNm/DGSm3Pw3KXqv1Lw+VFCEJIDD2qL2KexX7+PjORlOvHWBGTdiuYtzew5VTRUJkWaNOeXNS3BOdBI1MuCzKGdl5tGCetJ/SyKjX1ipsOmsYPmJYUMYSj8LpZTzQ9oGaTXrTkCuXYzHT7bshGAqK6BrlSUO7g3sn5cTBJofQFiXf0joECrDbwyyTvHqnTof3wCUfPGT3fEBVgwckCyOLIHV/tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ulx9BJyH4OYfM72X2jOkFlUTGnpbtn8DlDAOiOMzTF8=; b=mubVV+HUJPhVeA2kaE1OY/gGGWJYWfg6A3La9qPpFp0vomk5+oMIoyuvzFV2ZgKjo9XCnBdBXut3xaJYRD6b+wBJPPCl5s6P7rxEvbg6zKoMQ68bVJHZTudqOB3HVd6p/Idu4//fbHgJlYG+cBDjS3KL8s9sKnmGGXqO58Qu16s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5103.namprd12.prod.outlook.com (2603:10b6:5:392::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.21; Fri, 15 Sep 2023 14:35:17 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 14:35:17 +0000 Message-ID: <4bab144e-f37d-4266-a2ff-afa91f0dad6f@amd.com> Date: Fri, 15 Sep 2023 15:35:09 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] net/axgbe: use CPUID to identify cpu Content-Language: en-US To: David Marchand , Selwin Sebastian Cc: stable@dpdk.org, dev@dpdk.org, Bruce Richardson , Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= References: <20230831123131.4787-1-selwin.sebastian@amd.com> <1e1f06fd-c004-4612-90ba-c6322df27941@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0393.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::21) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5103:EE_ X-MS-Office365-Filtering-Correlation-Id: ef519953-1c5e-4afd-92ad-08dbb5f8fada X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ODFFGxHWLiFwG5UvEfV1mTWuC1W97LCZQ4Gq2gXl0DzHnb8YXVEsOzQlL5SummIg3t18oHWyu2G90LTL2iq1Y28V44kogqpKPw1yPFrpjHPe0ItFncbLHFXakk4q+kHyA/5yiqXat9ju45A+eiUhVIB19MfiQtMFKrQEKKfTgufAfOi/Zr5+1eP1BydAxcVoCuFwCx02AG1lEv8OuLe5T1dx+dyAMBit5G0dL41BxK3xqXOOM5RRRVMZQynGC+RHQlIA+HYQNNFsbQyPIA1THzPgAUpdtFxle+20h2ptO7DHpHG005PwGOtoYeOfSiQaQLbh9Is52wp3t2rPdJRAyni94jZZpYbweV0V66cIWR/s2flQur1yEgSbntxHBJwMJj2ewyQrWawJNugsKoKJIN5Ctap5EJdjQlQHzmtD7dMvUAKEGsA4Jgus/nq71q7WuMF2KdLJ+XPI3ljndb5KmjdisVeMM4Tw5MSxSm26MdUTkvrqvachdit4efc/gni0qgEASELY+r0s3ZdGuD3YRDZZ6nGm/TkkxVDO3v3m6HLlywiaMmYoPUV3DwE8zUntUaIKU1haxg+Gf+WyBjWIThdf/NKQSwRZkDsjJ2+A1o7MGRUMXWGhdFi3nuQoK6DTro4SN+EVkBd5k4LncoMK5A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(346002)(396003)(39860400002)(186009)(451199024)(1800799009)(2616005)(54906003)(110136005)(6666004)(66556008)(66476007)(66946007)(53546011)(44832011)(6506007)(6486002)(6512007)(6636002)(316002)(478600001)(31686004)(41300700001)(4326008)(8936002)(8676002)(5660300002)(26005)(38100700002)(36756003)(2906002)(86362001)(31696002)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWtiRk5XWWEvS21HL05VZWd4dzdZLzd3bnJ4QnY2Q29qVEZRV1pjeS9EV3Y3?= =?utf-8?B?Z3BucExHS1l2Q1ZpVDNPZ1QxbGhMaXd4Wlh3M2RESDJQdVNWK3o0ZmdzdDVh?= =?utf-8?B?Zk5TbFBDV3V5QmtEYzVRc3F1b0thbEZmcUp5ZUJFS3RUYkNiQUx1c1l5MFdi?= =?utf-8?B?S3dINTNjZkVtN1VLWWIyQWt1YUdkbjlGSG1ralFLaW92K2sxY2kzY0xKZlBs?= =?utf-8?B?RktjQllYZnkwNlJiMDltNnJnVFVBZUpsMzVjNWpsaTRyK1JXN28wOVkxSzlm?= =?utf-8?B?WE0yVit2aHhzamc3UFR5bS9nSG1XcVlPVU05c0RMRUpDOFlLTldkMXBFRmJ2?= =?utf-8?B?UkgxbU91VjljaGxlVWxidzFSSmxZcFo3eUNDUnhDMXc2TFRpbWNvMEJyZEI4?= =?utf-8?B?eUFHZEVXT1FYM3JmMzJ1T3hHSndjTTVzWTJTemdFeDhMZFlDRGVyT29rRllr?= =?utf-8?B?MkxJZmJMUlpuWHo2b3kyanp6bFB1S0dVUTBzL3R6SmpwbEgzQXJTMUV6eU4v?= =?utf-8?B?R3BOTVpXeUFtK1N3QnoxU3hUMThLTFFuUXgrY2pwazczNVhDRHdrWWh3QlRG?= =?utf-8?B?RG81aDRqOTU0cUVsM2xEQ09lRDQzUDgxc0pOaEN3cEl1UDlRSVA2OVJHSURp?= =?utf-8?B?TjFTdXowWlU1RzNSVFlWWWYrcUJGMllmSnRHMEpmUGJYRnozRUJ6ejlUUVNC?= =?utf-8?B?QVVsTDBQclBiSHlldHd3bEorN2NqM2xGZ1ZnVXBlTk8yUjhwS0I4R21YZ0Mx?= =?utf-8?B?ZTNwV3R5WTg0a1FORm5LRFRTQ3pINEVKZzF5NUJHMUM1ZkhJejkyN0ptalZ4?= =?utf-8?B?eWRNQytvd2JVL1ZqbktXc0lzTldoRnlhNnJlY1hsdzlrQ0NzYWg5aThweDVV?= =?utf-8?B?NDFVNi82Qm1ISVRvTlRJKzZ4Y3FjbkVEUWE4MEhtMiszNG9CZmROYjBMSkxl?= =?utf-8?B?N2hkSFdsRlN5V3drTjdZMzJPR0h3czNyUzVDbnB5bVptYkNWZkZFamh2b0xT?= =?utf-8?B?ckFUS2E1TTdDTm1JU0NlemdId2FzQ3U5ajVqSXYvRXBVQ1NJdG04WE5oMU5t?= =?utf-8?B?SDJWN1NOYmI5RU9vTG5wRzNVLzltME1nZTM0MHJsSWljL0pDWE5OZEF2VDhI?= =?utf-8?B?d0pPY1QwZi9ZcUtDRmlZcDNxTjNZZ29VRFlxempxWmRBSWZST2FSNjNtd3Bo?= =?utf-8?B?MzdvMEZkS0hMZ0JBL0hKeEJNU0I3alRTQmVpWmtOakJQdVZ5OEJGNGR3QUFk?= =?utf-8?B?VzI5RTR3YXJTcExITG1XVG9Ld2VrTXJjR0NIek9haVJubHRJVWRaQXZpK2hi?= =?utf-8?B?K2tJWlRMVkc1SU84Wjdoc3k4Z29SREp4MXhvWkkvQW5CNEVsVHh6NUk0bUlB?= =?utf-8?B?aUFSeTBZSm56d1duRGk3ZTNoNzJrTG45MXh4dDh0bmZlMkp6aGRNV2RRSHR2?= =?utf-8?B?NlFJVjJRUkFTQWd1Nllzb2RLNkQrMUxwNVVIajN5TjdLWEhUTXJTM3FDa3M2?= =?utf-8?B?VmNWeERRWnZEdkV0dmxDbVpRUWQ2bEtHSzI5MXg2QTlpeU5VSGdNbWhwRDd1?= =?utf-8?B?NVBCU1h1T09qVFVEVmRwd2NRcXN1M3VhVEN0QWFHdDQzZHczTWdEU2ZNZWVs?= =?utf-8?B?MnFOTGRqSmtBclVsUVFPTDZpdG9OQjZuY2hLbHcvbVBob29TUUY0L0orcFpP?= =?utf-8?B?azFCb0dCbUx1ak1xNHBqTC9ESWxjV0NBRlQ2ZktqTVFENlFYVUprYUJldk5I?= =?utf-8?B?eUZmZytJei9TZkNaZHNQc1oyMEtaS2Y0UkFYVE1YZDAyWWpidlpzNDBYNUJ3?= =?utf-8?B?VjBMMmpVRUFNNDlBdnNURkJDWnpRNlJudFR1TXptSk1DNXl2TFhsaDBmRzZF?= =?utf-8?B?WDJNa2lvbSs1N2UvdFo4RjlHRlJYUitQQndhaEtBWFN5V04vQzREdm9lTmgr?= =?utf-8?B?RDkzMnNqaCsxNFk0a1NmeE9uUU1WN0ZuU0Fma01PbnQxQjRCMnd5SHI0V0Fp?= =?utf-8?B?dWtoOEswYjNZMkNHMk1ydVQ1RW03QnNINWxzd243QjE2bDJkMUl4S2V0Y1Ir?= =?utf-8?B?WVhOakduRnQ0S1lEcFBJUjVNYWNuamg5YzIvRWN4SytLZnBRdVVtTWZNMDNW?= =?utf-8?Q?5enF79avhFfzqIbfsZ4Qqcch1?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef519953-1c5e-4afd-92ad-08dbb5f8fada X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 14:35:17.0318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6IQOwbgfYb6eddyFMl4WwNhC9mhUAS1kT0+Nw+eIrsaJWFm3t7k49N/EDux62oW0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5103 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 9/15/2023 2:02 PM, David Marchand wrote: > On Fri, Sep 15, 2023 at 12:54 PM Ferruh Yigit wrote: >> >> On 8/31/2023 1:31 PM, Selwin Sebastian wrote: >>> Using root complex to identify cpu will not work for vm passthrough. >>> CPUID is used to get family and modelid to identify cpu >>> >>> Fixes: b0db927b5eba ("net/axgbe: use PCI root complex device to distinguish device") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Selwin Sebastian >>> --- >>> drivers/net/axgbe/axgbe_ethdev.c | 102 ++++++++++++++++++------------- >>> 1 file changed, 59 insertions(+), 43 deletions(-) >>> >>> diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c >>> index 48714eebe6..59f5d713d0 100644 >>> --- a/drivers/net/axgbe/axgbe_ethdev.c >>> +++ b/drivers/net/axgbe/axgbe_ethdev.c >>> @@ -12,6 +12,8 @@ >>> >>> #include "eal_filesystem.h" >>> >>> +#include >>> + >>> >> >> This patch cause build errors for some non x86 architecture, because of >> 'cpuid.h'. >> >> There is already a 'rte_cpuid.h' file that includes 'cpuid.h' and it is >> x86 only file. >> >> @Selwin, does it makes sense to implement the feature you are trying to >> get in eal/x86 level and use that API in the driver? > > This driver was expected to compile on all arches. > The meson.build seems to show an intention of compiling/working on non > x86 arch... > > On the other hand (and if I understand correctly the runtime check), > it was never expected to work with anything but a AMD PCI root > complex. > > >> >> >> For those eal/x86 APIs, they will be missing in other architectures, >> >> @David which one is better, to implement APIs for other architectures >> but those just return error, or restrict driver build to x86? > > We gain compilation coverage, but if the vendor itself refuses runtime > on anything but its platform... I don't think we should bother with > this. > Did I miss something? > It is embedded device, so it will only run on x86. Current meson config doesn't restrict it to x86 (existing x86 check is only for vectorization code), but we can restrict if we want to. One option is to restrict driver to x86 arch, and have the local '__cpuid()', other option is move __cpuid() support to eal x86 specific area, so that other components also can benefit from it as well as the driver, similar to the getting CPU flags code, cpuid() is to get some information from CPU, so it is a generic thing, not specific to driver. I think second option is better, but that requires managing this for other archs, my question was related to it.