From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F618A0093 for ; Thu, 10 Mar 2022 14:12:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 021F14113E; Thu, 10 Mar 2022 14:12:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1B2E34113E for ; Thu, 10 Mar 2022 14:12:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646917956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+UiCMl3qPr+I6DcsdTeeUl4IhwgzoMEUuwqSyUKAoE8=; b=czNJVCRnd+rfwndxIg0uJaPiLj00PfnWYo1m1TZFjsh23vLwkqOF1c86cEkbnuHHpEg2DL xOy7f9XMcO2N6RWFxcGlKuPhj8tP+KArO3HwsddmdMeJSLAg8e+L/nuh9bK+NlF+higeYp duIJgSYKNpGZTkU2SGb4dGekNwcDn0s= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-47-H0B8NCyBOd-SKcEdZveSNQ-1; Thu, 10 Mar 2022 08:12:33 -0500 X-MC-Unique: H0B8NCyBOd-SKcEdZveSNQ-1 Received: by mail-wm1-f69.google.com with SMTP id c126-20020a1c3584000000b00380dee8a62cso2059209wma.8 for ; Thu, 10 Mar 2022 05:12:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:from:to:cc:references:subject:in-reply-to :content-transfer-encoding; bh=+UiCMl3qPr+I6DcsdTeeUl4IhwgzoMEUuwqSyUKAoE8=; b=2B7hfV5qAqi2pQDDaKCFfAzmc2uqPbOREG2q+GMSAPz6tmd0AdUn27bbWVRo2dh2Ib 3gDzIOQaWOlhnnp6KU7t/O8ontxKbrQK8ZHzIfQtLK9GW3tI1vpk/ahOafKs7oy56DCf IEav1v7MQhgHW5dPfXxko3fqTvBUh6gVrrgVkAI371JbC+enYaCBfOxukUUOvzy5V/XA ns1kacd/xgcOjyZ8u5y3xU8AyF0IBh4DXuNKv0i7jzL0moaLMyQqkOksjze14UB3r1+v VKnXJuVnq7hT1bsrgDr67V73Mc/8EA1IkS4UrOApOZrl2O/bdDnKdp6MKFK9G4RRJT01 xERg== X-Gm-Message-State: AOAM533na0otZJY9opFwNZ40y9q/fWaP3Xf06VuBy65PPAQpOZr7GPrQ qYcGEnqF7hvi5irbLCiFSaGM20qEdZRdyr/LvPZIVkLo+lzbCBw4LY3F8E+eltuXo1lotyRJrEo qyfEuzCU= X-Received: by 2002:a5d:47cf:0:b0:203:7a06:38a8 with SMTP id o15-20020a5d47cf000000b002037a0638a8mr3583693wrc.536.1646917951877; Thu, 10 Mar 2022 05:12:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZ2+E365UpVxvNa6DojppbMmryL2okRwoEC7T6wpsdoTbaRcQnSK1kci+6e/5JF/tR3Fh5Og== X-Received: by 2002:a5d:47cf:0:b0:203:7a06:38a8 with SMTP id o15-20020a5d47cf000000b002037a0638a8mr3583681wrc.536.1646917951595; Thu, 10 Mar 2022 05:12:31 -0800 (PST) Received: from [192.168.0.36] ([78.18.17.201]) by smtp.gmail.com with ESMTPSA id v13-20020adfe28d000000b0020375f27a5asm4498996wri.4.2022.03.10.05.12.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Mar 2022 05:12:31 -0800 (PST) Message-ID: <4c42f2b2-a2e1-752b-4a14-ae6a84484276@redhat.com> Date: Thu, 10 Mar 2022 13:12:30 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Kevin Traynor To: Rongwei Liu Cc: Viacheslav Ovsiienko , dpdk stable References: <20220310121127.1324802-1-ktraynor@redhat.com> <20220310121127.1324802-8-ktraynor@redhat.com> Subject: Re: patch 'net/mlx5: fix shared RSS destroy' has been queued to stable release 21.11.1 In-Reply-To: <20220310121127.1324802-8-ktraynor@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 10/03/2022 12:11, Kevin Traynor wrote: > Hi, > > FYI, your patch has been queued to stable release 21.11.1 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 03/14/22. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > Hi. Please check this rebase carefully, as the assignment may not take place now due to possible return before it. Kevin. > Queued patches are on a temporary branch at: > https://github.com/kevintraynor/dpdk-stable > > This queued commit can be viewed at: > https://github.com/kevintraynor/dpdk-stable/commit/eebfb74c5155c08ff2a0e1b9a01f76f62e3b7382 > > Thanks. > > Kevin > > --- > From eebfb74c5155c08ff2a0e1b9a01f76f62e3b7382 Mon Sep 17 00:00:00 2001 > From: Rongwei Liu > Date: Wed, 2 Mar 2022 13:19:38 +0200 > Subject: [PATCH] net/mlx5: fix shared RSS destroy > > [ upstream commit e1786fd53d7e5631c9ffb9b2fba0fd402bc8cf74 ] > > When both shared and non-shared RSS actions are present in single > flow rule shared RSS index is unset by mistake. > > For example: > 1. flow indirect_action 0 create action_id 3 ingress action RSS ... > 2. set sample_actions 0 mark id 43690 / queue index 0 / end > 3. flow create 0 ingress group 107 pattern eth / sample ratio 2 > index 0 / indirect 3 / end > > PMD translates the indirect action to a shared RSS description at first. > In the split prefix flow, RSS->shared_RSS is unset when translating > sample queue action, the subfix flow will treat the RSS as non-shared. > > Fixes: 8e61555657b2 ("net/mlx5: fix shared RSS and mark actions combination") > > Signed-off-by: Rongwei Liu > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c > index 7a5f17a8b7..a35fb3de4e 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -11103,4 +11103,5 @@ flow_dv_hrxq_prepare(struct rte_eth_dev *dev, > struct mlx5_priv *priv = dev->data->dev_private; > struct mlx5_flow_handle *dh = dev_flow->handle; > + uint32_t shared_rss = rss_desc->shared_rss; > struct mlx5_hrxq *hrxq; > > @@ -11117,4 +11118,5 @@ flow_dv_hrxq_prepare(struct rte_eth_dev *dev, > hrxq = mlx5_ipool_get(priv->sh->ipool[MLX5_IPOOL_HRXQ], > *hrxq_idx); > + rss_desc->shared_rss = shared_rss; > return hrxq; > } > @@ -18325,3 +18327,2 @@ const struct mlx5_flow_driver_ops mlx5_flow_dv_drv_ops = { > > #endif /* HAVE_IBV_FLOW_DV_SUPPORT */ > -