From: Thomas Monjalon <thomas@monjalon.net>
To: Lance Richardson <lance.richardson@broadcom.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] eal: fix memory mapping for 32-bit targets
Date: Tue, 11 May 2021 22:45:41 +0200 [thread overview]
Message-ID: <5067179.EJ8Y43xz3P@thomas> (raw)
In-Reply-To: <20210511190829.5aa8e256@sovereign>
11/05/2021 18:08, Dmitry Kozlyuk:
> 2021-05-11 11:56 (UTC-0400), Lance Richardson:
> > > v4: Identical to v1, with <sys/types.h> now included in rte_eal_paging.h
> > > to (hopefully) make off_t available for Windows builds.
> >
> > With this version, using off_t is no longer a problem, however based on the
> > new compilation error it appears that for Windows, off_t is a 32-bit type
> > while size_t is a 64-bit type:
> >
> > ../lib/eal/windows/eal_memory.c:519:37: error: shift count >= width of
> > type [-Werror,-Wshift-count-overflow]
> > DWORD offset_high = (DWORD)(offset >> 32);
> > ^ ~~
> >
> > So the options seem to be to either use uint64_t for the offset parameter
> > as in patch v3, or else introduce something like:
> > typedef uint64_t rte_off_t;
> >
> > Thoughts/opinions?
>
> I'm for uint64_t: it's explicit and will hardly ever change.
OK, v3 applied.
prev parent reply other threads:[~2021-05-11 20:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 18:10 [dpdk-stable] [PATCH] " Lance Richardson
2021-05-07 18:50 ` Lance Richardson
2021-05-07 18:55 ` Lance Richardson
2021-05-07 19:06 ` [dpdk-stable] [PATCH v2] " Lance Richardson
2021-05-07 20:51 ` Dmitry Kozlyuk
2021-05-07 21:35 ` Lance Richardson
2021-05-08 14:12 ` [dpdk-stable] [PATCH] " Lance Richardson
2021-05-08 14:27 ` [dpdk-stable] [PATCH v3] " Lance Richardson
2021-05-10 12:42 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-05-10 15:31 ` Burakov, Anatoly
2021-05-10 15:55 ` Thomas Monjalon
2021-05-10 16:04 ` Lance Richardson
2021-05-11 7:55 ` Thomas Monjalon
2021-05-11 20:45 ` Thomas Monjalon
2021-05-11 8:17 ` Thomas Monjalon
2021-05-11 13:33 ` Lance Richardson
2021-05-11 14:45 ` [dpdk-stable] [PATCH v4] " Lance Richardson
2021-05-11 15:56 ` Lance Richardson
2021-05-11 16:08 ` Dmitry Kozlyuk
2021-05-11 20:45 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5067179.EJ8Y43xz3P@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=lance.richardson@broadcom.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).