From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0041.outbound.protection.outlook.com [104.47.2.41]) by dpdk.org (Postfix) with ESMTP id E107F5F2C for ; Fri, 5 Oct 2018 01:40:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KNEGWStzwZ3kBe6DjPoW/9QzvkEU37W1IBfxFr04sx8=; b=jyP6Oc9vvo+SvqR3yeGzvrBywMv/RVc0Bk7MO0p8r68bWYPN1yyo03A2VeTfidKtBJVnMJTM3XAicbnuyHv9FNyN6UHHHYFIdl9f46z0EoJW2Z49bq7n0AjF2Sq8WIIgTnvVocfH2nDLtBdLZSEqYQmkga/6YVbkN/Xb6EkKJ6M= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4009.eurprd05.prod.outlook.com (52.134.72.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.23; Thu, 4 Oct 2018 23:40:02 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045%2]) with mapi id 15.20.1185.029; Thu, 4 Oct 2018 23:40:02 +0000 From: Yongseok Koh To: "John Daley (johndale)" CC: "johnda888@gmail.com" , dpdk stable , "Hyong Youb Kim (hyonkim)" Thread-Topic: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak Thread-Index: AQHUVs28u8F07/UK4USepZTxZWA0wqUPpseAgAAH5QCAABrZAA== Date: Thu, 4 Oct 2018 23:40:01 +0000 Message-ID: <507263C0-7F4C-45A7-95B5-2A17C4D4D0A1@mellanox.com> References: <20180928015105.14831-1-johndale@cisco.com> <87F2CBFF-E31E-4C6A-B64A-D94030B1B258@mellanox.com> <52280fb7c947471da4432fd7d08fb0a9@XCH-RCD-007.cisco.com> In-Reply-To: <52280fb7c947471da4432fd7d08fb0a9@XCH-RCD-007.cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4009; 6:4kfmC43l8xbyaIAp2GKaanYl37pFgmDwTY0nNqePo4aEeWMuf+E4TZvULLMer4f9FzZiRFUQO/Ko8J44hklO2mBP1tux0wUIncmAPtKxgqg6m0MkH9zy5CqIO7Tz+ZGuyTmRZl1VTlQBrSlWyUtbZkGnOeRwji63BCvGxp07TMjBlkRgd0dg4k+27xakNZbxPAj6j/9IMUgJUaaAuSKwaC+D5MtkDX9+Uynvl1ZfwBFPBg1uXZQ0BF7tSNFPhckoxTA69O8W0KQdxVnntxIw7bCdtotEF5fc22yk7HugeOM2yCY3ZBIw1Yo6A4+XgDBl2WXNNdRfBdj2vOi3jhpn6GGFlL09fREvj26OxkMMOVbajdBz8mznt4vfCu7mLL5EkKMI/24F1sDzI7RwWUXSx+Cpou+Ib+uRvWQ3FO7qLaOH5jsUA2dkg6A19uRIwYApVMtug1bwi6Rjl8M6JSWd/g==; 5:lo8/kp19FWKn4daVY1HvL1wsDhaG+YRKr1IK6a5UBSJk7xwYjhURg/cUcHqsRAu3CwR9NSfU99s4OnPduvGChoTRIum10Me5MPht77f5BZski4GpI8KW+FFo2iJKld7Aj1VVI3tv++reldGhBJOjNxJ8Sr3nVgigSYC8hQ8EakQ=; 7:1xQVjCXBHLlhesBM9mQUHEwEHVnY8t94YFHdUoul+yYA3HhXpeyofbdKoR3KSMAxnuSym6H+pCbsiy74i9mOvMaV1wAr8Mv/+Jcmo6fYJsWspUF6nzoydJBGRu3JJTk5b6DWV9vNMdUyLas4uYNkxX+GsZmNHpT55+64tTK9NG99QhcQ2/SdPBzoW/NTQe/k/qbQFq+PtrNnhx5xWosMFxgh00JVCaRsRefubpi9t/BbVwMa/749PxrY5rlnZoAa x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: f389d11a-71f5-47d5-4f0d-08d62a52b452 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4009; x-ms-traffictypediagnostic: DB3PR0502MB4009: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(45079756050767)(189930954265078)(85827821059158)(95692535739014); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231355)(944501410)(52105095)(93006095)(93001095)(3002001)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201708071742011)(7699051); SRVR:DB3PR0502MB4009; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4009; x-forefront-prvs: 0815F8251E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(136003)(376002)(366004)(346002)(396003)(39860400002)(199004)(189003)(13464003)(5660300001)(446003)(186003)(7736002)(6512007)(966005)(256004)(6306002)(14454004)(97736004)(26005)(11346002)(2906002)(68736007)(6506007)(316002)(305945005)(86362001)(53546011)(71200400001)(3846002)(71190400001)(83716004)(53936002)(486006)(14444005)(478600001)(102836004)(476003)(2616005)(99286004)(76176011)(36756003)(6246003)(39060400002)(106356001)(6486002)(81166006)(45080400002)(54906003)(6116002)(6916009)(8676002)(81156014)(25786009)(8936002)(4326008)(5250100002)(66066001)(2900100001)(33656002)(82746002)(105586002)(229853002)(6436002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4009; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: nzxTzYW7wg2GOIDf6TlmxVwd7lP0U267ZNKKlAxZ+3l0aIeUyRXnQo8mFTd1C1zyZn/Bc+EVY27gcxkasfmivDz3Y9NQQxV3L0nmgEWQSZFzxLXCUkgNselHocKbDrnkdfwAjtHwiRtT5ojy2XeNBgiYqFsMRBMEDJMCX5fG47ng84oTU6tpoyNjqIhIX1hDTrXoQZ1Hs4JaGw1m+/TUbWw/BYlX1fnpt86uaGjoIai77bCz0rko04LDHKjRwIMyVIj1TdHTsZafssp+oRda+v49nPx5BSdIO0Xr+AQIHfvZn0ZwN8rT0mhW5pQyPu+vks705KfGWuO97QLSVDe6iq7dE9hlm+ZUzuFEnDBt1So= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <75A268572488D44E951B1EC84EF9397D@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f389d11a-71f5-47d5-4f0d-08d62a52b452 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2018 23:40:01.9631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4009 Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 23:40:04 -0000 > On Oct 4, 2018, at 3:03 PM, John Daley (johndale) wr= ote: >=20 > Hi Yongseok, >=20 > It should go into 17.11 and hopefully 18.02, 18.05, 18.08 eventually. >=20 > Not sure what you mean when you say it was only for stable releases. It = was submitted to dev@ with the Cc: stable@ in the commit. The patch is here= : https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpatc= hes.dpdk.org%2Fpatch%2F45545%2F&data=3D02%7C01%7Cyskoh%40mellanox.com%7= Cb5541c8c6a2f4da3a1b908d62a454896%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C= 0%7C636742874397325810&sdata=3DwBWZ13CGeDZB3dnm%2Bv4fXivc%2BRQGRCpotawC= Q3oE6PU%3D&reserved=3D0 >=20 > When cc'ing stable in dev@ submissions, should we generally follow up wit= h an email to stable@ to indicate which stable branches to target? If so, s= hould we update the instructions in the contributors guide (section 6.4), o= r did I miss where that process is documented? If you send out a patch to dev@dpdk.org with the tag (Cc: stable@dpdk.org),= the patch will automatically be queued for stable branches. But the reason why = I asked the question was this specific one has been sent to stable@dpdk.org without dev@dpdk.org. It looks you've sent the same patch twice? Summary. 1) If you want to fix a bug in the current upstream (dpdk/master), send the= fix to dev@dpdk.org with the stable cc tag, then it will be automatically queue= d to be backported to a stable branch if the bug is in the stable branch. If you don't think backporting is necessary, you don't need to add the stable cc t= ag. Then, nothing will happen. 2) If you want to fix a bug and the bug exists only in a stable branch, not= in the master branch, then you should send it only to stable@dpdk.org with a prefix. Please refer to "5.11.1. Backporting patches for Stable Releases" i= n the guide. E.g., git send-email --subject-prefix=3D'PATCH 16.11' ... If the bug exists in multiple stable branches, you should send it multiple = times. Thanks, Yongseok > Thanks, > John >=20 >> -----Original Message----- >> From: Yongseok Koh >> Sent: Thursday, October 04, 2018 2:36 PM >> To: John Daley (johndale) >> Cc: johnda888@gmail.com; dpdk stable ; Hyong Youb Kim >> (hyonkim) >> Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory lea= k >>=20 >>=20 >>> On Sep 27, 2018, at 6:51 PM, John Daley wrote: >>>=20 >>> rte_flow structures were not being freed when destroyed or flushed. >>>=20 >>> Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced >>> filters enabled") >>> Cc: stable@dpdk.org >>>=20 >>> Signed-off-by: Hyong Youb Kim >>> Reviewed-by: John Daley >>> --- >>=20 >> Hi, >>=20 >> Is this patch only for stable releases? If so, which one? Or was dev@ ab= sent >> by mistake? >>=20 >>=20 >> Thanks, >> Yongseok >>=20 >>> drivers/net/enic/enic_flow.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>>=20 >>> diff --git a/drivers/net/enic/enic_flow.c >>> b/drivers/net/enic/enic_flow.c index 0cf04aefd..9b612f1d5 100644 >>> --- a/drivers/net/enic/enic_flow.c >>> +++ b/drivers/net/enic/enic_flow.c >>> @@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev, >> struct rte_flow *flow, >>> enic_flow_del_filter(enic, flow->enic_filter_id, error); >>> LIST_REMOVE(flow, next); >>> rte_spinlock_unlock(&enic->flows_lock); >>> + rte_free(flow); >>> return 0; >>> } >>>=20 >>> @@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, struct >> rte_flow_error *error) >>> flow =3D LIST_FIRST(&enic->flows); >>> enic_flow_del_filter(enic, flow->enic_filter_id, error); >>> LIST_REMOVE(flow, next); >>> + rte_free(flow); >>> } >>> rte_spinlock_unlock(&enic->flows_lock); >>> return 0; >>> -- >>> 2.16.2 >>>=20 >=20