Re: [dpdk-stable] [PATCH v2 2/2] net/enetc: fix big endian build

Re: [dpdk-stable] [PATCH v2 2/2] net/enetc: fix big endian build

[Gagandeep Singh]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, April 10, 2019 1:37 AM
> To: Gagandeep Singh <G.Singh@nxp.com>; Pankaj Chauhan
> <pankaj.chauhan@nxp.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [EXT] [PATCH v2 2/2] net/enetc: fix big endian build
> 
> WARNING: This email was created outside of NXP. DO NOT CLICK links or
> attachments unless you recognize the sender and know the content is safe.
> 
> 
> 
> Compilation was failing when using a big endian toolchain:
> 
> drivers/net/enetc/enetc_rxtx.c:92:21: error:
>         passing argument 1 of 'rte_constant_bswap64'
>         makes integer from pointer without a cast
> 
> Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx")
> Cc: g.singh@nxp.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/enetc/enetc_rxtx.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c
> index 631e2430d..ef0d7919f 100644
> --- a/drivers/net/enetc/enetc_rxtx.c
> +++ b/drivers/net/enetc/enetc_rxtx.c
> @@ -88,8 +88,9 @@ enetc_refill_rx_ring(struct enetc_bdr *rx_ring, const int
> buff_cnt)
>         rx_swbd = &rx_ring->q_swbd[i];
>         rxbd = ENETC_RXBD(*rx_ring, i);
>         for (j = 0; j < buff_cnt; j++) {
> -               rx_swbd->buffer_addr =
> -                       rte_cpu_to_le_64(rte_mbuf_raw_alloc(rx_ring->mb_pool));
> +               rx_swbd->buffer_addr = (void *)(uintptr_t)
> +                       rte_cpu_to_le_64((uint64_t)(uintptr_t)
> +                                       rte_mbuf_raw_alloc(rx_ring->mb_pool));
>                 rxbd->w.addr = (uint64_t)(uintptr_t)
>                                rx_swbd->buffer_addr->buf_addr +
>                                rx_swbd->buffer_addr->data_off;
> --
> 2.21.0

Hi Thomas,

I have sent a patch-set for ENETC driver having some changes in "enetc_refill_rx_ring".
Is it ok for you if I can merge your changes with my patch-set and push them in v2?

https://patches.dpdk.org/project/dpdk/list/?series=4173 

Thanks,
Gagan

Re: [dpdk-stable] [PATCH v2 2/2] net/enetc: fix big endian build

[Thomas Monjalon]

10/04/2019 13:27, Gagandeep Singh:
> I have sent a patch-set for ENETC driver having some changes in "enetc_refill_rx_ring".
> Is it ok for you if I can merge your changes with my patch-set and push them in v2?
> 
> https://patches.dpdk.org/project/dpdk/list/?series=4173 

Yes, no problem, at the condition it is integrated in 19.05-rc2.

[dpdk-stable] [PATCH v2 2/2] net/enetc: fix big endian build

[Thomas Monjalon]

Compilation was failing when using a big endian toolchain:

drivers/net/enetc/enetc_rxtx.c:92:21: error:
	passing argument 1 of 'rte_constant_bswap64'
	makes integer from pointer without a cast

Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx")
Cc: g.singh@nxp.com
Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/enetc/enetc_rxtx.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c
index 631e2430d..ef0d7919f 100644
--- a/drivers/net/enetc/enetc_rxtx.c
+++ b/drivers/net/enetc/enetc_rxtx.c
@@ -88,8 +88,9 @@ enetc_refill_rx_ring(struct enetc_bdr *rx_ring, const int buff_cnt)
 	rx_swbd = &rx_ring->q_swbd[i];
 	rxbd = ENETC_RXBD(*rx_ring, i);
 	for (j = 0; j < buff_cnt; j++) {
-		rx_swbd->buffer_addr =
-			rte_cpu_to_le_64(rte_mbuf_raw_alloc(rx_ring->mb_pool));
+		rx_swbd->buffer_addr = (void *)(uintptr_t)
+			rte_cpu_to_le_64((uint64_t)(uintptr_t)
+					rte_mbuf_raw_alloc(rx_ring->mb_pool));
 		rxbd->w.addr = (uint64_t)(uintptr_t)
 			       rx_swbd->buffer_addr->buf_addr +
 			       rx_swbd->buffer_addr->data_off;
-- 
2.21.0