* [dpdk-stable] [PATCH] igb_uio: pass MODULE_CFLAGS in new Kbuild
@ 2018-05-01 13:39 luca.boccassi
2018-05-01 13:44 ` Richardson, Bruce
2018-05-01 13:50 ` [dpdk-stable] [PATCH v2] " luca.boccassi
0 siblings, 2 replies; 4+ messages in thread
From: luca.boccassi @ 2018-05-01 13:39 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, Luca Boccassi, stable
From: Luca Boccassi <bluca@debian.org>
With the legacy build system MODULE_CFLAGS can be set to pass compiler
flags specific for the kernel modules builds.
This is used currently by Ubuntu and Debian.
Set ccflags-y in the Kbuild to achieve the same result with Meson, and
to keep backward compatbility with older scripts.
Fixes regression in Ubuntu/Debian when the Kbuild is included in the
DKMS source package, as DKMS will pick it up silently by default if
present, causing the MODULE_CFLAGS to be ignored.
Fixes: a52f4574f798 ("igb_uio: build with meson")
Cc: stable@dpdk.org
---
kernel/linux/igb_uio/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/linux/igb_uio/Kbuild b/kernel/linux/igb_uio/Kbuild
index 98c98fe52..3ab85c411 100644
--- a/kernel/linux/igb_uio/Kbuild
+++ b/kernel/linux/igb_uio/Kbuild
@@ -1 +1,2 @@
+ccflags-y := $(MODULE_CFLAGS)
obj-m := igb_uio.o
--
2.14.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] igb_uio: pass MODULE_CFLAGS in new Kbuild
2018-05-01 13:39 [dpdk-stable] [PATCH] igb_uio: pass MODULE_CFLAGS in new Kbuild luca.boccassi
@ 2018-05-01 13:44 ` Richardson, Bruce
2018-05-01 13:50 ` [dpdk-stable] [PATCH v2] " luca.boccassi
1 sibling, 0 replies; 4+ messages in thread
From: Richardson, Bruce @ 2018-05-01 13:44 UTC (permalink / raw)
To: luca.boccassi, dev; +Cc: Luca Boccassi, stable
> -----Original Message-----
> From: luca.boccassi@gmail.com [mailto:luca.boccassi@gmail.com]
> Sent: Tuesday, May 1, 2018 2:39 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Luca Boccassi
> <bluca@debian.org>; stable@dpdk.org
> Subject: [PATCH] igb_uio: pass MODULE_CFLAGS in new Kbuild
>
> From: Luca Boccassi <bluca@debian.org>
>
> With the legacy build system MODULE_CFLAGS can be set to pass compiler
> flags specific for the kernel modules builds.
> This is used currently by Ubuntu and Debian.
> Set ccflags-y in the Kbuild to achieve the same result with Meson, and to
> keep backward compatbility with older scripts.
>
> Fixes regression in Ubuntu/Debian when the Kbuild is included in the DKMS
> source package, as DKMS will pick it up silently by default if present,
> causing the MODULE_CFLAGS to be ignored.
>
> Fixes: a52f4574f798 ("igb_uio: build with meson")
> Cc: stable@dpdk.org
> ---
> kernel/linux/igb_uio/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/linux/igb_uio/Kbuild b/kernel/linux/igb_uio/Kbuild
> index 98c98fe52..3ab85c411 100644
> --- a/kernel/linux/igb_uio/Kbuild
> +++ b/kernel/linux/igb_uio/Kbuild
> @@ -1 +1,2 @@
> +ccflags-y := $(MODULE_CFLAGS)
> obj-m := igb_uio.o
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH v2] igb_uio: pass MODULE_CFLAGS in new Kbuild
2018-05-01 13:39 [dpdk-stable] [PATCH] igb_uio: pass MODULE_CFLAGS in new Kbuild luca.boccassi
2018-05-01 13:44 ` Richardson, Bruce
@ 2018-05-01 13:50 ` luca.boccassi
2018-05-01 15:11 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: luca.boccassi @ 2018-05-01 13:50 UTC (permalink / raw)
To: dev; +Cc: stable
From: Luca Boccassi <bluca@debian.org>
With the legacy build system MODULE_CFLAGS can be set to pass compiler
flags specific for the kernel modules builds.
This is used currently by Ubuntu and Debian.
Set ccflags-y in the Kbuild to achieve the same result with Meson, and
to keep backward compatbility with older scripts.
Fixes regression in Ubuntu/Debian when the Kbuild is included in the
DKMS source package, as DKMS will pick it up silently by default if
present, causing the MODULE_CFLAGS to be ignored.
Fixes: a52f4574f798 ("igb_uio: build with meson")
Cc: stable@dpdk.org
Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: forgot --signed-off, added
kernel/linux/igb_uio/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/linux/igb_uio/Kbuild b/kernel/linux/igb_uio/Kbuild
index 98c98fe52..3ab85c411 100644
--- a/kernel/linux/igb_uio/Kbuild
+++ b/kernel/linux/igb_uio/Kbuild
@@ -1 +1,2 @@
+ccflags-y := $(MODULE_CFLAGS)
obj-m := igb_uio.o
--
2.14.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH v2] igb_uio: pass MODULE_CFLAGS in new Kbuild
2018-05-01 13:50 ` [dpdk-stable] [PATCH v2] " luca.boccassi
@ 2018-05-01 15:11 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-05-01 15:11 UTC (permalink / raw)
To: luca.boccassi; +Cc: stable, dev, bruce.richardson
01/05/2018 15:50, luca.boccassi@gmail.com:
> From: Luca Boccassi <bluca@debian.org>
>
> With the legacy build system MODULE_CFLAGS can be set to pass compiler
> flags specific for the kernel modules builds.
> This is used currently by Ubuntu and Debian.
> Set ccflags-y in the Kbuild to achieve the same result with Meson, and
> to keep backward compatbility with older scripts.
>
> Fixes regression in Ubuntu/Debian when the Kbuild is included in the
> DKMS source package, as DKMS will pick it up silently by default if
> present, causing the MODULE_CFLAGS to be ignored.
>
> Fixes: a52f4574f798 ("igb_uio: build with meson")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-01 15:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-01 13:39 [dpdk-stable] [PATCH] igb_uio: pass MODULE_CFLAGS in new Kbuild luca.boccassi
2018-05-01 13:44 ` Richardson, Bruce
2018-05-01 13:50 ` [dpdk-stable] [PATCH v2] " luca.boccassi
2018-05-01 15:11 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).