patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] net/pcap: fix input only Rx
@ 2020-10-08 11:34 Ferruh Yigit
  2020-10-09 14:39 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2020-10-08 11:34 UTC (permalink / raw)
  To: Ferruh Yigit, Aideen McLoughlin; +Cc: dev, stable, Muthurajan Jayakumar

When input only Rx interface argument 'rx_iface_in' provided, current
code assigns 'eth_null_rx' burst function by mistake and no packet
received as a result.
Like in following usage no packets received from physical interface:
"--vdev net_pcap0,rx_iface_in=eth0,tx_iface=eth0"

Fixing the burst function assignment when 'rx_iface_in' argument is used

Fixes: f14a94591504 ("net/pcap: remove Rx queue argument necessity")
Cc: stable@dpdk.org

Reported-by: Muthurajan Jayakumar <muthurajan.jayakumar@intel.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: aideen.mcloughlin@intel.com
---
 drivers/net/pcap/rte_eth_pcap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index da4988064a..057aa9dbfc 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -1416,7 +1416,8 @@ pmd_pcap_probe(struct rte_vdev_device *dev)
 	devargs_all.is_rx_pcap =
 		rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG) ? 1 : 0;
 	devargs_all.is_rx_iface =
-		rte_kvargs_count(kvlist, ETH_PCAP_RX_IFACE_ARG) ? 1 : 0;
+		(rte_kvargs_count(kvlist, ETH_PCAP_RX_IFACE_ARG) +
+		 rte_kvargs_count(kvlist, ETH_PCAP_RX_IFACE_IN_ARG)) ? 1 : 0;
 	pcaps.num_of_queue = 0;
 
 	devargs_all.is_tx_pcap =
-- 
2.26.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH] net/pcap: fix input only Rx
  2020-10-08 11:34 [dpdk-stable] [PATCH] net/pcap: fix input only Rx Ferruh Yigit
@ 2020-10-09 14:39 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2020-10-09 14:39 UTC (permalink / raw)
  To: Aideen McLoughlin; +Cc: dev, stable, Muthurajan Jayakumar

On 10/8/2020 12:34 PM, Ferruh Yigit wrote:
> When input only Rx interface argument 'rx_iface_in' provided, current
> code assigns 'eth_null_rx' burst function by mistake and no packet
> received as a result.
> Like in following usage no packets received from physical interface:
> "--vdev net_pcap0,rx_iface_in=eth0,tx_iface=eth0"
> 
> Fixing the burst function assignment when 'rx_iface_in' argument is used
> 
> Fixes: f14a94591504 ("net/pcap: remove Rx queue argument necessity")
> Cc: stable@dpdk.org
> 
> Reported-by: Muthurajan Jayakumar <muthurajan.jayakumar@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 11:34 [dpdk-stable] [PATCH] net/pcap: fix input only Rx Ferruh Yigit
2020-10-09 14:39 ` Ferruh Yigit

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox