From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, Min Hu <humin29@huawei.com>,
Ke Zhang <ke1x.zhang@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH v5 1/2] kni: use dedicated function to set random MAC address
Date: Wed, 8 Jun 2022 13:52:40 +0100 [thread overview]
Message-ID: <51f154f9-0686-b602-5eec-69e37daa11c7@xilinx.com> (raw)
In-Reply-To: <20220608121117.1445731-2-andrew.rybchenko@oktetlabs.ru>
On 6/8/2022 1:11 PM, Andrew Rybchenko wrote:
> From: Ke Zhang <ke1x.zhang@intel.com>
>
> eth_hw_addr_random() sets address type correctly.
>
> eth_hw_addr_random() is available since Linux v3.4, so
> no compat is required.
>
> Also fix the warning:
> warning: passing argument 1 of ‘memcpy’ discards ‘const’
> qualifier from pointer target type
>
> Variable dev_addr is done const intentionally in Linux v5.17 to
> prevent using it directly.
>
> Fixes: ea6b39b5b847 ("kni: remove ethtool support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
next prev parent reply other threads:[~2022-06-08 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220531091330.230715-1-ke1x.zhang@intel.com>
2022-06-01 5:45 ` [PATCH v2] examples/kni: clear warning about discarding const qualifier Ke Zhang
2022-06-01 15:44 ` Ferruh Yigit
2022-06-05 9:47 ` [PATCH v3 1/2] kni: use dedicated function to set random MAC address Andrew Rybchenko
2022-06-05 9:47 ` [PATCH v3 2/2] kni: fix warning about discarding const qualifier Andrew Rybchenko
[not found] ` <20220608111359.1234110-1-andrew.rybchenko@oktetlabs.ru>
2022-06-08 11:13 ` [PATCH v4 1/2] kni: use dedicated function to set random MAC address Andrew Rybchenko
2022-06-08 11:13 ` [PATCH v4 2/2] kni: fix warning about discarding const qualifier Andrew Rybchenko
[not found] ` <20220608121117.1445731-1-andrew.rybchenko@oktetlabs.ru>
2022-06-08 12:11 ` [PATCH v5 1/2] kni: use dedicated function to set random MAC address Andrew Rybchenko
2022-06-08 12:52 ` Ferruh Yigit [this message]
2022-06-08 12:11 ` [PATCH v5 2/2] kni: fix warning about discarding const qualifier Andrew Rybchenko
2022-06-08 12:54 ` Ferruh Yigit
2022-06-08 13:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51f154f9-0686-b602-5eec-69e37daa11c7@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=ke1x.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).