Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak

["John Daley (johndale)" <johndale@cisco.com>]

Hi Yongseok,

It should go into 17.11 and hopefully 18.02, 18.05, 18.08 eventually.

Not sure what  you mean when you say it was only for stable releases. It was submitted to dev@ with the Cc: stable@ in the commit. The patch is here: https://patches.dpdk.org/patch/45545/

When cc'ing stable in dev@ submissions, should we generally follow up with an email to stable@ to indicate which stable branches to target? If so, should we update the instructions in the contributors guide (section 6.4), or did I miss where that process is documented?

Thanks,
John

> -----Original Message-----
> From: Yongseok Koh <yskoh@mellanox.com>
> Sent: Thursday, October 04, 2018 2:36 PM
> To: John Daley (johndale) <johndale@cisco.com>
> Cc: johnda888@gmail.com; dpdk stable <stable@dpdk.org>; Hyong Youb Kim
> (hyonkim) <hyonkim@cisco.com>
> Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak
> 
> 
> > On Sep 27, 2018, at 6:51 PM, John Daley <johndale@cisco.com> wrote:
> >
> > rte_flow structures were not being freed when destroyed or flushed.
> >
> > Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced
> > filters enabled")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
> > Reviewed-by: John Daley <johndale@cisco.com>
> > ---
> 
> Hi,
> 
> Is this patch only for stable releases? If so, which one? Or was dev@ absent
> by mistake?
> 
> 
> Thanks,
> Yongseok
> 
> > drivers/net/enic/enic_flow.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/enic/enic_flow.c
> > b/drivers/net/enic/enic_flow.c index 0cf04aefd..9b612f1d5 100644
> > --- a/drivers/net/enic/enic_flow.c
> > +++ b/drivers/net/enic/enic_flow.c
> > @@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev,
> struct rte_flow *flow,
> > 	enic_flow_del_filter(enic, flow->enic_filter_id, error);
> > 	LIST_REMOVE(flow, next);
> > 	rte_spinlock_unlock(&enic->flows_lock);
> > +	rte_free(flow);
> > 	return 0;
> > }
> >
> > @@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, struct
> rte_flow_error *error)
> > 		flow = LIST_FIRST(&enic->flows);
> > 		enic_flow_del_filter(enic, flow->enic_filter_id, error);
> > 		LIST_REMOVE(flow, next);
> > +		rte_free(flow);
> > 	}
> > 	rte_spinlock_unlock(&enic->flows_lock);
> > 	return 0;
> > --
> > 2.16.2
> >