From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) by dpdk.org (Postfix) with ESMTP id 5B6231B12C for ; Fri, 5 Oct 2018 00:03:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2423; q=dns/txt; s=iport; t=1538690637; x=1539900237; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vQHVh7dduRqFDET54fO70hKdjNkgY2UD/5sH54QFabk=; b=VYnQ0dAAX/yC5jCJoGZahsTrAgY+8SxUu7XQuftTtVZiK8u8kwMaJ89N r8qZlOZjdS0ysAFbqClOyveCMW/v/D6zq8eg54+LV9XrPRGkUydJCyCOq V5881eGwln4AHzy8hjPPLpUI7yt4KjispyFTXRobeMcdqDIyNyt6yX/Ve Q=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AGAAD7jbZb/5JdJa1bGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBggVmfygKi3+MIoINiGONehSBZgsBAR+?= =?us-ascii?q?ETQKEJSE0DQ0BAwEBAgEBAm0cDIU5AQEBAQMnEz8MBAIBCA4DBAEBAR4QIRE?= =?us-ascii?q?dCAIEDgUIgxqBaQMVD6YCM4QrAYMJDYJMBYssF4FBP4NvNYJWgXUBEgGFdwK?= =?us-ascii?q?dKywJAoZIhlmDFR+BTI4fiQSDGHKIKgIRFIElHThkcXAVgyeCJReIWoU+b4s?= =?us-ascii?q?NgR+BHwEB?= X-IronPort-AV: E=Sophos;i="5.54,341,1534809600"; d="scan'208";a="459673387" Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 22:03:55 +0000 Received: from XCH-ALN-001.cisco.com (xch-aln-001.cisco.com [173.36.7.11]) by rcdn-core-10.cisco.com (8.15.2/8.15.2) with ESMTPS id w94M3tQD032485 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 4 Oct 2018 22:03:55 GMT Received: from xch-rcd-007.cisco.com (173.37.102.17) by XCH-ALN-001.cisco.com (173.36.7.11) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 4 Oct 2018 17:03:54 -0500 Received: from xch-rcd-007.cisco.com ([173.37.102.17]) by XCH-RCD-007.cisco.com ([173.37.102.17]) with mapi id 15.00.1395.000; Thu, 4 Oct 2018 17:03:54 -0500 From: "John Daley (johndale)" To: Yongseok Koh CC: "johnda888@gmail.com" , dpdk stable , "Hyong Youb Kim (hyonkim)" Thread-Topic: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak Thread-Index: AQHUVs27i5nXOnbGjUGGYTTuFTl6mKUP+poA//+w+ZA= Date: Thu, 4 Oct 2018 22:03:54 +0000 Message-ID: <52280fb7c947471da4432fd7d08fb0a9@XCH-RCD-007.cisco.com> References: <20180928015105.14831-1-johndale@cisco.com> <87F2CBFF-E31E-4C6A-B64A-D94030B1B258@mellanox.com> In-Reply-To: <87F2CBFF-E31E-4C6A-B64A-D94030B1B258@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.24.26.241] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Outbound-SMTP-Client: 173.36.7.11, xch-aln-001.cisco.com X-Outbound-Node: rcdn-core-10.cisco.com Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 22:03:58 -0000 Hi Yongseok, It should go into 17.11 and hopefully 18.02, 18.05, 18.08 eventually. Not sure what you mean when you say it was only for stable releases. It wa= s submitted to dev@ with the Cc: stable@ in the commit. The patch is here: = https://patches.dpdk.org/patch/45545/ When cc'ing stable in dev@ submissions, should we generally follow up with = an email to stable@ to indicate which stable branches to target? If so, sho= uld we update the instructions in the contributors guide (section 6.4), or = did I miss where that process is documented? Thanks, John > -----Original Message----- > From: Yongseok Koh > Sent: Thursday, October 04, 2018 2:36 PM > To: John Daley (johndale) > Cc: johnda888@gmail.com; dpdk stable ; Hyong Youb Kim > (hyonkim) > Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak >=20 >=20 > > On Sep 27, 2018, at 6:51 PM, John Daley wrote: > > > > rte_flow structures were not being freed when destroyed or flushed. > > > > Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced > > filters enabled") > > Cc: stable@dpdk.org > > > > Signed-off-by: Hyong Youb Kim > > Reviewed-by: John Daley > > --- >=20 > Hi, >=20 > Is this patch only for stable releases? If so, which one? Or was dev@ abs= ent > by mistake? >=20 >=20 > Thanks, > Yongseok >=20 > > drivers/net/enic/enic_flow.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/enic/enic_flow.c > > b/drivers/net/enic/enic_flow.c index 0cf04aefd..9b612f1d5 100644 > > --- a/drivers/net/enic/enic_flow.c > > +++ b/drivers/net/enic/enic_flow.c > > @@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev, > struct rte_flow *flow, > > enic_flow_del_filter(enic, flow->enic_filter_id, error); > > LIST_REMOVE(flow, next); > > rte_spinlock_unlock(&enic->flows_lock); > > + rte_free(flow); > > return 0; > > } > > > > @@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, struct > rte_flow_error *error) > > flow =3D LIST_FIRST(&enic->flows); > > enic_flow_del_filter(enic, flow->enic_filter_id, error); > > LIST_REMOVE(flow, next); > > + rte_free(flow); > > } > > rte_spinlock_unlock(&enic->flows_lock); > > return 0; > > -- > > 2.16.2 > >