From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Wenwu Ma <wenwux.ma@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [PATCH] vhost: fix net header settings in vhost datapath
Date: Fri, 3 Feb 2023 15:43:31 +0100 [thread overview]
Message-ID: <522ccc0c-a601-0342-0e23-3020d0bdb792@redhat.com> (raw)
In-Reply-To: <20230104023945.6669-1-wenwux.ma@intel.com>
On 1/4/23 03:39, Wenwu Ma wrote:
> In vhost sync batch enqueue, the "num_buffers" of
> virtio net header is not be set, but it should be
> set to 1 if the mrg_rxbuf feature is turned on,
> This patch fix the issue.
>
> Fixes: ef861692c398 ("vhost: add packed ring batch enqueue")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
> ---
> lib/vhost/virtio_net.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
> index cf796183a0..61d9052a57 100644
> --- a/lib/vhost/virtio_net.c
> +++ b/lib/vhost/virtio_net.c
> @@ -1493,6 +1493,12 @@ virtio_dev_rx_batch_packed_copy(struct virtio_net *dev,
> sizeof(struct virtio_net_hdr_mrg_rxbuf);
> }
>
> + if (rxvq_is_mergeable(dev)) {
> + vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {
> + ASSIGN_UNLESS_EQUAL(hdrs[i]->num_buffers, 1);
> + }
> + }
> +
> vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)
> virtio_enqueue_offload(pkts[i], &hdrs[i]->hdr);
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2023-02-03 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 2:39 Wenwu Ma
2023-01-13 3:06 ` Ling, WeiX
2023-01-13 3:16 ` Jiang, Cheng1
2023-02-03 14:43 ` Maxime Coquelin [this message]
2023-02-03 14:58 ` Maxime Coquelin
-- strict thread matches above, loose matches on Subject: below --
2023-01-04 2:31 Wenwu Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522ccc0c-a601-0342-0e23-3020d0bdb792@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenwux.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).