From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7C52A04DD for ; Tue, 26 Nov 2019 18:01:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 659532B88; Tue, 26 Nov 2019 18:01:48 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A30F92B88; Tue, 26 Nov 2019 18:01:46 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 47557200E3; Tue, 26 Nov 2019 12:01:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 Nov 2019 12:01:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=mO6PI7clbfhtVK5xKq+2LV4Xo0GnbCo7YJEFfLaRJ+Q=; b=qXgCaPGRTepj YkEA9s1sZmF1uEalu7DXrLWf1sGJhiZQlaySQ+MatsG+8SHoSEkAe1hwwUdaOUzR Rn9CGubAWhFiRgKR40Z6txVkiqMa3eyRFkPOgi8cF35B99Y2i3FBtsEajhfWU4vO ZHDpJcQaoZkVpQ4Xrj/+dOOFKEcAVw4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=mO6PI7clbfhtVK5xKq+2LV4Xo0GnbCo7YJEFfLaRJ +Q=; b=n33wGN4irllejFgSRFPQlRszj1CVvxAQE5fld9S2PFEakB6/uCoS4SRXs sEDUoR+IRyZsx4Nr4g7HAqvOnPLX8mxldvmMyfqhNXVIYLerSPzBt2QLXg16Lbd6 OBcohXnG0dPINJGW6UMchnCB2pyeemEcCx1xN1YFY4NirSJRwZxo8Q9mYAhSugOa UiRFA5eyNAYWkTF5I8D8fJLD4ygCm6ut376JwRLM+hwFEfafkbyaxMQjfgAvD7Fi juHE2ZhTd/KaL6h479ivmBgqqISv+3k7XbW3YhEX/P+Al5gAjhYshB5GOfeulQbp OcBg7GfgJiZ94+E1yRaJnIp4A14sg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeifedgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehvrghrshdrmhhkpdhhuhgrrhhmrdgtohhmpdhgnhhurdhorhhgnecukfhp peejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhoh hmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8255A8005B; Tue, 26 Nov 2019 12:01:40 -0500 (EST) From: Thomas Monjalon To: "Phil Yang (Arm Technology China)" Cc: dev@dpdk.org, Bruce Richardson , "david.marchand@redhat.com" , "jerinj@marvell.com" , Honnappa Nagarahalli , "Gavin Hu (Arm Technology China)" , "Joyce Kong (Arm Technology China)" , nd , "stable@dpdk.org" Date: Tue, 26 Nov 2019 18:01:38 +0100 Message-ID: <5285313.iaM3IdUqkp@xps> In-Reply-To: References: <1573468461-25972-1-git-send-email-phil.yang@arm.com> <3677391.EzyCDiKdWj@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 12/11/2019 07:40, Phil Yang (Arm Technology China): > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Tuesday, November 12, 2019 2:03 PM > > To: Phil Yang (Arm Technology China) > > Cc: Bruce Richardson ; dev@dpdk.org; > > david.marchand@redhat.com; jerinj@marvell.com; Honnappa Nagarahalli > > ; Gavin Hu (Arm Technology China) > > ; Joyce Kong (Arm Technology China) > > ; nd ; stable@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf > > architercture > > > > 12/11/2019 06:25, Phil Yang (Arm Technology China): > > > From: Bruce Richardson > > > > On Mon, Nov 11, 2019 at 06:34:20PM +0800, Phil Yang wrote: > > > > > The older version (e.g. version 7.4.0 ) of GNU C compiler for the armhf > > > > > architecture doesn't support the flag '-Wno-address-of-packed- > > member', > > > > > so remove this flag for aarch32. > > > > > > > > > > Fixes: a385972c3675 ("mk: disable warning for packed member pointer") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Phil Yang > > > > > Reviewed-by: Gavin Hu > > > > > Tested-by: Joyce Kong > > > > > > > > > > --- > > > > > mk/toolchain/gcc/rte.vars.mk | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/mk/toolchain/gcc/rte.vars.mk > > b/mk/toolchain/gcc/rte.vars.mk > > > > > index 9fc7041..ec0cbbf 100644 > > > > > --- a/mk/toolchain/gcc/rte.vars.mk > > > > > +++ b/mk/toolchain/gcc/rte.vars.mk > > > > > @@ -100,7 +100,9 @@ WERROR_FLAGS += -Wno-format-truncation > > > > > endif > > > > > > > > > > # disable packed member unalign warnings > > > > > +ifneq ($(CONFIG_RTE_ARCH_ARM), y) > > > > > WERROR_FLAGS += -Wno-address-of-packed-member > > > > > +endif > > > > > > > > > You don't need to do this, as gcc will not complain about this unknown > > flag > > > > unless you have other issues in your code.[1] I think it's better to keep > > the > > > > code clean in this case, otherwise we'll have the code littered with > > > > conditionals for various flags. > > > > > > > > /Bruce > > > > > > > > [1] https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html > > > > "When an unrecognized warning option is requested (e.g., > > > > -Wunknown-warning), GCC emits a diagnostic stating that the option is > > not > > > > recognized. However, if the -Wno- form is used, the behavior is slightly > > > > different: no diagnostic is produced for -Wno-unknown-warning unless > > other > > > > diagnostics are being produced. This allows the use of new -Wno- options > > > > with old compilers, but if something goes wrong, the compiler warns that > > an > > > > unrecognized option is present." > > > > > > Thanks, Bruce. > > > > > > There are thousands of warnings with alignment when compiling for > > ARMv7 (ARMv7 supports unaligned memory access). > > > Without this new flag, the build system works fine for ARMv7. So I add this > > conditional for ARMv7 only. > > > I agree with you we should clean up the code, but it needs a lot of effort to > > achieve that. > > > This patch is going to make the ARMv7 target build successfully during this > > period. > > > > I would go the opposite direction. > > I think we should remove all warnings disablement like "-Wno-something", > > and clean the code. > > Thanks, Thomas. > > I think it is a compiler issue rather than a code defect in this case, as It cannot recognize the '-Waddress-of-packed-member' flag. > "arm-linux-gnueabihf-gcc: error: unrecognized command line option '-Waddress-of-packed-member'" > > > > > If you want to allow building ARMv7, you can just allow warnings as not > > errors. > > So we will still see something is wrong but it won't prevent from building. > > Yes. We did this already, all the alignment issues are emitted as warnings on ARMv7. > Please see these two commits: > 79fa5c2a9992 ("mk: ignore alignment errors for ARMv7") > 6433c19105e8 ("mk: generalize strict alignment warning handling") I don't know what to do with this patch. I think it is not how it should work, but you say your compiler has a real bug. Can you confirm which compiler is it? Does it prevent to compile even with -Wno-error ? Any other opinion?