From: Kevin Traynor <ktraynor@redhat.com>
To: Ke Zhang <ke1x.zhang@intel.com>,
stable@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com,
Luca Boccassi <bluca@debian.org>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>
Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: Re: [PATCH] app/testpmd: fix compile error
Date: Wed, 8 Feb 2023 10:58:07 +0000 [thread overview]
Message-ID: <52978717-6f54-28b0-9b57-7176a7d1fbed@redhat.com> (raw)
In-Reply-To: <20230208052340.159017-1-ke1x.zhang@intel.com>
On 08/02/2023 05:23, Ke Zhang wrote:
> [ upstream commit f99f2e55af7a49a6ee6555a5554847094086017f]
>
> variable 'c' is set but not used, it should be cleard.
>
This is a partial backport of
commit 2809981e858f ("app/testpmd: fix build with clang 15 in flow code")
Commit is already in 22.11 and already backported to 20.11 and 21.11. So
this patch can be ignored. Guessing it was intended for 19.11 only but
forgot tag and was resent later with the 19.11 tag.
thanks,
Kevin.
> Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")
>
> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> ---
> app/test-pmd/config.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 9f96e77ba3..a04ce0ec64 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1457,7 +1457,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule)
> {
> struct rte_port *port;
> struct port_flow **tmp;
> - uint32_t c = 0;
> int ret = 0;
>
> if (port_id_is_invalid(port_id, ENABLED_WARN) ||
> @@ -1490,7 +1489,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule)
> }
> if (i == n)
> tmp = &(*tmp)->next;
> - ++c;
> }
> return ret;
> }
next prev parent reply other threads:[~2023-02-08 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 5:23 Ke Zhang
2023-02-08 10:58 ` Kevin Traynor [this message]
2023-02-09 8:50 ` Zhang, Ke1X
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52978717-6f54-28b0-9b57-7176a7d1fbed@redhat.com \
--to=ktraynor@redhat.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=jingjing.wu@intel.com \
--cc=ke1x.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).