From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4466241C3D for ; Wed, 8 Feb 2023 11:58:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D9544014F; Wed, 8 Feb 2023 11:58:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DAFE440141 for ; Wed, 8 Feb 2023 11:58:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675853891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqoXElxI4x3HFnoB95uz9q4+nyQLsl6ClDzAXG+81Mg=; b=XxQPlO1OiVNi8i3pqapF9R/FltULbNCBMjzOnW58w6R/pwAyZ7CswKUwHzs3K8wPVXPFl9 DeFnFeZI8OBnbGHRwkaH8cMnf9ciNlYLN1eVpWQhysUChFUWAXPKgRmV3pKOZf8MHqddbY XHFAMIOj4BFUIl+t7+thV8+pVGQkdqM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-76-wZmrdA0BOdqk2f2_FYw9HA-1; Wed, 08 Feb 2023 05:58:10 -0500 X-MC-Unique: wZmrdA0BOdqk2f2_FYw9HA-1 Received: by mail-wm1-f69.google.com with SMTP id l21-20020a05600c4f1500b003e00be23a70so963011wmq.2 for ; Wed, 08 Feb 2023 02:58:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:cc:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UqoXElxI4x3HFnoB95uz9q4+nyQLsl6ClDzAXG+81Mg=; b=CuZibqbV5YhqIttO3P6NLNQuMEATvfmNTWffjpYmTVPcQnzqgaRncK1O7TUBPU3Mp2 ztDWC+crc3Bq6Fe3UwNxxQbZBOhsvOPaJhXjCzsCM/Zlm0DLZf73r4INQBTu7Bh0svn0 TmSblyk9UDbwVMpZ33fVqsdvkHoDM5CrQ12CTxN2JtaZr+D/DBWdOdY9QRXOYXYDUWqz sZpGxpzmSksSd/GtVRJjI0fqJJ4ZsEtiF2ikMUf2bvhITbxCF3iJ7WxndmEQro2TT4lw OVTBl3JaTRlKumQE6vveSFcBoSdKbjdlXEmTx3/oFXAfZ0nRzAlfcyaoY7cxlrwrZP5n R2zQ== X-Gm-Message-State: AO0yUKXnQTTRrFTBY+qbWhbl6ao2+xP3dYf4mTvBdoaT5BLPciHLIhA8 oniNiSNJ1GorgDa9iupBMgI5kVI5N53EgBGQyt7V0hmmeL51jabne/8+khNnwPY675CURs7FwhX 2DXO2BimIhYtd X-Received: by 2002:a5d:488b:0:b0:2bf:e533:315a with SMTP id g11-20020a5d488b000000b002bfe533315amr5972767wrq.62.1675853889019; Wed, 08 Feb 2023 02:58:09 -0800 (PST) X-Google-Smtp-Source: AK7set8XF3G3FaZK4nOW7fnKB2XxfQ9nyOQ3TuKK93HpoNGbz9YCZzIgEC/Sg5UH6lcSzh4hOHFMNg== X-Received: by 2002:a5d:488b:0:b0:2bf:e533:315a with SMTP id g11-20020a5d488b000000b002bfe533315amr5972751wrq.62.1675853888824; Wed, 08 Feb 2023 02:58:08 -0800 (PST) Received: from [192.168.0.36] ([78.16.251.63]) by smtp.gmail.com with ESMTPSA id d5-20020adfef85000000b002c3e600d1a8sm7891303wro.95.2023.02.08.02.58.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 02:58:08 -0800 (PST) Message-ID: <52978717-6f54-28b0-9b57-7176a7d1fbed@redhat.com> Date: Wed, 8 Feb 2023 10:58:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 To: Ke Zhang , stable@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com, Luca Boccassi , "Xueming(Steven) Li" References: <20230208052340.159017-1-ke1x.zhang@intel.com> From: Kevin Traynor Cc: Christian Ehrhardt Subject: Re: [PATCH] app/testpmd: fix compile error In-Reply-To: <20230208052340.159017-1-ke1x.zhang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 08/02/2023 05:23, Ke Zhang wrote: > [ upstream commit f99f2e55af7a49a6ee6555a5554847094086017f] > > variable 'c' is set but not used, it should be cleard. > This is a partial backport of commit 2809981e858f ("app/testpmd: fix build with clang 15 in flow code") Commit is already in 22.11 and already backported to 20.11 and 21.11. So this patch can be ignored. Guessing it was intended for 19.11 only but forgot tag and was resent later with the 19.11 tag. thanks, Kevin. > Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") > > Signed-off-by: Ke Zhang > --- > app/test-pmd/config.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 9f96e77ba3..a04ce0ec64 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1457,7 +1457,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule) > { > struct rte_port *port; > struct port_flow **tmp; > - uint32_t c = 0; > int ret = 0; > > if (port_id_is_invalid(port_id, ENABLED_WARN) || > @@ -1490,7 +1489,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule) > } > if (i == n) > tmp = &(*tmp)->next; > - ++c; > } > return ret; > }