From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 504DCA00C2 for ; Mon, 26 Sep 2022 18:47:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20AD64113C; Mon, 26 Sep 2022 18:47:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1241340146 for ; Mon, 26 Sep 2022 18:47:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664210853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RjAbchXRvk0GX8XA4p12ifnTe1l4BS4GPfOerZwYGkk=; b=WBYDPSWg+VUUCijPodJNePv1pYE14hAmVjm4J961dWn6B941pHaeoe+VjY/6DdowA6SmN4 QUyHD4MvK3b8q7QQ6/ZHoY920wU/VVq+BuUVbTfSfl5dw5XDA/3+Pxgo3ylSuIdLipm+Vl B+GaSUR4asYtMM9Nf0P/CBUbcPEq7Ug= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-265-BKzUeZM9Pb23boUaNot4ig-1; Mon, 26 Sep 2022 12:47:32 -0400 X-MC-Unique: BKzUeZM9Pb23boUaNot4ig-1 Received: by mail-wr1-f69.google.com with SMTP id h20-20020adfaa94000000b0022af8c26b72so1357302wrc.7 for ; Mon, 26 Sep 2022 09:47:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=RjAbchXRvk0GX8XA4p12ifnTe1l4BS4GPfOerZwYGkk=; b=x0TDG+iJn+6LuiOTQTcJZFR7bSMYjjlj9RWJQkhPxtoZowZeiu4qluuvkA1fz5JxGl a3PbowIU+LCzse7fYN9abM8LnygmEUwyuB/Kjl4CS4C3tJLaHishrtmrhLCJ8bNC839U Z2Drvs7ie27siX1D7ZaJggEEs14Su8c3IlpjsX4vrl+iOxinWb9Xvhil6eiPca4vJYBT f4Qfx0Gic30Wi+JeQ/UdLfGECgW2yZNEcZBN/ccCCmice9/4Pw6iuml7bABFanqUpcQ1 IHvzv+qfQ6B8kdhYZv3Dz/qi4bm1Y61JzIUGUpTN04wzw88oSGaicp3YJbWwoCc7eX7c LTyg== X-Gm-Message-State: ACrzQf3cUK/A64NVXqd09tP7LPeIn3S5D0PqCBptyZlJFSGwQ+YMvrlq zfjdFGqXYjGz1ulvz7ZepjC3813KowLXOhzYpmUQArCWhYzDp0MATvO7k4Bxx+JagzY9q+0F4eh I0RuaBz8= X-Received: by 2002:a05:600c:3543:b0:3b4:ba45:9945 with SMTP id i3-20020a05600c354300b003b4ba459945mr22585680wmq.58.1664210851334; Mon, 26 Sep 2022 09:47:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7W2UYOFUP7kMYA80W238LqPqZSN1sDNKF+UzFCVghQLRH6S1aGbPkM8C3YS65GjhUoBs4+uw== X-Received: by 2002:a05:600c:3543:b0:3b4:ba45:9945 with SMTP id i3-20020a05600c354300b003b4ba459945mr22585669wmq.58.1664210851144; Mon, 26 Sep 2022 09:47:31 -0700 (PDT) Received: from [192.168.0.36] ([78.16.251.119]) by smtp.gmail.com with ESMTPSA id h3-20020adffd43000000b0022a2f4fa042sm15062030wrs.103.2022.09.26.09.47.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 09:47:30 -0700 (PDT) Message-ID: <52989c97-b2fa-5a06-6e74-0e83e2c8dfa9@redhat.com> Date: Mon, 26 Sep 2022 17:47:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 From: Kevin Traynor To: Luca Boccassi , Christian Ehrhardt Cc: Maxime Coquelin , "stable@dpdk.org" , Xueming Li , Michael Phelan References: <7671019d-fff8-5e7f-1d92-f53d8ffc8032@redhat.com> Subject: Re: Early backport of Vhost regression fix in LTS branches In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 23/09/2022 15:53, Kevin Traynor wrote: > On 20/09/2022 12:10, Luca Boccassi wrote: >> On Tue, 20 Sept 2022 at 12:03, Kevin Traynor wrote: >>> >>> On 20/09/2022 10:36, Maxime Coquelin wrote: >>>> Hi LTS maintainers, >>>> >>>> We have discovered a regression causing deadlock in application using >>>> the Vhost library (when vIOMMU is used & NUMA reallocation happens). >>>> >>>> The faulty commit [0] got backported in all maintained LTS branches, >>>> following minor releases are impacted: >>>> - V21.11.1+ >>>> - V20.11.5+ >>>> - V19.11.12+ >>>> >>>> The fix for this regression is already in main branch, and will be part >>>> of next v22.11 release. >>>> >>>> Discussing with Kevin, he suggested the fix to be backported early to >>>> all the LTS branches. >>>> >>> >>> This issue is a deadlock likely to occur with an application such as >>> OVS, that uses vIOMMU vhost ports and a multi-NUMA system. >>> >>> In normal circumstances, for example with OVS, we could just recommend >>> users not to upgrade to the latest DPDK LTS releases until the issue is >>> fixed. Where this one gets tricky is that the latest LTS releases >>> contains CVE fixes. >>> >>> At the moment if a user wants the CVE fixes *and* the below deadlock >>> fix, they will have to pick patches themselves. It might help some if >>> the DPDK stable branches (which are still at last release point) >>> backport the fix below early so a user can just pull the branch. >>> >>>> Below is the fix to be backported: >>>> >>>> ====================================================================== >>>> commit 0b2a2ca35037d6a5168f0832c11d9858b8ae946a >>>> Author: David Marchand >>>> Date: Mon Jul 25 22:32:03 2022 +0200 >>>> >>>> vhost: fix virtqueue use after free on NUMA reallocation >>>> >>>> translate_ring_addresses (via numa_realloc) may change a virtio >>>> device and >>>> virtio queue. >>>> The virtqueue object must be refreshed before accessing the lock. >>>> >>>> Fixes: 04c27cb673b9 ("vhost: fix unsafe vring addresses modifications") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: David Marchand >>>> Reviewed-by: Maxime Coquelin >>>> ====================================================================== >>>> >>>> The fix can be backported without conflicts to all the LTS branches, >>>> except for v19.11, for which the Vhost directory rename can cause >>>> issues. It can be overcome using below command: >>>> >>>> git cherry-pick -Xfind-renames=5% 0b2a2ca350 >>>> >>>> Is that OK for you? >>>> >>> >>> I can take care of it for all branches if other maintainers are busy and >>> ok with that. >> >> Sounds good to me, feel free to go ahead for 20.11, thank you. >> > > 20.11 and 21.11 are done. > > @Christian, wasn't able to get in touch, not sure if you are on PTO etc. > I don't see any big risk, this is just backporting a patch that would be > backported in a couple of months anyway. So let's say I will push to the > 19.11 branch on Monday if there are no objections. > Pushed to 19.11 branch, thanks. > thanks, > Kevin. > >> Kind regards, >> Luca Boccassi >> >