From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A37787C97;
Mon, 1 May 2017 00:18:50 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 01250207B3;
Sun, 30 Apr 2017 18:18:50 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
by compute1.internal (MEProxy); Sun, 30 Apr 2017 18:18:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=LwceYdwP4XNQKzv
YWTep9FVXa5wdZIHJsoLiXW2bZEA=; b=sNst/YewuRitTzLK9P7jCxcpLyp5qKG
k1ynfA/3ZXnXtL5IuyqrmiJaJaNGUJnMZk2SIu2K9KUusze/sZ5g+g3C/5Ska4/2
ykkJrR9hoE5ParY2tY9NIdqI++i1J94EBx/VUI1z104p8UQ3WRgKQ8P3HBUzF/uN
47drKsFlvch0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
fm1; bh=LwceYdwP4XNQKzvYWTep9FVXa5wdZIHJsoLiXW2bZEA=; b=PF0fyCHz
/JPu4bGv+lI1A5hQ+U9j7WRGlM8ENvbK1tDjcAraFJLrcNZBCm8pJrXEye+2n6Yn
iMm9cf1ialSRuHC3BVfPDtamX5qEQhd5Xt6CEjEO0sN6hFFBGsF37ZxdJgJOyjzN
KqNzQxtY2o+SJOOx5Be9+ta8zSvxJLyFUBCn7vhYNJHUCuOcRKGB/PoUT+5QZkZy
9lRrZxz+v9qQGcasDYclHWMI3N3nRZVK9STE2h5k1aRBZHVVH4GHzYsFrk+tXKrW
+QrFcof0rJUXK6aBloeO5hKTViD8BgQZnu4bM7srqEU1PgaAZnk7rgRmSqfNNUNV
+4nmlhbYrQKn9A==
X-ME-Sender: <xms:yWIGWTbcaGTXyTXJy_4Wehwg-qztx3TXX6TwOM6R5lEwQDwhaGbR-Q>
X-Sasl-enc: SCfd6Iq3aZL+lj1Kwg0n15bgqyx/IBkGSzqyhdSFgUVF 1493590729
Received: from xps.localnet (245.114.118.80.rev.sfr.net [80.118.114.245])
by mail.messagingengine.com (Postfix) with ESMTPA id 9308E24731;
Sun, 30 Apr 2017 18:18:49 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: stable@dpdk.org, Olivier Matz <olivier.matz@6wind.com>, "Glynn,
Michael J" <michael.j.glynn@intel.com>, "Liu, Yu Y" <yu.y.liu@intel.com>,
dev@dpdk.org
Date: Mon, 01 May 2017 00:18:47 +0200
Message-ID: <5335581.HtrMrUQc5L@xps>
In-Reply-To: <20170428111325.7f0d2ab2@platinum>
References: <1493089885-94889-1-git-send-email-wenzhuo.lu@intel.com>
<6A0DE07E22DDAD4C9103DF62FEBC09093B59DB03@shsmsx102.ccr.corp.intel.com>
<20170428111325.7f0d2ab2@platinum>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-stable] [PATCH] lib/librte_cmdline: fix CLI parsing issue
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Apr 2017 22:18:50 -0000
28/04/2017 11:13, Olivier Matz:
> Hi Wenzhuo,
>
> On Fri, 28 Apr 2017 08:38:21 +0000, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> wrote:
> > Hi Oilvier,
> > As we discussed before, I send this patch. Would you like to take a look at it? Better fix it before release 17.05, thanks.
> >
> >
> > > When parsing a CLI, all the CLI instances are checked one by one. Even if an
> > > instance already matches the CLI, the parsing will not stop for ambiguous
> > > check.
> > > The problem is that the following check may change the parsing result of the
> > > previous one even if the following instance doesn't match.
> > >
> > > Use a temporary validate for the parsing result when trying to match an
> > > instance and only store the result when it matches, so the previous result
> > > has no chance to be changed.
> > >
> > > Fixes: af75078fece3 ("first public release")
> > > CC: stable@dpdk.org
> > >
> > > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>
> Sorry for the delay,
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks