From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 712F23005 for ; Wed, 9 Nov 2016 10:58:19 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id f82so231509994wmf.1 for ; Wed, 09 Nov 2016 01:58:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=762SOOaYa8p/uIcW47jUBsYN6qYMGp9KhBnfNZBTKN0=; b=tpQC5wPLdjvizqgEXoM2rZEgke/iPexwX10pRWECmST3fDYVstzL7E09CNqA+NCAOi z5vkIAsSYTQNJgSF4ndtTrrqWmwWDLz6N48XNyFCML0THzBjQMURB3gRv7mE6TwRRkZQ /5FckvP9wG4ObmtDYvcTzF33XBq2PAzP85XHMKEv0LxXcQfqWM0IeLG/hPfn1iJKz0PX 5VUoQODisgrKQqx+dune28pp0vaDvM2d2TT6gNHxXsAGODr3bQqNT+JrzX5EW6uaI7lI ch6KQ1cjs/CkcAQgmEa3UNweQqBpZahdOw8yCFR3FJSZfDDzVQ55QrGeCWkeWnlTDYGw SQNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=762SOOaYa8p/uIcW47jUBsYN6qYMGp9KhBnfNZBTKN0=; b=hL6NG7n6pXQIkWg5GkWgsNUFRhBx/MkpKasn6gaJmGc8z1pdQrjSyboiFioO/19Pzz f73uGzgTrTmYLUGBtKf9TTik1YHhNzXDnleHd60h4YVrdp6jINfseeKjvRl3PgIC4kfe E8bBQ6kMKNC8nnaou/0JTejKR2tiOkrX3Q9g72QHQQlVDg0Jq002dsGVZ71hPS88Ww/4 sBWjlQd5+/L3cCc2cDpvIqa3oZwJKNRMEk9MZVajqsjP/QsGbuGOhYedWkrF5eL0Ntts 3AusUa1d6ZKi0v3qACDvxPG2EZzjOn7s+DpwYtXkoXvRugKU9EOWrU7GLo1+Ve0obqod ZqbQ== X-Gm-Message-State: ABUngvdQAJdTos6+6Pyzk8r7g55rDBFWDQVwjucShGi3oy4VGpea8c8bBkIfmGovmUHrJF9U X-Received: by 10.194.167.40 with SMTP id zl8mr13989000wjb.226.1478685499156; Wed, 09 Nov 2016 01:58:19 -0800 (PST) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id c133sm13926057wme.12.2016.11.09.01.58.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 09 Nov 2016 01:58:18 -0800 (PST) From: Nelio Laranjeiro To: stable@dpdk.org, Yuanhan Liu Cc: Yaacov Hazan , Adrien Mazarguil Date: Wed, 9 Nov 2016 10:57:42 +0100 Message-Id: <5360b6979a5d15635389f7e8ea9a02ae1d1df6b9.1478683594.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-stable] [PATCH v2 03/12] net/mlx5: fix inconsistent return value in flow director X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2016 09:58:19 -0000 From: Yaacov Hazan [ upstream commit c502d05197e35dc2840fdf5892f6310c8cc4b0fd ] The return value in DPDK is negative errno on failure. Since internal functions in mlx driver return positive values need to negate this value when it returned to dpdk layer. Fixes: 76f5c99 ("mlx5: support flow director") Signed-off-by: Yaacov Hazan --- drivers/net/mlx5/mlx5_fdir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_fdir.c b/drivers/net/mlx5/mlx5_fdir.c index 070edde..0372936 100644 --- a/drivers/net/mlx5/mlx5_fdir.c +++ b/drivers/net/mlx5/mlx5_fdir.c @@ -955,7 +955,7 @@ mlx5_dev_filter_ctrl(struct rte_eth_dev *dev, enum rte_filter_op filter_op, void *arg) { - int ret = -EINVAL; + int ret = EINVAL; struct priv *priv = dev->data->dev_private; switch (filter_type) { @@ -970,5 +970,5 @@ mlx5_dev_filter_ctrl(struct rte_eth_dev *dev, break; } - return ret; + return -ret; } -- 2.1.4