patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH 17.11] crypto/qat: fix null auth issues when using vfio_pci
@ 2020-01-08 15:33 Arek Kusztal
  2020-01-09  9:07 ` Luca Boccassi
  0 siblings, 1 reply; 2+ messages in thread
From: Arek Kusztal @ 2020-01-08 15:33 UTC (permalink / raw)
  To: fiona.trahe; +Cc: stable, Arek Kusztal, Damian Nowak

[ upstream commit 65beb9abca6dbb2167a53ab31d79e03f0857357b ]

When running auth NULL cases while using vfio_pci,
DMAR read/write faults appear. It happens even if
digest_length is set to 0. This is caused by auth_res_addr
initialized as 0x0.

Fixes: 4e0955bddb08
Cc: stable@dpdk.org

Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/crypto/qat/qat_crypto.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 85a9ba0..05b37e6 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -1370,10 +1370,8 @@ qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t *out_msg,
 
 		}
 		min_ofs = auth_ofs;
-
-		if (likely(ctx->qat_hash_alg != ICP_QAT_HW_AUTH_ALGO_NULL))
-			auth_param->auth_res_addr =
-					op->sym->auth.digest.phys_addr;
+		auth_param->auth_res_addr =
+			op->sym->auth.digest.phys_addr;
 
 	}
 
-- 
2.1.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH 17.11] crypto/qat: fix null auth issues when using vfio_pci
  2020-01-08 15:33 [dpdk-stable] [PATCH 17.11] crypto/qat: fix null auth issues when using vfio_pci Arek Kusztal
@ 2020-01-09  9:07 ` Luca Boccassi
  0 siblings, 0 replies; 2+ messages in thread
From: Luca Boccassi @ 2020-01-09  9:07 UTC (permalink / raw)
  To: Arek Kusztal, fiona.trahe; +Cc: stable, Damian Nowak

On Wed, 2020-01-08 at 16:33 +0100, Arek Kusztal wrote:
> [ upstream commit 65beb9abca6dbb2167a53ab31d79e03f0857357b ]
> 
> When running auth NULL cases while using vfio_pci,
> DMAR read/write faults appear. It happens even if
> digest_length is set to 0. This is caused by auth_res_addr
> initialized as 0x0.
> 
> Fixes: 4e0955bddb08
> Cc: 
> stable@dpdk.org
> 
> 
> Signed-off-by: Damian Nowak <
> damianx.nowak@intel.com
> >
> Signed-off-by: Arek Kusztal <
> arkadiuszx.kusztal@intel.com
> >
> ---
>  drivers/crypto/qat/qat_crypto.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/qat/qat_crypto.c
> b/drivers/crypto/qat/qat_crypto.c
> index 85a9ba0..05b37e6 100644
> --- a/drivers/crypto/qat/qat_crypto.c
> +++ b/drivers/crypto/qat/qat_crypto.c
> @@ -1370,10 +1370,8 @@ qat_write_hw_desc_entry(struct rte_crypto_op
> *op, uint8_t *out_msg,
>  
>  		}
>  		min_ofs = auth_ofs;
> -
> -		if (likely(ctx->qat_hash_alg !=
> ICP_QAT_HW_AUTH_ALGO_NULL))
> -			auth_param->auth_res_addr =
> -					op->sym->auth.digest.phys_addr;
> +		auth_param->auth_res_addr =
> +			op->sym->auth.digest.phys_addr;
>  
>  	}
>  

Thank you, applied with a small fix to the commit message (Fixes: line
and removed CC).

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 15:33 [dpdk-stable] [PATCH 17.11] crypto/qat: fix null auth issues when using vfio_pci Arek Kusztal
2020-01-09  9:07 ` Luca Boccassi

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox