From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E92F2A046B for ; Thu, 9 Jan 2020 10:07:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA5421DBDD; Thu, 9 Jan 2020 10:07:09 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id ADB581DBDD for ; Thu, 9 Jan 2020 10:07:08 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id y11so6498927wrt.6 for ; Thu, 09 Jan 2020 01:07:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=DSnGWq0pWBoMargvZ7SnA7UCp7YB7OmziVVTycoyLKg=; b=VbwofsasLKK97IUn1gQIjdGhtN6YcuAva3L54Fk8fflzeU6yOOzYfun471Vcbn4iEJ Rcdn2dZoGeA0TIYyRbiUYCpywZoVb4sRJkbdgCFqQGlhiOJ1y8Xeqk2gA1vc10/z/0BK In/0WdkiiB7CqUuBBea2BbqGFSdQpgGWjZjjZuL//PFsaZs7VCq5qfJUHlpmNXO1VxsG 89a1V1IlwT3bdvLtkUXVZ0X/6cDYyii2cOw1KwnCr3gIJVl0lfCI/c1whH1Zx4umEP7Z wQpWkddviO5wyMwON1fth0+6vgwq/pE2nQ9MjgzVg+D9sQN1mXx3fYujwJQvUAwis3nB /juw== X-Gm-Message-State: APjAAAVQzhV9nstfP0UisOhfqov1YL0Lu4ZZNj6wRtOM1ieJ9b7VNKbE nUMGsa4LL4exl7TcYf5rG/HY+Tm+fzI= X-Google-Smtp-Source: APXvYqxaKkdT5Sv1G94WUJTsULBFpk9x0CgRJEcHxSKWdj5G+Jhy40vMsaujWkHvDR9vdxFmnfXAzA== X-Received: by 2002:a5d:46c1:: with SMTP id g1mr9482851wrs.200.1578560828298; Thu, 09 Jan 2020 01:07:08 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id w13sm7310907wru.38.2020.01.09.01.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2020 01:07:07 -0800 (PST) Message-ID: <5451ff6b22a9182517507243d1fe3b22a84def57.camel@debian.org> From: Luca Boccassi To: Arek Kusztal , fiona.trahe@intel.com Cc: stable@dpdk.org, Damian Nowak Date: Thu, 09 Jan 2020 09:07:06 +0000 In-Reply-To: <20200108153301.9916-1-arkadiuszx.kusztal@intel.com> References: <20200108153301.9916-1-arkadiuszx.kusztal@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 17.11] crypto/qat: fix null auth issues when using vfio_pci X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, 2020-01-08 at 16:33 +0100, Arek Kusztal wrote: > [ upstream commit 65beb9abca6dbb2167a53ab31d79e03f0857357b ] >=20 > When running auth NULL cases while using vfio_pci, > DMAR read/write faults appear. It happens even if > digest_length is set to 0. This is caused by auth_res_addr > initialized as 0x0. >=20 > Fixes: 4e0955bddb08 > Cc:=20 > stable@dpdk.org >=20 >=20 > Signed-off-by: Damian Nowak < > damianx.nowak@intel.com > > > Signed-off-by: Arek Kusztal < > arkadiuszx.kusztal@intel.com > > > --- > drivers/crypto/qat/qat_crypto.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/crypto/qat/qat_crypto.c > b/drivers/crypto/qat/qat_crypto.c > index 85a9ba0..05b37e6 100644 > --- a/drivers/crypto/qat/qat_crypto.c > +++ b/drivers/crypto/qat/qat_crypto.c > @@ -1370,10 +1370,8 @@ qat_write_hw_desc_entry(struct rte_crypto_op > *op, uint8_t *out_msg, > =20 > } > min_ofs =3D auth_ofs; > - > - if (likely(ctx->qat_hash_alg !=3D > ICP_QAT_HW_AUTH_ALGO_NULL)) > - auth_param->auth_res_addr =3D > - op->sym->auth.digest.phys_addr; > + auth_param->auth_res_addr =3D > + op->sym->auth.digest.phys_addr; > =20 > } > =20 Thank you, applied with a small fix to the commit message (Fixes: line and removed CC). --=20 Kind regards, Luca Boccassi