From: Thomas Monjalon <thomas@monjalon.net>
To: Nick Connolly <nick.connolly@mayadata.io>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
stable@dpdk.org, "dev@dpdk.org" <dev@dpdk.org>,
Tal Shnaiderman <talshn@nvidia.com>
Subject: Re: [dpdk-stable] [PATCH v3] eal/windows: fix link error with MinGW
Date: Sun, 22 Nov 2020 18:57:36 +0100 [thread overview]
Message-ID: <5460782.JXDLM6G52u@thomas> (raw)
In-Reply-To: <CY4PR1201MB2548D59578046B7263D78C6FA4FD0@CY4PR1201MB2548.namprd12.prod.outlook.com>
> > Linking with the 'pci' driver when building with MinGW on Windows fails with
> > undefined symbol 'GUID_DEVCLASS_NET'.
> > This occurs because devguid.h is included in rte_windows.h before INITGUID
> > is defined.
> >
> > Move the include of devguid.h after the definition of INITGUID.
> >
> > Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
>
> Reviewed-by: Tal Shnaiderman <talshn@nvidia.com>
Applied, thanks
prev parent reply other threads:[~2020-11-22 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201120211255.24803-1-nick.connolly@mayadata.io>
2020-11-22 8:45 ` Nick Connolly
2020-11-22 9:00 ` Tal Shnaiderman
2020-11-22 17:57 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5460782.JXDLM6G52u@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=nick.connolly@mayadata.io \
--cc=pallavi.kadam@intel.com \
--cc=stable@dpdk.org \
--cc=talshn@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).