From: Thomas Monjalon <thomas@monjalon.net>
To: Eli Britstein <elibr@nvidia.com>
Cc: dev@dpdk.org, Gaetan Rivet <gaetanr@nvidia.com>,
Asaf Penso <asafp@nvidia.com>, Ori Kam <orika@nvidia.com>,
stable@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] doc: add Linux rawio capability requirement in mlx5 guide
Date: Thu, 01 Apr 2021 15:15:39 +0200 [thread overview]
Message-ID: <5487886.mdHJMh5dvu@thomas> (raw)
In-Reply-To: <3ded5f26-d1c7-0d87-0e5d-50ef183e29cc@nvidia.com>
01/04/2021 14:06, Eli Britstein:
> On 4/1/2021 2:39 PM, Thomas Monjalon wrote:
> > About the title: "rawio" is not a word.
> > "raw IO" would be better.
>
> It was meant for cap_sys_rawio. As underscores are not allowed in the
> title, I used "rawio".
>
> I think "raw IO" misses that meaning. What do you think?
I think "raw IO capability" can be understood by everybody.
Otherwise "cap_sys_rawio" may be more explicit for those who know.
> > 01/04/2021 09:49, Eli Britstein:
> >> For an application to be able to create "transfer" rte_flows for mlx5
> > What is "tranfer" rule?
>
> https://doc.dpdk.org/guides/prog_guide/rte_flow.html#attribute-transfer
>
> How would you suggest to call it?
"transfer flow rule" is OK.
Or maybe more explicit: "flow rule with transfer attribute".
[...]
> >> +``cap_sys_rawio`` optional
> >> + For the application to be able to apply rte_flow flows in transfer
> >> + mode.
> >
> > "For the application" looks useless.
> > We don't apply "rte_flow flows" but "flow rules".
> > What is "transfer mode"? It is not mentioned elsewhere in this doc.
You could add the link to the transfer attribute here.
> > How this capability is related to dv_esw_en?
>
> I think FDB flows are applicable only if dv_esw_en=1. Do you think need
> to mention it here?
Yes
> > Do we need it in case of trusted VF?
>
> I think a VF, even if trusted cannot apply FDB flows. Only the ESW manager.
Please confirm, and document if it applies only to PF, etc.
When looking at the Linux driver, it seems cap_sys_rawio
is required for all these features:
MLX5_UCTX_CAP_INTERNAL_DEV_RES
MLX5_IB_UAPI_DM_TYPE_STEERING_SW_ICM
MLX5_IB_UAPI_DM_TYPE_HEADER_MODIFY_SW_ICM
IB_WQ_FLAGS_DELAY_DROP
What does apply to the DPDK driver?
prev parent reply other threads:[~2021-04-01 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 7:49 [dpdk-stable] " Eli Britstein
2021-04-01 11:39 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-04-01 12:06 ` Eli Britstein
2021-04-01 13:15 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5487886.mdHJMh5dvu@thomas \
--to=thomas@monjalon.net \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=elibr@nvidia.com \
--cc=gaetanr@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).