From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 5BB00FFA for ; Tue, 8 Nov 2016 11:37:43 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id u144so35419204wmu.1 for ; Tue, 08 Nov 2016 02:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=utTY0sTxWAsa6xOUlg2tDXWQlJFTfjyVj0A9C5JXcwM=; b=uQ2+Nl13GFIuENZXzpr04OvHUvNkMPSPsNERo1v+zO8GLrzKcvQf1aTBumOXsHao8a jSd1V1nce629CoAqNsN6RkU80uv/u6lVvBBCr2HTH7zq1tZKeoc50NZ6MXKVzejbP6IG QhZlq6gXDNcqyXR1e6Rp/AUZl4UR1763A1sj2DHrpiUil7ukxF8VH54i2gZAHERdY2gn WF0PuYOueOqgo0NK7JzJ+60hTD5wql0Fy184WX26H+nHyd9YE02EjWftPdt6pmE6Evxl +z88T4V6THJICV8ATtHoF12UGMhs6gOZDGUMeytfPIQyneBMWMasHVCyazIxqWW1hlDH BO+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=utTY0sTxWAsa6xOUlg2tDXWQlJFTfjyVj0A9C5JXcwM=; b=H/xNXvw91XO/M8zA/ISTonOpwmgBH1pkPzPJAY14cyVUkB6PIyI95+RiEc0RHj6rrM Kd/pgOGxu+N4D3vsseFuuK3ha0wwQ1PhUIoXCslyA8jfqJh0OSNUFrtJl94FgsSZix9N IR9QOy175t1tL28Ma9PFDjXuHyYtXfV+7H+DJvvOBnahsB9xPzOzMGpJQdWjAXvVQcU+ 0iBgoQnhHXY9XN4vILC8rPpALIku8MQWzDdbE2lX4jmUjko3UYrvjifqK/ZT1psYc57W TVCYhPI/HCavdygWvS3Uy/iHBXKTERdXAA8xsVNDeBVBkP5N7hdoL6fGLrhjGCjFyfSI j7Fw== X-Gm-Message-State: ABUngvdmSNy4z58pR0+yzK0E4FTLRx7WnQ3N313o68FQyJaEUk2/HfgCfaWdGSGh21y/gE01 X-Received: by 10.28.226.7 with SMTP id z7mr13024025wmg.83.1478601463025; Tue, 08 Nov 2016 02:37:43 -0800 (PST) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id k74sm18837414wmd.18.2016.11.08.02.37.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Nov 2016 02:37:42 -0800 (PST) From: Nelio Laranjeiro To: stable@dpdk.org, Yuanhan Liu Cc: Yaacov Hazan , Adrien Mazarguil Date: Tue, 8 Nov 2016 11:36:44 +0100 Message-Id: <5581e1316d02f149b8e75a5f2f483d0a7238bb62.1478600855.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-stable] [PATCH 03/14] net/mlx5: fix inconsistent return value in flow director X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2016 10:37:43 -0000 From: Yaacov Hazan The return value in DPDK is negative errno on failure. Since internal functions in mlx driver return positive values need to negate this value when it returned to dpdk layer. Fixes: 76f5c99 ("mlx5: support flow director") Signed-off-by: Yaacov Hazan --- drivers/net/mlx5/mlx5_fdir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_fdir.c b/drivers/net/mlx5/mlx5_fdir.c index 070edde..0372936 100644 --- a/drivers/net/mlx5/mlx5_fdir.c +++ b/drivers/net/mlx5/mlx5_fdir.c @@ -955,7 +955,7 @@ mlx5_dev_filter_ctrl(struct rte_eth_dev *dev, enum rte_filter_op filter_op, void *arg) { - int ret = -EINVAL; + int ret = EINVAL; struct priv *priv = dev->data->dev_private; switch (filter_type) { @@ -970,5 +970,5 @@ mlx5_dev_filter_ctrl(struct rte_eth_dev *dev, break; } - return ret; + return -ret; } -- 2.1.4