From: Thomas Monjalon <thomas@monjalon.net>
To: Sunyang Wu <sunyang.wu@jaguarmicro.com>
Cc: dev@dpdk.org, stable@dpdk.org, stephen@networkplumber.org,
ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH v3] ethdev: fix the bug where the flag variables are assigned
Date: Sun, 08 Jun 2025 18:49:14 +0200 [thread overview]
Message-ID: <5605516.V25eIC5XRa@thomas> (raw)
In-Reply-To: <20250522074242.30376-1-sunyang.wu@jaguarmicro.com>
22/05/2025 09:42, Sunyang Wu:
> Set the values of the promiscuous and all_multicast variables
> according to the return value.
>
> Fixes: af75078fece3 ("first public release")
This is reset to 0 since day 1, so next root cause is not needed.
> Fixes: de5ccf0775ae ("ethdev: do nothing if all-multicast mode is
> applied again")
> Cc: stable@dpdk.org
>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
> - dev->data->promiscuous = 0;
> diag = dev->dev_ops->promiscuous_disable(dev);
> - if (diag != 0)
> - dev->data->promiscuous = 1;
> + if (!diag)
> + dev->data->promiscuous = 0;
Updated the commit log to explain the issue,
and changed the check to compare diag with explicit 0 for success.
Applied, thanks.
prev parent reply other threads:[~2025-06-08 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 7:42 Sunyang Wu
2025-06-08 16:49 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5605516.V25eIC5XRa@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sunyang.wu@jaguarmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).