patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jiayu Hu <jiayu.hu@intel.com>, dev@dpdk.org
Cc: chenbo.xia@intel.com, cheng1.jiang@intel.com,
	xingguang.he@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] vhost: fix packed ring descriptor update in async enqueue
Date: Mon, 8 Nov 2021 09:42:18 +0100	[thread overview]
Message-ID: <561f1c88-91c0-c996-cce1-b05d4fbedc4a@redhat.com> (raw)
In-Reply-To: <1636021170-230805-1-git-send-email-jiayu.hu@intel.com>



On 11/4/21 11:19, Jiayu Hu wrote:
> For the packet using multiple descriptors, the flag of first
> descriptor cannot be updated until finishing updating the flag
> of remaining descriptors. However, if the packet's descriptor
> index is wrapped, the first descriptor's flag is updated earlier
> than the others.

The commit message is ambiguous IMHO, it is not clear whether it
describes the bug or the fix. I understand it describes the problem,
as the first descriptor flags always have to be updated last, but it
please reword it to make it clear what iu the issue, and how this patch
fixes it.

> Fixes: 873e8dad6f49 ("vhost: support packed ring in async datapath")
> Cc: stable@dpdk.org

If you think it is worth backporting it to stable, please take care of
preparing the backport as I suspect it will not apply cleanly.

> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> ---
>   lib/vhost/virtio_net.c | 122 ++++++++++++++++++-----------------------
>   1 file changed, 54 insertions(+), 68 deletions(-)
> 


      reply	other threads:[~2021-11-08  8:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 10:19 Jiayu Hu
2021-11-08  8:42 ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561f1c88-91c0-c996-cce1-b05d4fbedc4a@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=cheng1.jiang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=stable@dpdk.org \
    --cc=xingguang.he@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).