patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Xia, Chenbo" <chenbo.xia@intel.com>,
	"amorenoz@redhat.com" <amorenoz@redhat.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"michaelba@nvidia.com" <michaelba@nvidia.com>,
	"viacheslavo@nvidia.com" <viacheslavo@nvidia.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>,
	"yvugenfi@redhat.com" <yvugenfi@redhat.com>,
	"ybendito@redhat.com" <ybendito@redhat.com>
Subject: Re: [dpdk-stable] [PATCH v3 5/5] app/testpmd: add missing flow types in port info
Date: Fri, 1 Oct 2021 09:51:03 +0200
Message-ID: <567c7418-89ca-3689-56c4-8ae0c65389d6@redhat.com> (raw)
In-Reply-To: <DM4PR11MB553403486A16EB052316759199AA9@DM4PR11MB5534.namprd11.prod.outlook.com>

Hi Xiaoyun,

On 9/30/21 03:05, Li, Xiaoyun wrote:
> Hi
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Wednesday, September 29, 2021 17:17
>> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
>> amorenoz@redhat.com; david.marchand@redhat.com;
>> andrew.rybchenko@oktetlabs.ru; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> michaelba@nvidia.com; viacheslavo@nvidia.com; Li, Xiaoyun
>> <xiaoyun.li@intel.com>
>> Cc: stable@dpdk.org; nelio.laranjeiro@6wind.com; yvugenfi@redhat.com;
>> ybendito@redhat.com; Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH v3 5/5] app/testpmd: add missing flow types in port info
>>
>> This patch adds missing IPv6-Ex and GPTU flow types to port info command.
> 
> GTPU not GPTU
> 
>> It also add the same definitions to str2flowtype(), used to configure flow
>> director.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>>   app/test-pmd/cmdline.c | 4 ++++
>>   app/test-pmd/config.c  | 4 ++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
>> a9efd027c3..259d9cee4e 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -10408,6 +10408,10 @@ str2flowtype(char *string)
>>   		{"ipv6-sctp", RTE_ETH_FLOW_NONFRAG_IPV6_SCTP},
>>   		{"ipv6-other", RTE_ETH_FLOW_NONFRAG_IPV6_OTHER},
>>   		{"l2_payload", RTE_ETH_FLOW_L2_PAYLOAD},
>> +		{"ipv6-ex", RTE_ETH_FLOW_IPV6_EX},
>> +		{"ipv6-tcp-ex", RTE_ETH_FLOW_IPV6_TCP_EX},
>> +		{"ipv6-udp-ex", RTE_ETH_FLOW_IPV6_UDP_EX},
>> +		{"gptu", RTE_ETH_FLOW_GTPU},
> 
> "gtpu"
> 
>>   	};
>>
>>   	for (i = 0; i < RTE_DIM(flowtype_str); i++) { diff --git a/app/test-
>> pmd/config.c b/app/test-pmd/config.c index 9a4a0c232b..39deb02950
>> 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -4528,11 +4528,15 @@ flowtype_to_str(uint16_t flow_type)
>>   		{"ipv6-sctp", RTE_ETH_FLOW_NONFRAG_IPV6_SCTP},
>>   		{"ipv6-other", RTE_ETH_FLOW_NONFRAG_IPV6_OTHER},
>>   		{"l2_payload", RTE_ETH_FLOW_L2_PAYLOAD},
>> +		{"ipv6-ex", RTE_ETH_FLOW_IPV6_EX},
>> +		{"ipv6-tcp-ex", RTE_ETH_FLOW_IPV6_TCP_EX},
>> +		{"ipv6-udp-ex", RTE_ETH_FLOW_IPV6_UDP_EX},
>>   		{"port", RTE_ETH_FLOW_PORT},
>>   		{"vxlan", RTE_ETH_FLOW_VXLAN},
>>   		{"geneve", RTE_ETH_FLOW_GENEVE},
>>   		{"nvgre", RTE_ETH_FLOW_NVGRE},
>>   		{"vxlan-gpe", RTE_ETH_FLOW_VXLAN_GPE},
>> +		{"gptu", RTE_ETH_FLOW_GTPU},
> 
> "gtpu"
> 
>>   	};
>>
>>   	for (i = 0; i < RTE_DIM(flowtype_str_table); i++) {
>> --
>> 2.31.1
> 

Oops, looks like I really want to rename this protocol.
If there are not other comments on the series, I can fix while applying
if this is OK for you.

Thanks,
Maxime


  reply	other threads:[~2021-10-01  7:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  9:16 [dpdk-stable] [PATCH v3 0/5] Virtio PMD RSS support & RSS fixes Maxime Coquelin
2021-09-29  9:16 ` [dpdk-stable] [PATCH v3 1/5] net/virtio: add initial RSS support Maxime Coquelin
2021-09-29  9:16 ` [dpdk-stable] [PATCH v3 2/5] app/testpmd: fix RSS key length Maxime Coquelin
2021-09-29  9:16 ` [dpdk-stable] [PATCH v3 3/5] app/testpmd: fix RSS type display Maxime Coquelin
2021-09-29  9:17 ` [dpdk-stable] [PATCH v3 4/5] net/mlx5: fix RSS RETA update Maxime Coquelin
2021-09-29  9:17 ` [dpdk-stable] [PATCH v3 5/5] app/testpmd: add missing flow types in port info Maxime Coquelin
2021-09-30  1:05   ` Li, Xiaoyun
2021-10-01  7:51     ` Maxime Coquelin [this message]
2021-10-08  1:53       ` Li, Xiaoyun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567c7418-89ca-3689-56c4-8ae0c65389d6@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=michaelba@nvidia.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    --cc=xiaoyun.li@intel.com \
    --cc=ybendito@redhat.com \
    --cc=yvugenfi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git