From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 011CF455B7
for <public@inbox.dpdk.org>; Sun, 7 Jul 2024 16:46:00 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id F01E540668;
Sun, 7 Jul 2024 16:45:59 +0200 (CEST)
Received: from fhigh8-smtp.messagingengine.com
(fhigh8-smtp.messagingengine.com [103.168.172.159])
by mails.dpdk.org (Postfix) with ESMTP id 0283540656;
Sun, 7 Jul 2024 16:45:58 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailfhigh.nyi.internal (Postfix) with ESMTP id 6940811402AA;
Sun, 7 Jul 2024 10:45:57 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Sun, 07 Jul 2024 10:45:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to; s=fm2; t=1720363557;
x=1720449957; bh=mCVW22GnDpDd8Y6O8lLvdXs0WUODcblTXvefRFGq8A4=; b=
XbgLuGfwdXArTf1DkSMAPksQabJoGCCNbFUYINNrqXnlxA8lm9Eo3zzsx326QtBD
M8pXfNM+oM5qmu2BQzcmP1Ycilclk9A5EcJzIdlxm6fi0af7/CUH9N/Yc5Qg68EK
zh7I5gm1HnyGzkIYQyW628bsKhc2elc+4z8w3s3SjFXhSv85Upom52SSFoqmciIk
uU5Yq9oSs8ZUjhKU3rBCU38qpV6wIXZL/Y6yYWEgZQqbDYNHDgZXET08jTR2hnHQ
6nceVkxJyW+BFMaCZMU9fg+gl8IKqfRfW2snFHyJe5gxGzHTYc09j20YSUYcRUcZ
38w3i9h+AONNDGeQMHmLzA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720363557; x=
1720449957; bh=mCVW22GnDpDd8Y6O8lLvdXs0WUODcblTXvefRFGq8A4=; b=X
LnnhSD58YVkfQuEiSnGmeOYRFwNor/09xkahDRKIqHoyWdb11WkmrbR1IiF8diEu
uY/AXN79bU+6FCSbzmJdM0u7lTwQr/HWF/4zkbAq66o6uC+frBi/N7msEBl2ymiM
8E6kwdboUZHlWWiukNaoo5O0804AdWGMwY8R5P8CJFerXU6lJw4t5UINVp4JkC6R
aGt+H+lDOQBp3whqIhp9AjF7cKI5tcV6t0Zs/UxypBMcqBGFFYQbLXh8UjstSyyP
vJXgqdavL5mR2SQRrYMzv5sXtYrZgrQIwlci20buBSPmyiRfnpIK9MpqvG7YImKL
LbIG0ZkHh2oP5M4KxZQKg==
X-ME-Sender: <xms:JaqKZqNLtsGAAwvYfUPAripQvlS-RQSG72vj39r0IRh-Y98OvXiJ_Q>
<xme:JaqKZo_CzJ5Adcb9X_mwTcogAGrzkeexIdWFKP2GmQQvLilSaUdRVMIMQbS5CW5Rp
VDqIA-CE4Mx4kpI8w>
X-ME-Received: <xmr:JaqKZhSpL-lgNevD0zFq4-ykvNJU34GgD2lYA38ktNcUzkXlvEuxLV3ZDjy7KNv8Oe_swgVDHGOEvjCgByQrJNk>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehgdekudcutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg
vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:JaqKZqthhpaeOkNkIrneoTprZOIFq3AcdYq5lAMePmWxAu0vV5XP1A>
<xmx:JaqKZif83mLE4aUBpVJehGO7_BmCu9if0lcIb-4PSs6hFUln-gWbkQ>
<xmx:JaqKZu0CVzalbBBrVgji81RH-Owl3E6LS_LkV8ppR2AI4F3c5Xx4Kw>
<xmx:JaqKZm--xvp5v3v9mwPoqMvjZ3brJgOa2AZ93RRXJDL7E8GgQErruA>
<xmx:JaqKZh4M4o8_UnvfpvTj3iQBbx-PTlIRPuf_zB16vHZz0rXVfMhAXy7f>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
7 Jul 2024 10:45:55 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, stable@dpdk.org,
"Jiale, SongX" <songx.jiale@intel.com>
Subject: Re: [PATCH] telemetry: fix potential connection issue
Date: Sun, 07 Jul 2024 15:11:48 +0200
Message-ID: <5680259.hf2xvdu6PP@thomas>
In-Reply-To: <BN0PR11MB57436B6B12B1E6271B88D0B8E7D62@BN0PR11MB5743.namprd11.prod.outlook.com>
References: <20240621024037.3412372-1-zhichaox.zeng@intel.com>
<BN0PR11MB57436B6B12B1E6271B88D0B8E7D62@BN0PR11MB5743.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
26/06/2024 04:13, Jiale, SongX:
> From: Zhichao Zeng <zhichaox.zeng@intel.com>
> >
> > For calling memcpy when the source and destination addresses are the same,
> > there is a small probability that there will be a copy error issue in some
> > environments, resulting in a failure to connect.
> >
> > This patch uses memmove instead of memcpy to avoid this issue.
> >
> > Fixes: b80fe1805eee ("telemetry: introduce backward compatibility")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> > ---
> Tested-by: Song Jiale <songx.jiale@intel.com>
It would be cleaner to do a proper parsing before doing any copy (strlcpy, memcpy/memmove).
dirty code dirty fixed for now
Applied