From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59E42A0505 for ; Fri, 20 May 2022 17:20:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5239F427F0; Fri, 20 May 2022 17:20:35 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2084.outbound.protection.outlook.com [40.107.244.84]) by mails.dpdk.org (Postfix) with ESMTP id 307EB40156; Fri, 20 May 2022 17:20:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mbXE2oZ8oWA4rXJjmRh2XN+GQFP2HdDir8vH1UJfJpFGdptI+43bKxW9sf+bVDjaY+x+fw4GSFTsmSvvqodlTdDW1e5qjbV3c5HLl3r8OrsepjPyRUEQ2LCqAOMilLoA5IvBx46a0/fkxJ0WTb+KF6NvL+F1QzxC85rdz8RSJfyJXPh7VNtr3lJHeQiWM1gzMbL6Iof8K42XUmtppCzk5aDa/M72A4UtmnDrdwxHqcSCsNgNDX8s10geWrLO2qTy4Gbrz8kDBPCkBoIU6mR7Q1NY48xjIH9GqFs//d3eA0F6g7lFpNcJhBor8ANidOh/jH8UQc90pShSm0/C0CLopg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nSGDnYC9GdQO+kKiHPNeh3foOvbbB887BRqW+VRV0rs=; b=Jz8e8MC1+vfQ3ZJEbw0b2hfX92+1Ho2bU9odCTjtEBAa7h1V/5pr/TCe10asoYk+nfQcqIEzOhQErkcoalGyusxn4xHqMPcQMzNOE5ySnbEtw7XCSQ1bqxblYma1mhkKQq1nzRwkR7qAUzNGFVtVbYwGtO31+wI7cnjX5NigxJo4IrUZYpFzdg6rZbWALasxL/XUUqkk7maS2bwo4WNXnHr+tCRBuyAA5+WyFYy0HuCres+8aT+XDMQHx5lv/9xVZwFk/KW790Tarl5pvszvlmGD2/47TLSPeu0ztpNhW7TyaWk67AuQyZij7frZ26ys5hju1gLMcqyADs4wi6duKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nSGDnYC9GdQO+kKiHPNeh3foOvbbB887BRqW+VRV0rs=; b=ooUOTCjb1gYXdLcAn9+gimvPlkF+RRUta7G/GfPgGs73IkwF0rFb9zMZfTFjKIWxauQfTsvNIjegYf3dKA8Y93lSfRK6TuAa1A3MH1cHfZ7SiDM0FV+8eEKlvnEV0pq4j3/MGc6HsUAycBciofZwdQ/AmKLAYgc3YCMx8DNJHqQ= Received: from DS7PR03CA0298.namprd03.prod.outlook.com (2603:10b6:5:3ad::33) by CY4PR0201MB3618.namprd02.prod.outlook.com (2603:10b6:910:8d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 15:20:31 +0000 Received: from DM3NAM02FT025.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3ad:cafe::5f) by DS7PR03CA0298.outlook.office365.com (2603:10b6:5:3ad::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18 via Frontend Transport; Fri, 20 May 2022 15:20:31 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT025.mail.protection.outlook.com (10.13.4.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Fri, 20 May 2022 15:20:30 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 20 May 2022 16:20:29 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 20 May 2022 16:20:28 +0100 Envelope-to: peng.zhang@corigine.com, dev@dpdk.org, niklas.soderlund@corigine.com, stable@dpdk.org, yong.xu@corigine.com, chaoyong.he@corigine.com Received: from [10.71.119.221] (port=60303) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1ns4QW-0002If-NH; Fri, 20 May 2022 16:20:28 +0100 Message-ID: <56b75a79-386d-40d6-c55c-b6d4f26ef963@amd.com> Date: Fri, 20 May 2022 16:20:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] net/nfp: fix the issue about set the vlan strip offload off Content-Language: en-US To: Peng Zhang , , CC: , Yong Xu , Chaoyong He References: <20220419083857.409261-1-peng.zhang@corigine.com> From: Ferruh Yigit In-Reply-To: <20220419083857.409261-1-peng.zhang@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cea30f78-17bf-42e9-c22b-08da3a74470a X-MS-TrafficTypeDiagnostic: CY4PR0201MB3618:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EoLLkafPio2SfhGhIotXw2mMhjICaTIc9ul5suoaYS1ax/XJsku4cavHpYe+hOtQK69iptYBoFHWonCy6mZr5Oi8ASHcP6bmJ27SawB9JmZ+qABa7t0RTQMsbYv2bRhagsdwZCY7XTQcYZ5PBzcfl+lGsIhU2nITJRuPLjj+T0ED1QPOr6wM8mnwwO97DfD3w1FcZTe6hwJuQK81Eh9zkXzdO/VBGGYTDPvy5ibSRzDJLvypEFfNvfM0V05pvC54pyFSQVn1DovZuyvdNBKA/Z42P5HD+oA2X0Zop4sA4BSTLKRFEE9BB2pD5bftovCO+TMqeVhhqzCvP/lqmn8X+pGXrT0UMPjKvhchsLvyIuf18gaigRDUxUKvX5SoEdC2wv7i8N5l22n8y5eJ4XniuBBtg/L8nuQi0QMVvCw9R9SAhyi99/wD4XWVqU0LexI1oQ2Nc+ZWcGXQn+l154jHN70ESwncXZeKxD0VR8pn0udemsfYPlAfXfuilcANgkVkxdT+byDYEvSgFcXKs439unryhzbFmh4xcWebr8+n95+aIBrT/xBV9Js4gQWgSznf+7ZgM4kLEO2yUE4b3wcvSBXstZOowhO4GCFoHvBmLu2qTjADEiJl/rXEtmUwpaIdFOl+4ZEQrhevNmpn3SL8ggukx03LMcmFtgOg3U7ApC4q3MQjz1sZSky+cGlM8/QOHUS5H0EJNaLWvm4wZzoMtg9KJaw69yRVSjX4SxwgLxk= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(5660300002)(8936002)(7636003)(70586007)(2906002)(31686004)(35950700001)(356005)(26005)(40460700003)(2616005)(508600001)(44832011)(36756003)(70206006)(31696002)(8676002)(86362001)(4326008)(336012)(110136005)(316002)(83380400001)(82310400005)(47076005)(9786002)(54906003)(53546011)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 15:20:30.6820 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cea30f78-17bf-42e9-c22b-08da3a74470a X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT025.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0201MB3618 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 4/19/2022 9:38 AM, Peng Zhang wrote: > When set the vlan_strip_offload off, it doesn't work. > Because we can't update the msg in the nic. > > This patch will fix this error. > > Fixes: d4a27a3b092a ("nfp: add basic features") > Cc: stable@dpdk.org > > Signed-off-by: Peng Zhang > Signed-off-by: Yong Xu > Signed-off-by: Chaoyong He Hi Niklas, Reminder of this patch waiting for your review. > --- > drivers/net/nfp/nfp_common.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > index b26770dbfb..ab4cfda389 100644 > --- a/drivers/net/nfp/nfp_common.c > +++ b/drivers/net/nfp/nfp_common.c > @@ -968,19 +968,18 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev, int mask) > int ret; > > hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private); > - new_ctrl = 0; > + new_ctrl = hw->ctrl; > > - /* Enable vlan strip if it is not configured yet */ > - if ((mask & RTE_ETH_VLAN_STRIP_OFFLOAD) && > - !(hw->ctrl & NFP_NET_CFG_CTRL_RXVLAN)) > - new_ctrl = hw->ctrl | NFP_NET_CFG_CTRL_RXVLAN; > - > - /* Disable vlan strip just if it is configured */ > - if (!(mask & RTE_ETH_VLAN_STRIP_OFFLOAD) && > - (hw->ctrl & NFP_NET_CFG_CTRL_RXVLAN)) > - new_ctrl = hw->ctrl & ~NFP_NET_CFG_CTRL_RXVLAN; > + if (mask & RTE_ETH_VLAN_STRIP_OFFLOAD) { > + /* Disable vlan strip just if it is configured */ > + if (hw->ctrl & NFP_NET_CFG_CTRL_RXVLAN) > + new_ctrl = new_ctrl & ~NFP_NET_CFG_CTRL_RXVLAN; > + /* Enable vlan strip if it is not configured yet */ > + else > + new_ctrl = new_ctrl | NFP_NET_CFG_CTRL_RXVLAN; > + } > > - if (new_ctrl == 0) > + if (new_ctrl == hw->ctrl) > return 0; > > update = NFP_NET_CFG_UPDATE_GEN;