Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 2/14/2024 5:22 PM, Dumitrescu, Cristian wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@amd.com>
>> Sent: Wednesday, February 14, 2024 11:22 AM
>> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; dev@dpdk.org
>> Cc: stable@dpdk.org; Marchand, David <david.marchand@redhat.com>; Aaron
>> Conole <aconole@redhat.com>; Richardson, Bruce
>> <bruce.richardson@intel.com>
>> Subject: Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h
>>
>> On 2/13/2024 5:38 PM, Cristian Dumitrescu wrote:
>>> When rte_log.h was moved to a new directory, the include path was not
>>> updated for the generated C code produced by the pipeline library,
>>> which results in build failure for this code.
>>>
>>> Fixes: 09ce41310930 ("log: separate logging functions out of EAL")
>>> Cc: stable@dpdk.org
>>>
>>
>> Hi Cristian,
>>
>> How can I verify the fix? Can you please list the required steps?
>>
> 
> Just build the examples/pipeline app and the run this app with the command line below (you can use l2fwd.cli or any other .cli file from the same folder):
> 	./build/examples/dpdk-pipeline -l0-1 -- -s ./examples/pipeline/examples/l2fwd.cli
> 
> If everything works, then you should:
> 	i) not get any error message, especially for the "pipeline libbuild /tmp/l2fwd.c /tmp/l2fwd.so" line from l2fwd.cli script).
> 	ii) have the file "/tmp/l2fwd.so" created.
> 	iii) get the traffic flowing (if you have the NICs working)
> 
> Note: you would need to adjust the ethdev BFDs to those in your setup in the .cli file and the ethdev.io file from the same folder. Just read through the .cli file.
> 

Thanks, I just tested the /tmp/l2fwd.so build, and confirmed the fix.

But it is hard to script this testcase. If 'dpdk-pipeline' exits with
failure when building ' /tmp/l2fwd.so' fails, at least this can be
tested easier in a script, does this make sense?