patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Flavia Musatescu <flavia.musatescu@intel.com>, dev@dpdk.org
Cc: kevin.laatz@intel.com, stable@dpdk.org,
	Reshma Pattan <reshma.pattan@intel.com>,
	ciara.power@intel.com, bruce.richardson@intel.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] telemetry: fix build warnings seen when using gcc 9
Date: Fri, 23 Aug 2019 11:01:19 +0100
Message-ID: <571738bd-fbe5-42e5-5abc-cfec4f0aa71b@redhat.com> (raw)
In-Reply-To: <1562077208-15355-1-git-send-email-flavia.musatescu@intel.com>

On 02/07/2019 15:20, Flavia Musatescu wrote:
> Suppress the unaligned packed member address warnings by extending
> the telemetry library build flags with -Wno-address-of-packed-member
> option, through the WERROR_FLAGS makefile variable.
> 
> With this change additional warnings are turned on to be treated as errors,
> which causes the following build issues to be seen:
> - no previous prototype [-Werror=missing-prototypes]
> - initialization discards ‘const’ qualifier from pointer target type
>   [-Werror=discarded-qualifiers]
> - old-style function definition [-Werror=old-style-definition]
> - variable may be used before its value is set (when using icc compiler).
> 
> Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats")
> Fixes: ee5ff0d3297e ("telemetry: add client feature and sockets")
> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> Fixes: 1b756087db93 ("telemetry: add parser for client socket messages")
> Fixes: fff6df7bf58e ("telemetry: fix using ports of different types")
> Fixes: 4080e46c8078 ("telemetry: support global metrics")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Signed-off-by: Flavia Musatescu <flavia.musatescu@intel.com>

Hi Flavio, in the 18.11. stable branch, I had "fixed" the gcc9 warnings
in telemetry with 2ae7bca9594d ("mk: disable packed member pointer
warning for telemetry")

This patch in 18.11 branch is causing the following build error:

/root/lts/dpdk-18.11/lib/librte_telemetry/rte_telemetry.c:1822:13:
error: initialization discards ‘const’ qualifier from pointer target
type [-Werror=discarded-qualifiers]
  .opt_str = "--telemetry",
             ^~~~~~~~~~~~~

I'm inclined to just keep the existing existing patch in stable and not
apply this one. Or if you want to do a backport for 18.11 branch that is
ok too. WDYT?

  parent reply	other threads:[~2019-08-23 10:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 14:20 [dpdk-stable] " Flavia Musatescu
2019-07-03  9:23 ` [dpdk-stable] [PATCH v2] " Flavia Musatescu
2019-07-03 16:39   ` Laatz, Kevin
2019-07-04 16:49     ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-08-23 10:01 ` Kevin Traynor [this message]
2019-08-23 16:07   ` [dpdk-stable] [dpdk-dev] [PATCH] " Musatescu, Flavia
2019-08-28  9:34     ` [dpdk-stable] [PATCH v2] " Flavia Musatescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571738bd-fbe5-42e5-5abc-cfec4f0aa71b@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    --cc=flavia.musatescu@intel.com \
    --cc=kevin.laatz@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git