patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <>
To: Flavia Musatescu <>,
	Reshma Pattan <>,,
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] telemetry: fix build warnings seen when using gcc 9
Date: Fri, 23 Aug 2019 11:01:19 +0100
Message-ID: <> (raw)
In-Reply-To: <>

On 02/07/2019 15:20, Flavia Musatescu wrote:
> Suppress the unaligned packed member address warnings by extending
> the telemetry library build flags with -Wno-address-of-packed-member
> option, through the WERROR_FLAGS makefile variable.
> With this change additional warnings are turned on to be treated as errors,
> which causes the following build issues to be seen:
> - no previous prototype [-Werror=missing-prototypes]
> - initialization discards ‘const’ qualifier from pointer target type
>   [-Werror=discarded-qualifiers]
> - old-style function definition [-Werror=old-style-definition]
> - variable may be used before its value is set (when using icc compiler).
> Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats")
> Fixes: ee5ff0d3297e ("telemetry: add client feature and sockets")
> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> Fixes: 1b756087db93 ("telemetry: add parser for client socket messages")
> Fixes: fff6df7bf58e ("telemetry: fix using ports of different types")
> Fixes: 4080e46c8078 ("telemetry: support global metrics")
> Cc:
> Signed-off-by: Reshma Pattan <>
> Signed-off-by: Flavia Musatescu <>

Hi Flavio, in the 18.11. stable branch, I had "fixed" the gcc9 warnings
in telemetry with 2ae7bca9594d ("mk: disable packed member pointer
warning for telemetry")

This patch in 18.11 branch is causing the following build error:

error: initialization discards ‘const’ qualifier from pointer target
type [-Werror=discarded-qualifiers]
  .opt_str = "--telemetry",

I'm inclined to just keep the existing existing patch in stable and not
apply this one. Or if you want to do a backport for 18.11 branch that is
ok too. WDYT?

  parent reply	other threads:[~2019-08-23 10:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 14:20 [dpdk-stable] " Flavia Musatescu
2019-07-03  9:23 ` [dpdk-stable] [PATCH v2] " Flavia Musatescu
2019-07-03 16:39   ` Laatz, Kevin
2019-07-04 16:49     ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-08-23 10:01 ` Kevin Traynor [this message]
2019-08-23 16:07   ` [dpdk-stable] [dpdk-dev] [PATCH] " Musatescu, Flavia
2019-08-28  9:34     ` [dpdk-stable] [PATCH v2] " Flavia Musatescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ \
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone