* [PATCH] net/idpf: fix build option check
@ 2022-12-08 3:31 Jingjing Wu
2022-12-08 7:46 ` Morten Brørup
2022-12-09 3:15 ` Xing, Beilei
0 siblings, 2 replies; 6+ messages in thread
From: Jingjing Wu @ 2022-12-08 3:31 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu, beilei.xing, stable
When enable_iova_as_pa option is disabled, idpf driver should avoid
the building in its build file.
Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue model)
Cc: stable@dpdk.org
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
drivers/net/idpf/meson.build | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/idpf/meson.build b/drivers/net/idpf/meson.build
index 998afd21fe..650dade0b9 100644
--- a/drivers/net/idpf/meson.build
+++ b/drivers/net/idpf/meson.build
@@ -7,6 +7,12 @@ if is_windows
subdir_done()
endif
+if dpdk_conf.get('RTE_IOVA_AS_PA') == 0
+ build = false
+ reason = 'driver does not support disabling IOVA as PA mode'
+ subdir_done()
+endif
+
deps += ['common_idpf']
sources = files(
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] net/idpf: fix build option check
2022-12-08 3:31 [PATCH] net/idpf: fix build option check Jingjing Wu
@ 2022-12-08 7:46 ` Morten Brørup
2022-12-09 3:15 ` Xing, Beilei
1 sibling, 0 replies; 6+ messages in thread
From: Morten Brørup @ 2022-12-08 7:46 UTC (permalink / raw)
To: Jingjing Wu, dev; +Cc: beilei.xing, stable
> From: Jingjing Wu [mailto:jingjing.wu@intel.com]
> Sent: Thursday, 8 December 2022 04.31
>
> When enable_iova_as_pa option is disabled, idpf driver should avoid
> the building in its build file.
>
> Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue
> model)
> Cc: stable@dpdk.org
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> drivers/net/idpf/meson.build | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/idpf/meson.build
> b/drivers/net/idpf/meson.build
> index 998afd21fe..650dade0b9 100644
> --- a/drivers/net/idpf/meson.build
> +++ b/drivers/net/idpf/meson.build
> @@ -7,6 +7,12 @@ if is_windows
> subdir_done()
> endif
>
> +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0
> + build = false
> + reason = 'driver does not support disabling IOVA as PA mode'
> + subdir_done()
> +endif
> +
> deps += ['common_idpf']
>
> sources = files(
> --
> 2.25.1
>
I had to try the same, so I can surely say...
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] net/idpf: fix build option check
2022-12-08 3:31 [PATCH] net/idpf: fix build option check Jingjing Wu
2022-12-08 7:46 ` Morten Brørup
@ 2022-12-09 3:15 ` Xing, Beilei
2022-12-13 1:52 ` Zhang, Qi Z
1 sibling, 1 reply; 6+ messages in thread
From: Xing, Beilei @ 2022-12-09 3:15 UTC (permalink / raw)
To: Wu, Jingjing, dev; +Cc: stable
> -----Original Message-----
> From: Wu, Jingjing <jingjing.wu@intel.com>
> Sent: Thursday, December 8, 2022 11:31 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/idpf: fix build option check
>
> When enable_iova_as_pa option is disabled, idpf driver should avoid the
> building in its build file.
>
> Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue model)
> Cc: stable@dpdk.org
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> drivers/net/idpf/meson.build | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/idpf/meson.build b/drivers/net/idpf/meson.build
> index 998afd21fe..650dade0b9 100644
> --- a/drivers/net/idpf/meson.build
> +++ b/drivers/net/idpf/meson.build
> @@ -7,6 +7,12 @@ if is_windows
> subdir_done()
> endif
>
> +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0
> + build = false
> + reason = 'driver does not support disabling IOVA as PA mode'
> + subdir_done()
> +endif
> +
> deps += ['common_idpf']
>
> sources = files(
> --
> 2.25.1
Acked-by: Beilei Xing <beilei.xing@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] net/idpf: fix build option check
2022-12-09 3:15 ` Xing, Beilei
@ 2022-12-13 1:52 ` Zhang, Qi Z
2023-02-17 22:34 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Zhang, Qi Z @ 2022-12-13 1:52 UTC (permalink / raw)
To: Xing, Beilei, Wu, Jingjing, dev; +Cc: stable
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Friday, December 9, 2022 11:15 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/idpf: fix build option check
>
>
>
> > -----Original Message-----
> > From: Wu, Jingjing <jingjing.wu@intel.com>
> > Sent: Thursday, December 8, 2022 11:31 AM
> > To: dev@dpdk.org
> > Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/idpf: fix build option check
> >
> > When enable_iova_as_pa option is disabled, idpf driver should avoid
> > the building in its build file.
> >
> > Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue
> > model)
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> > ---
> > drivers/net/idpf/meson.build | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/net/idpf/meson.build
> > b/drivers/net/idpf/meson.build index 998afd21fe..650dade0b9 100644
> > --- a/drivers/net/idpf/meson.build
> > +++ b/drivers/net/idpf/meson.build
> > @@ -7,6 +7,12 @@ if is_windows
> > subdir_done()
> > endif
> >
> > +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0
> > + build = false
> > + reason = 'driver does not support disabling IOVA as PA mode'
> > + subdir_done()
> > +endif
> > +
> > deps += ['common_idpf']
> >
> > sources = files(
> > --
> > 2.25.1
>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/idpf: fix build option check
2022-12-13 1:52 ` Zhang, Qi Z
@ 2023-02-17 22:34 ` Thomas Monjalon
2023-02-19 10:52 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2023-02-17 22:34 UTC (permalink / raw)
To: Xing, Beilei, Wu, Jingjing, Zhang, Qi Z; +Cc: dev, stable
13/12/2022 02:52, Zhang, Qi Z:
> From: Xing, Beilei <beilei.xing@intel.com>
> > From: Wu, Jingjing <jingjing.wu@intel.com>
> > > When enable_iova_as_pa option is disabled, idpf driver should avoid
> > > the building in its build file.
> > >
> > > Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue
> > > model)
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> > > ---
> > > --- a/drivers/net/idpf/meson.build
> > > +++ b/drivers/net/idpf/meson.build
> > > +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0
> > > + build = false
> > > + reason = 'driver does not support disabling IOVA as PA mode'
> > > + subdir_done()
> > > +endif
> >
> > Acked-by: Beilei Xing <beilei.xing@intel.com>
>
> Applied to dpdk-next-net-intel.
I think this patch is not needed since we have this check done for all drivers:
+ pmd_supports_disable_iova_as_pa = false
[...]
+ if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 and not pmd_supports_disable_iova_as_pa and not always_enable.contains(drv_path)
+ build = false
+ reason = 'driver does not support disabling IOVA as PA mode'
+ endif
I will skip this patch and mark it as Rejected in patchwork.
Please confirm the decision is OK.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/idpf: fix build option check
2023-02-17 22:34 ` Thomas Monjalon
@ 2023-02-19 10:52 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2023-02-19 10:52 UTC (permalink / raw)
To: Xing, Beilei, Wu, Jingjing, Zhang, Qi Z; +Cc: dev, stable
17/02/2023 23:34, Thomas Monjalon:
> 13/12/2022 02:52, Zhang, Qi Z:
> > From: Xing, Beilei <beilei.xing@intel.com>
> > > From: Wu, Jingjing <jingjing.wu@intel.com>
> > > > When enable_iova_as_pa option is disabled, idpf driver should avoid
> > > > the building in its build file.
> > > >
> > > > Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue
> > > > model)
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> > > > ---
> > > > --- a/drivers/net/idpf/meson.build
> > > > +++ b/drivers/net/idpf/meson.build
> > > > +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0
> > > > + build = false
> > > > + reason = 'driver does not support disabling IOVA as PA mode'
> > > > + subdir_done()
> > > > +endif
> > >
> > > Acked-by: Beilei Xing <beilei.xing@intel.com>
> >
> > Applied to dpdk-next-net-intel.
>
> I think this patch is not needed since we have this check done for all drivers:
>
> + pmd_supports_disable_iova_as_pa = false
> [...]
> + if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 and not pmd_supports_disable_iova_as_pa and not always_enable.contains(drv_path)
> + build = false
> + reason = 'driver does not support disabling IOVA as PA mode'
> + endif
>
> I will skip this patch and mark it as Rejected in patchwork.
> Please confirm the decision is OK.
After more thoughts, I think we should only stop compilation in common/idpf:
+if not get_option('enable_iova_as_pa')
+ subdir_done()
+endif
No need to give reason or disable build as it will be done anyway in drivers/meson.build.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-19 10:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-08 3:31 [PATCH] net/idpf: fix build option check Jingjing Wu
2022-12-08 7:46 ` Morten Brørup
2022-12-09 3:15 ` Xing, Beilei
2022-12-13 1:52 ` Zhang, Qi Z
2023-02-17 22:34 ` Thomas Monjalon
2023-02-19 10:52 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).