* [PATCH] net/mlx5: fix the WQE size calculation for Tx queue [not found] <20250623173524.128125-1:x-bingz@nvidia.com> @ 2025-06-27 8:25 ` Bing Zhao 2025-06-27 9:27 ` Thomas Monjalon 0 siblings, 1 reply; 2+ messages in thread From: Bing Zhao @ 2025-06-27 8:25 UTC (permalink / raw) To: viacheslavo, matan; +Cc: dev, thomas, dsosnowski, suanmingm, rasland, stable The txq_calc_wqebb_cnt() should be consistent with the calculation in the function mlx5_txq_devx_obj_new(). Or when the input descriptor number is 512, the WQE size will be wrongly considered to be 30 when no max_inline_data is zero in some cases. The total number of WQE will be considered as 256 and that is incorrect. Adjusting the WQE size will solve the wrong calculation when the calculated WQE size is less than 64B. Fixes: 38b4b397a57d ("net/mlx5: add Tx configuration and setup") Cc: viacheslavo@nvidia.com Cc: stable@dpdk.org Signed-off-by: Bing Zhao <bingz@nvidia.com> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> --- drivers/net/mlx5/mlx5_txq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index 5fee5bc4e8..62b3fc4f25 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -709,6 +709,7 @@ txq_calc_wqebb_cnt(struct mlx5_txq_ctrl *txq_ctrl) MLX5_WSEG_SIZE - MLX5_ESEG_MIN_INLINE_SIZE + txq_ctrl->max_inline_data; + wqe_size = RTE_MAX(wqe_size, MLX5_WQE_SIZE); return rte_align32pow2(wqe_size * desc) / MLX5_WQE_SIZE; } -- 2.34.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/mlx5: fix the WQE size calculation for Tx queue 2025-06-27 8:25 ` [PATCH] net/mlx5: fix the WQE size calculation for Tx queue Bing Zhao @ 2025-06-27 9:27 ` Thomas Monjalon 0 siblings, 0 replies; 2+ messages in thread From: Thomas Monjalon @ 2025-06-27 9:27 UTC (permalink / raw) To: Bing Zhao; +Cc: viacheslavo, matan, stable, dev, dsosnowski, suanmingm, rasland 27/06/2025 10:25, Bing Zhao: > The txq_calc_wqebb_cnt() should be consistent with the calculation in > the function mlx5_txq_devx_obj_new(). Or when the input descriptor > number is 512, the WQE size will be wrongly considered to be 30 when > no max_inline_data is zero in some cases. The total number of WQE will > be considered as 256 and that is incorrect. > > Adjusting the WQE size will solve the wrong calculation when the > calculated WQE size is less than 64B. > > Fixes: 38b4b397a57d ("net/mlx5: add Tx configuration and setup") > Cc: viacheslavo@nvidia.com > Cc: stable@dpdk.org > > Signed-off-by: Bing Zhao <bingz@nvidia.com> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> Applied, thanks. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-27 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250623173524.128125-1:x-bingz@nvidia.com>
2025-06-27 8:25 ` [PATCH] net/mlx5: fix the WQE size calculation for Tx queue Bing Zhao
2025-06-27 9:27 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).