From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06FE9A04B3 for ; Tue, 24 Dec 2019 12:16:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E00951252; Tue, 24 Dec 2019 12:16:30 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 472731252 for ; Tue, 24 Dec 2019 12:16:29 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id b6so19586323wrq.0 for ; Tue, 24 Dec 2019 03:16:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Xu6eagUaSOdq/qyIEvrAxDSDEybdAId/IwR37QLHxKk=; b=hcv2jtdk7QdnzIZjx8i+fvQihadkZR9IyJX+HaIA5eRYslCnagajlBzKBql8GZgbIH PMa8Qgvs7vFekNIIw6PH40dT/TrNfK9AI3CTRJyaNsfWHTBUda3sg47Gj4RJbr+I78Jt r7tDXs0HZJyPtq4hHOrBL02UlWSvKS8zdydL3M1qOfBlD0g1ghDcCrdpyCyKFxIZNHhK QJssNrYUF1egJxdbsdl5xXaMXX12dish3GJYHPNg33cqbrzD6UcVJKvpb7Gq6rmrQZC7 o+GwvXUAV/mHE0mqTuispx4+HIKQG30f4oa7O9M5jXzYSFVZv7eqTV5i+gEA/Zn034Ki h7xw== X-Gm-Message-State: APjAAAXWwsp2DGBdM/3GXKbeZms4rWhOovkJYd1A/r/Pm2AXmPl/9N4w jO/QdV660WtGZtQQIlyNKEFegG93aZg= X-Google-Smtp-Source: APXvYqyoFbPYt8bvHo7YqKWMSu9q+52XD9pm2SsfsfKI7rVlFpeLKAdd8eQ70nQkJMn2FVWTdh07VA== X-Received: by 2002:adf:82f3:: with SMTP id 106mr35859577wrc.69.1577186188998; Tue, 24 Dec 2019 03:16:28 -0800 (PST) Received: from localhost ([80.120.231.178]) by smtp.gmail.com with ESMTPSA id z21sm2355992wml.5.2019.12.24.03.16.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2019 03:16:28 -0800 (PST) Message-ID: <578a0fff5e756b28f43d923768e73b843af7dfe9.camel@debian.org> From: Luca Boccassi To: Kalesh Anakkur Purayil Cc: Somnath Kotur , Ajit Khaparde , dpdk stable Date: Tue, 24 Dec 2019 11:16:27 +0000 In-Reply-To: References: <20191219143447.21506-1-luca.boccassi@gmail.com> <20191219143447.21506-69-luca.boccassi@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] patch 'net/bnxt: fix error handling in xstats' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, Thanks for checking, removed. On Thu, 2019-12-19 at 20:27 +0530, Kalesh Anakkur Purayil wrote: > Hi Luca, >=20 > NAK for this patch as the rebasing was not correctly done. You can > ignore this patch for now from 17.11 stable inclusion. >=20 > Regards, > Kalesh >=20 >=20 > On Thu, Dec 19, 2019 at 8:07 PM wrote: > > Hi, > >=20 > > FYI, your patch has been queued to LTS release 17.11.10 > >=20 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable > > yet. > > It will be pushed if I get no objections before 12/21/19. So please > > shout if anyone has objections. > >=20 > > Also note that after the patch there's a diff of the upstream > > commit vs the > > patch applied to the branch. This will indicate if there was any > > rebasing > > needed to apply to the stable branch. If there were code changes > > for rebasing > > (ie: not only metadata diffs), please double check that the rebase > > was > > correctly done. > >=20 > > Thanks. > >=20 > > Luca Boccassi > >=20 > > --- > > From cf96c144f07d6ac3800a8abccef4f7d3d7e367f6 Mon Sep 17 00:00:00 > > 2001 > > From: Kalesh AP > > Date: Fri, 11 Oct 2019 10:46:44 +0530 > > Subject: [PATCH] net/bnxt: fix error handling in xstats > >=20 > > [ upstream commit 9bc556e3ecec6c1127c6d6c99660742315c59282 ] > >=20 > > Add missing return instead of setting the error status in case of > > error. > >=20 > > Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") > >=20 > > Signed-off-by: Kalesh AP > > Reviewed-by: Somnath Kotur > > Reviewed-by: Ajit Khaparde > > --- > > drivers/net/bnxt/bnxt_stats.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/drivers/net/bnxt/bnxt_stats.c > > b/drivers/net/bnxt/bnxt_stats.c > > index 6497926162..e85db7f6d0 100644 > > --- a/drivers/net/bnxt/bnxt_stats.c > > +++ b/drivers/net/bnxt/bnxt_stats.c > > @@ -365,6 +365,7 @@ void bnxt_dev_xstats_reset_op(struct > > rte_eth_dev *eth_dev) > > if (BNXT_VF(bp) || !BNXT_NPAR_PF(bp) || > > !(bp->flags & BNXT_FLAG_PORT_STATS)) { > > RTE_LOG(ERR, PMD, "Operation not supported\n"); > > + return; > > } > >=20 > > ret =3D bnxt_hwrm_port_clr_stats(bp); > > --=20 > > 2.20.1 > >=20 > > --- > > Diff of the applied patch vs upstream commit (please double-check=20 > > if non-empty: > > --- > > --- - 2019-12-19 14:32:29.067360477 +0000 > > +++ 0069-net-bnxt-fix-error-handling-in-xstats.patch 2019-12-19 > > 14:32:26.153298777 +0000 > > @@ -1,30 +1,30 @@ > > -From 9bc556e3ecec6c1127c6d6c99660742315c59282 Mon Sep 17 00:00:00 > > 2001 > > +From cf96c144f07d6ac3800a8abccef4f7d3d7e367f6 Mon Sep 17 00:00:00 > > 2001 > > From: Kalesh AP > > Date: Fri, 11 Oct 2019 10:46:44 +0530 > > Subject: [PATCH] net/bnxt: fix error handling in xstats > >=20 > > +[ upstream commit 9bc556e3ecec6c1127c6d6c99660742315c59282 ] > > + > > Add missing return instead of setting the error status in case of > > error. > >=20 > > Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") > > -Cc: stable@dpdk.org > >=20 > > Signed-off-by: Kalesh AP > > Reviewed-by: Somnath Kotur > > Reviewed-by: Ajit Khaparde > > --- > > - drivers/net/bnxt/bnxt_stats.c | 2 +- > > - 1 file changed, 1 insertion(+), 1 deletion(-) > > + drivers/net/bnxt/bnxt_stats.c | 1 + > > + 1 file changed, 1 insertion(+) > >=20 > > diff --git a/drivers/net/bnxt/bnxt_stats.c > > b/drivers/net/bnxt/bnxt_stats.c > > -index f486a5634b..fa29f9de19 100644 > > +index 6497926162..e85db7f6d0 100644 > > --- a/drivers/net/bnxt/bnxt_stats.c > > +++ b/drivers/net/bnxt/bnxt_stats.c > > -@@ -575,7 +575,7 @@ int bnxt_dev_xstats_reset_op(struct > > rte_eth_dev *eth_dev) > > - if (BNXT_VF(bp) || !BNXT_SINGLE_PF(bp) || > > +@@ -365,6 +365,7 @@ void bnxt_dev_xstats_reset_op(struct > > rte_eth_dev *eth_dev) > > + if (BNXT_VF(bp) || !BNXT_NPAR_PF(bp) || > > !(bp->flags & BNXT_FLAG_PORT_STATS)) { > > - PMD_DRV_LOG(ERR, "Operation not supported\n"); > > -- ret =3D -ENOTSUP; > > -+ return -ENOTSUP; > > + RTE_LOG(ERR, PMD, "Operation not supported\n"); > > ++ return; > > } > >=20 > > ret =3D bnxt_hwrm_port_clr_stats(bp); >=20 >=20 >=20 --=20 Kind regards, Luca Boccassi